From 73144cf6e85c2283f10c0ff9b8d015a1e659a4e1 Mon Sep 17 00:00:00 2001 From: Ed Silkworth Date: Thu, 15 Jun 2023 15:17:17 -0700 Subject: [PATCH] fixed theme regressions --- CHANGELOG | 3 ++- public/css/theme-arc-red.css | 19 ++++++++----------- public/css/theme-auto-red.css | 33 ++++++++++++++------------------- public/css/theme-red.css | 14 ++++++-------- 4 files changed, 30 insertions(+), 39 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 00b9d42..0a9cd53 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -34,4 +34,5 @@ Mar 1, 2023 · added dark theme and auto theme to mitigate current and any futur May 3, 2023 · `THEME_COLOR_META_TAG = none` no longer required, as of Gitea 1.19.2 Jun 4, 2023 · remove highlight behind some codes that obscured them Jun 5, 2023 · hide center border more between table header columns, and remove tiny empty spaces between table header corner and table border -Jun 7, 2023 · rebased theme \ No newline at end of file +Jun 7, 2023 · rebased theme +Jun 15, 2023 · fixed theme regressions \ No newline at end of file diff --git a/public/css/theme-arc-red.css b/public/css/theme-arc-red.css index ac438fb..b7a6d55 100644 --- a/public/css/theme-arc-red.css +++ b/public/css/theme-arc-red.css @@ -287,24 +287,21 @@ span.green .svg { /* reconsidered: .ui.active.button:hover, .ui.active.button:active */ /* not needed: .ui.tabular.stackable.menu.navbar .active.item */ + +.ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar.shadow-body .active.item { + background: unset !important; /* do not color secondary tabular menu item (Repository, Collaborators, Branches, etc.) */ +} + /* not needed: .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar .active.item */ -.ui.vertical.menu { - background: unset !important; /* make issues, pull requests and milestones menus background match --color-background */ -} - -/* not needed: .ui.top.attached.pull.tabular.stackable.menu .active.item */ - .ui.top.attached.pull.tabular.stackable.menu .active.item { - background-color: rgb(56, 59, 70) !important; /* make pull requests top tabular menu item background match --color-background, using rgb() to remove bottom border */ + background-color: rgb(55, 59, 70) !important; /* make pull requests (upper-sub) tabular menu item background match --color-background (Conversation, Commits, Files Changed), using rgb() to remove bottom border */ } -.ui.top.tabular.menu .active.write.item { - background-color: rgb(56, 59, 70) !important; /* make new releases (sub) tabular menu item background match --color-background, using rgb() to remove bottom border */ -} +/* not needed: .ui.top.tabular.menu .active.write.item */ .ui.top.attached.tabular.menu .active.item { - background-color: var(--color-box-body) !important; /* make subscriptions tabular menu item background match --color-box-body */ + background-color: var(--color-box-body) !important; /* make subscriptions tabular menu item background match --color-box-body (Subscriptions, Watching) */ } /* reconsidered, re-ordered: #repo-files-table tr:hover */ diff --git a/public/css/theme-auto-red.css b/public/css/theme-auto-red.css index b591d3c..0b2813d 100644 --- a/public/css/theme-auto-red.css +++ b/public/css/theme-auto-red.css @@ -55,23 +55,21 @@ /* reconsidered: .ui.active.button:hover, .ui.active.button:active */ .ui.tabular.stackable.menu.navbar .active.item { - background-color: var(--color-background) !important; /* make repo tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make repo tabular menu item background match --color-background (Code, Issues, Pull Requests, etc.) */ } + /* not needed: .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar.shadow-body .active.item */ + .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar .active.item { - background: unset !important; /* do not color secondary menu item, includes stackable ones, related to --color-background */ - } - - .ui.vertical.menu { - background: unset !important; /* make issues, pull requests and milestones menus background match --color-background */ + background: unset !important; /* do not color secondary tabular menu item, related to --color-background (Repositories, Users, Organizations; Profile, Account, Appearance, etc.) */ } .ui.top.attached.pull.tabular.stackable.menu .active.item { - background-color: var(--color-background) !important; /* make pull requests (sub) tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make pull requests (upper-sub) tabular menu item background match --color-background (Conversation, Commits, Files Changed) */ } .ui.top.tabular.menu .active.write.item { - background-color: var(--color-background) !important; /* make new releases (sub) tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make issues, pull requests and new releases (lower-sub) tabular menu item background match --color-background (Write, Preview) */ } /* not needed: .ui.top.attached.tabular.menu .active.item */ @@ -387,24 +385,21 @@ /* reconsidered: .ui.active.button:hover, .ui.active.button:active */ /* not needed: .ui.tabular.stackable.menu.navbar .active.item */ + + .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar.shadow-body .active.item { + background: unset !important; /* do not color secondary tabular menu item (Repository, Collaborators, Branches, etc.) */ + } + /* not needed: .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar .active.item */ - .ui.vertical.menu { - background: unset !important; /* make issues, pull requests and milestones menus background match --color-background */ - } - - /* not needed: .ui.top.attached.pull.tabular.stackable.menu .active.item */ - .ui.top.attached.pull.tabular.stackable.menu .active.item { - background-color: rgb(56, 59, 70) !important; /* make pull requests top tabular menu item background match --color-background, using rgb() to remove bottom border */ + background-color: rgb(55, 59, 70) !important; /* make pull requests (upper-sub) tabular menu item background match --color-background (Conversation, Commits, Files Changed), using rgb() to remove bottom border */ } - .ui.top.tabular.menu .active.write.item { - background-color: rgb(56, 59, 70) !important; /* make new releases (sub) tabular menu item background match --color-background, using rgb() to remove bottom border */ - } + /* not needed: .ui.top.tabular.menu .active.write.item */ .ui.top.attached.tabular.menu .active.item { - background-color: var(--color-box-body) !important; /* make subscriptions tabular menu item background match --color-box-body */ + background-color: var(--color-box-body) !important; /* make subscriptions tabular menu item background match --color-box-body (Subscriptions, Watching) */ } /* reconsidered, re-ordered: #repo-files-table tr:hover */ diff --git a/public/css/theme-red.css b/public/css/theme-red.css index aca214c..b8ea868 100644 --- a/public/css/theme-red.css +++ b/public/css/theme-red.css @@ -52,23 +52,21 @@ span.green .svg { /* reconsidered: .ui.active.button:hover, .ui.active.button:active */ .ui.tabular.stackable.menu.navbar .active.item { - background-color: var(--color-background) !important; /* make repo tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make repo tabular menu item background match --color-background (Code, Issues, Pull Requests, etc.) */ } +/* not needed: .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar.shadow-body .active.item */ + .ui.secondary.pointing.tabular.top.attached.borderless.menu.stackable.new-menu.navbar .active.item { - background: unset !important; /* do not color secondary menu item, includes stackable ones, related to --color-background */ -} - -.ui.vertical.menu { - background: unset !important; /* make issues, pull requests and milestones menus background match --color-background */ + background: unset !important; /* do not color secondary tabular menu item, related to --color-background (Repositories, Users, Organizations; Profile, Account, Appearance, etc.) */ } .ui.top.attached.pull.tabular.stackable.menu .active.item { - background-color: var(--color-background) !important; /* make pull requests (sub) tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make pull requests (upper-sub) tabular menu item background match --color-background (Conversation, Commits, Files Changed) */ } .ui.top.tabular.menu .active.write.item { - background-color: var(--color-background) !important; /* make new releases (sub) tabular menu item background match --color-background */ + background-color: var(--color-background) !important; /* make issues, pull requests and new releases (lower-sub) tabular menu item background match --color-background (Write, Preview) */ } /* not needed: .ui.top.attached.tabular.menu .active.item */