From 2434e96fe95ac26a28800ef9518703013904b101 Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Sun, 16 Jan 2022 15:46:41 -0800 Subject: [PATCH] Removed a hack that was put in when users complained about a tool improperly tagging. This is not the case for most tools. (#949) --- API.Tests/Services/ArchiveServiceTests.cs | 7 ------- API/Services/ArchiveService.cs | 18 +++++++++--------- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/API.Tests/Services/ArchiveServiceTests.cs b/API.Tests/Services/ArchiveServiceTests.cs index 000a2f917..110e5d269 100644 --- a/API.Tests/Services/ArchiveServiceTests.cs +++ b/API.Tests/Services/ArchiveServiceTests.cs @@ -30,13 +30,6 @@ namespace API.Tests.Services _archiveService = new ArchiveService(_logger, _directoryService, new ImageService(Substitute.For>(), _directoryService)); } - // [Fact] - // public void CleanComicInfo_ShouldMapVolumeAndChapterNormally() - // { - // // TODO: Implement this - // Assert.False(true); - // } - [Theory] [InlineData("flat file.zip", false)] [InlineData("file in folder in folder.zip", true)] diff --git a/API/Services/ArchiveService.cs b/API/Services/ArchiveService.cs index 6209c3563..76f7d7283 100644 --- a/API/Services/ArchiveService.cs +++ b/API/Services/ArchiveService.cs @@ -322,15 +322,15 @@ namespace API.Services info.Publisher = Parser.Parser.CleanAuthor(info.Publisher); info.Characters = Parser.Parser.CleanAuthor(info.Characters); - if (!string.IsNullOrEmpty(info.Web)) - { - // ComicVine stores the Issue number in Number field and does not use Volume. - if (!info.Web.Contains("https://comicvine.gamespot.com/")) return; - if (info.Volume.Equals("1")) - { - info.Volume = Parser.Parser.DefaultVolume; - } - } + // if (!string.IsNullOrEmpty(info.Web)) + // { + // // ComicVine stores the Issue number in Number field and does not use Volume. + // if (!info.Web.Contains("https://comicvine.gamespot.com/")) return; + // if (info.Volume.Equals("1")) + // { + // info.Volume = Parser.Parser.DefaultVolume; + // } + // } } ///