From 3f8659499b4c56498ae9745be5570ae0ff505dd3 Mon Sep 17 00:00:00 2001 From: Joe Milazzo Date: Thu, 1 Feb 2024 09:31:31 -0600 Subject: [PATCH] Fix Comic Libraries with Kavita+ (#2676) --- API/Controllers/MetadataController.cs | 2 +- API/Services/Plus/ExternalMetadataService.cs | 4 ++-- openapi.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/API/Controllers/MetadataController.cs b/API/Controllers/MetadataController.cs index ff84d3971..54a6dd053 100644 --- a/API/Controllers/MetadataController.cs +++ b/API/Controllers/MetadataController.cs @@ -234,7 +234,7 @@ public class MetadataController(IUnitOfWork unitOfWork, ILocalizationService loc private async Task PrepareSeriesDetail(List userReviews, SeriesDetailPlusDto ret, AppUser user) { - var isAdmin = User.IsInRole(PolicyConstants.AdminRole); + var isAdmin = await unitOfWork.UserRepository.IsUserAdminAsync(user); userReviews.AddRange(ReviewService.SelectSpectrumOfReviews(ret.Reviews.ToList())); ret.Reviews = userReviews; diff --git a/API/Services/Plus/ExternalMetadataService.cs b/API/Services/Plus/ExternalMetadataService.cs index 424d11cf8..677edf7a8 100644 --- a/API/Services/Plus/ExternalMetadataService.cs +++ b/API/Services/Plus/ExternalMetadataService.cs @@ -97,9 +97,9 @@ public class ExternalMetadataService : IExternalMetadataService var series = await _unitOfWork.SeriesRepository.GetSeriesByIdAsync(seriesId, SeriesIncludes.Metadata | SeriesIncludes.Library | SeriesIncludes.Volumes | SeriesIncludes.Chapters); - if (series == null || series.Library.Type == LibraryType.Comic) return new SeriesDetailPlusDto(); + if (series == null || series.Library.Type == LibraryType.Comic) return null; var user = await _unitOfWork.UserRepository.GetUserByIdAsync(userId); - if (user == null) return new SeriesDetailPlusDto(); + if (user == null) return null; var needsRefresh = await _unitOfWork.ExternalSeriesMetadataRepository.ExternalSeriesMetadataNeedsRefresh(seriesId, diff --git a/openapi.json b/openapi.json index 94c6dab79..f8b487ce8 100644 --- a/openapi.json +++ b/openapi.json @@ -7,7 +7,7 @@ "name": "GPL-3.0", "url": "https://github.com/Kareadita/Kavita/blob/develop/LICENSE" }, - "version": "0.7.13.11" + "version": "0.7.13.12" }, "servers": [ {