Cutlery/Kavita
1
0
Fork 0
mirror of https://github.com/Kareadita/Kavita.git synced 2025-07-09 03:04:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cleaned up some TODOs.

Browse Source
This commit is contained in:
Joseph Milazzo 2021-01-19 12:51:41 -06:00
parent c75feb03e1
commit 44ebca36ec
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
API/Controllers/ReaderController.cs
View File

@ -66,7 +66,7 @@ namespace API.Controllers
user.Progresses.Add(new AppUserProgress user.Progresses.Add(new AppUserProgress
{ {
PagesRead = bookmarkDto.PageNum, // TODO: PagesRead is misleading. Should it be PageNumber or PagesRead (+1)? PagesRead = bookmarkDto.PageNum,
VolumeId = bookmarkDto.VolumeId, VolumeId = bookmarkDto.VolumeId,
SeriesId = bookmarkDto.SeriesId, SeriesId = bookmarkDto.SeriesId,
}); });

5
API/Services/CacheService.cs
View File

@ -110,10 +110,9 @@ namespace API.Services
{ {
var path = GetVolumeCachePath(volume.Id, mangaFile); var path = GetVolumeCachePath(volume.Id, mangaFile);
var files = DirectoryService.GetFiles(path); var files = DirectoryService.GetFiles(path);
var array = files.ToArray(); Array.Sort(files, _numericComparer);
Array.Sort(array, _numericComparer); // TODO: Find a way to apply numericComparer to IList.
return array.ElementAt(page - pagesSoFar); return files.ElementAt(page - pagesSoFar);
} }
pagesSoFar += mangaFile.NumberOfPages; pagesSoFar += mangaFile.NumberOfPages;

4
API/Services/DirectoryService.cs
View File

@ -51,9 +51,9 @@ namespace API.Services
reSearchPattern.IsMatch(Path.GetExtension(file))); reSearchPattern.IsMatch(Path.GetExtension(file)));
} }
public static IList<string> GetFiles(string path) public static string[] GetFiles(string path)
{ {
if (!Directory.Exists(path)) return ImmutableList<string>.Empty; if (!Directory.Exists(path)) return Array.Empty<string>();
return Directory.GetFiles(path); return Directory.GetFiles(path);
} }