From 52b91a9b92e256ee1a850e16c0a43be7b57bf126 Mon Sep 17 00:00:00 2001
From: Joseph Milazzo <joseph.v.milazzo@gmail.com>
Date: Fri, 12 Mar 2021 18:35:12 -0600
Subject: [PATCH] Public caching causes an issue with cache validation on
 browser causing images not to be cached correctly. Made private to ensure we
 get proper images each load.

---
 API/Controllers/LibraryController.cs | 5 -----
 API/DTOs/SearchResultDto.cs          | 1 -
 API/Parser/Parser.cs                 | 2 +-
 API/Startup.cs                       | 6 +++---
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/API/Controllers/LibraryController.cs b/API/Controllers/LibraryController.cs
index 2a0192955..4b8c776df 100644
--- a/API/Controllers/LibraryController.cs
+++ b/API/Controllers/LibraryController.cs
@@ -228,11 +228,6 @@ namespace API.Controllers
         [HttpGet("search")]
         public async Task<ActionResult<IEnumerable<SearchResultDto>>> Search(string queryString)
         {
-            // TODO: Add indecies to DB for the searched fields
-            //NOTE: What about normalizing search query and only searching against normalizedname in Series? 
-            // So One Punch would match One-Punch
-            // This also means less indexes we need.
-            // TODO: Add indexes of what we are searching on
             queryString = queryString.Replace(@"%", "");
             
             var user = await _unitOfWork.UserRepository.GetUserByUsernameAsync(User.GetUsername());
diff --git a/API/DTOs/SearchResultDto.cs b/API/DTOs/SearchResultDto.cs
index d6df106e3..114b3d03b 100644
--- a/API/DTOs/SearchResultDto.cs
+++ b/API/DTOs/SearchResultDto.cs
@@ -6,7 +6,6 @@
         public string Name { get; init; }
         public string OriginalName { get; init; }
         public string SortName { get; init; }
-        //public byte[] CoverImage { get; init; } // This should be optional or a thumbImage (much smaller) // TODO: Refactor to lazy loading
 
         // Grouping information
         public string LibraryName { get; set; }
diff --git a/API/Parser/Parser.cs b/API/Parser/Parser.cs
index 828f7cc86..1e860ab28 100644
--- a/API/Parser/Parser.cs
+++ b/API/Parser/Parser.cs
@@ -422,7 +422,7 @@ namespace API.Parser
 
         public static string Normalize(string name)
         {
-            return name.ToLower().Replace("-", "").Replace(" ", "");
+            return name.ToLower().Replace("-", "").Replace(" ", "").Replace(":", "");
         }
 
         
diff --git a/API/Startup.cs b/API/Startup.cs
index df4d0d41a..e0333217c 100644
--- a/API/Startup.cs
+++ b/API/Startup.cs
@@ -105,11 +105,11 @@ namespace API
                 context.Response.GetTypedHeaders().CacheControl = 
                     new Microsoft.Net.Http.Headers.CacheControlHeaderValue()
                     {
-                        Public = true,
+                        Public = false,
                         MaxAge = TimeSpan.FromSeconds(10)
                     };
-                // context.Response.Headers[Microsoft.Net.Http.Headers.HeaderNames.Vary] = 
-                //     new string[] { "Accept-Encoding" };
+                context.Response.Headers[Microsoft.Net.Http.Headers.HeaderNames.Vary] = 
+                    new string[] { "Accept-Encoding" };
             
                 await next();
             });