Cutlery/Kavita
1
0
Fork 0
mirror of https://github.com/Kareadita/Kavita.git synced 2025-07-09 03:04:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Misc Cleanup (#977)

Browse Source 
* Fixed Day not getting set when reading from epubs.

* Fixed typo for "On Going" to "Ongoing"

* Removed filtering on Reading List page since it doesn't make sense
This commit is contained in:
Joseph Milazzo 2022-01-21 08:08:38 -08:00 committed by GitHub
parent 334221ba88
commit 5f5c24564f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
API/Entities/Enums/PublicationStatus.cs
View File

@ -7,7 +7,7 @@ public enum PublicationStatus
/// <summary> /// <summary>
/// Default Status. Publication is currently in progress /// Default Status. Publication is currently in progress
/// </summary> /// </summary>
[Description("On Going")] [Description("Ongoing")]
OnGoing = 0, OnGoing = 0,
/// <summary> /// <summary>
/// Series is on temp or indefinite Hiatus /// Series is on temp or indefinite Hiatus

1
API/Services/BookService.cs
View File

@ -384,6 +384,7 @@ namespace API.Services
Writer = string.Join(",", epubBook.Schema.Package.Metadata.Creators.Select(c => Parser.Parser.CleanAuthor(c.Creator))), Writer = string.Join(",", epubBook.Schema.Package.Metadata.Creators.Select(c => Parser.Parser.CleanAuthor(c.Creator))),
Publisher = string.Join(",", epubBook.Schema.Package.Metadata.Publishers), Publisher = string.Join(",", epubBook.Schema.Package.Metadata.Publishers),
Month = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Month : 0, Month = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Month : 0,
Day = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Day : 0,
Year = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Year : 0, Year = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Year : 0,
Title = epubBook.Title, Title = epubBook.Title,
Genre = string.Join(",", epubBook.Schema.Package.Metadata.Subjects.Select(s => s.ToLower().Trim())), Genre = string.Join(",", epubBook.Schema.Package.Metadata.Subjects.Select(s => s.ToLower().Trim())),

5
UI/Web/src/app/cards/card-detail-layout/card-detail-layout.component.html
View File

@ -9,12 +9,13 @@
<span class="badge badge-primary badge-pill" attr.aria-label="{{pagination.totalItems}} total items" *ngIf="pagination != undefined">{{pagination.totalItems}}</span> <span class="badge badge-primary badge-pill" attr.aria-label="{{pagination.totalItems}} total items" *ngIf="pagination != undefined">{{pagination.totalItems}}</span>
</h2> </h2>
</div> </div>
<button class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting"> <button *ngIf="!filteringDisabled" class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting">
<i class="fa fa-filter" aria-hidden="true"></i> <i class="fa fa-filter" aria-hidden="true"></i>
<span class="sr-only">Sort / Filter</span> <span class="sr-only">Sort / Filter</span>
</button> </button>
</div> </div>
<div class="phone-hidden"> <div class="phone-hidden">
<div #collapse="ngbCollapse" [(ngbCollapse)]="filteringCollapsed"> <div #collapse="ngbCollapse" [(ngbCollapse)]="filteringCollapsed">
<ng-container [ngTemplateOutlet]="filterSection"></ng-container> <ng-container [ngTemplateOutlet]="filterSection"></ng-container>

4
UI/Web/src/app/cards/card-detail-layout/card-detail-layout.component.ts
View File

@ -57,6 +57,10 @@ export class CardDetailLayoutComponent implements OnInit, OnDestroy {
@Input() isLoading: boolean = false; @Input() isLoading: boolean = false;
@Input() items: any[] = []; @Input() items: any[] = [];
@Input() pagination!: Pagination; @Input() pagination!: Pagination;
/**
* Should filtering be shown on the page
*/
@Input() filteringDisabled: boolean = false;
/** /**
* Any actions to exist on the header for the parent collection (library, collection) * Any actions to exist on the header for the parent collection (library, collection)
*/ */

2
UI/Web/src/app/publication-status.pipe.ts
View File

@ -8,7 +8,7 @@ export class PublicationStatusPipe implements PipeTransform {
transform(value: PublicationStatus): string { transform(value: PublicationStatus): string {
switch (value) { switch (value) {
case PublicationStatus.OnGoing: return 'On Going'; case PublicationStatus.OnGoing: return 'Ongoing';
case PublicationStatus.Hiatus: return 'Hiatus'; case PublicationStatus.Hiatus: return 'Hiatus';
case PublicationStatus.Completed: return 'Completed'; case PublicationStatus.Completed: return 'Completed';

1
UI/Web/src/app/reading-list/reading-lists/reading-lists.component.html
View File

@ -3,6 +3,7 @@
[items]="lists" [items]="lists"
[actions]="actions" [actions]="actions"
[pagination]="pagination" [pagination]="pagination"
[filteringDisabled]="true"
(pageChange)="onPageChange($event)" (pageChange)="onPageChange($event)"
> >
<ng-template #cardItem let-item let-position="idx"> <ng-template #cardItem let-item let-position="idx">