Misc Cleanup (#977)

* Fixed Day not getting set when reading from epubs.

* Fixed typo for "On Going" to "Ongoing"

* Removed filtering on Reading List page since it doesn't make sense
This commit is contained in:
Joseph Milazzo 2022-01-21 08:08:38 -08:00 committed by GitHub
parent 334221ba88
commit 5f5c24564f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 4 deletions

View File

@ -7,7 +7,7 @@ public enum PublicationStatus
/// <summary>
/// Default Status. Publication is currently in progress
/// </summary>
[Description("On Going")]
[Description("Ongoing")]
OnGoing = 0,
/// <summary>
/// Series is on temp or indefinite Hiatus

View File

@ -384,6 +384,7 @@ namespace API.Services
Writer = string.Join(",", epubBook.Schema.Package.Metadata.Creators.Select(c => Parser.Parser.CleanAuthor(c.Creator))),
Publisher = string.Join(",", epubBook.Schema.Package.Metadata.Publishers),
Month = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Month : 0,
Day = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Day : 0,
Year = !string.IsNullOrEmpty(publicationDate) ? DateTime.Parse(publicationDate).Year : 0,
Title = epubBook.Title,
Genre = string.Join(",", epubBook.Schema.Package.Metadata.Subjects.Select(s => s.ToLower().Trim())),

View File

@ -10,11 +10,12 @@
</h2>
</div>
<button class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting">
<button *ngIf="!filteringDisabled" class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting">
<i class="fa fa-filter" aria-hidden="true"></i>
<span class="sr-only">Sort / Filter</span>
</button>
</div>
<div class="phone-hidden">
<div #collapse="ngbCollapse" [(ngbCollapse)]="filteringCollapsed">
<ng-container [ngTemplateOutlet]="filterSection"></ng-container>

View File

@ -57,6 +57,10 @@ export class CardDetailLayoutComponent implements OnInit, OnDestroy {
@Input() isLoading: boolean = false;
@Input() items: any[] = [];
@Input() pagination!: Pagination;
/**
* Should filtering be shown on the page
*/
@Input() filteringDisabled: boolean = false;
/**
* Any actions to exist on the header for the parent collection (library, collection)
*/

View File

@ -8,7 +8,7 @@ export class PublicationStatusPipe implements PipeTransform {
transform(value: PublicationStatus): string {
switch (value) {
case PublicationStatus.OnGoing: return 'On Going';
case PublicationStatus.OnGoing: return 'Ongoing';
case PublicationStatus.Hiatus: return 'Hiatus';
case PublicationStatus.Completed: return 'Completed';

View File

@ -3,6 +3,7 @@
[items]="lists"
[actions]="actions"
[pagination]="pagination"
[filteringDisabled]="true"
(pageChange)="onPageChange($event)"
>
<ng-template #cardItem let-item let-position="idx">