From bfc4f17e053b4002632ac234f241a1a3b868f3d0 Mon Sep 17 00:00:00 2001
From: Joe Milazzo <josephmajora@gmail.com>
Date: Sun, 28 Jan 2024 15:04:45 -0600
Subject: [PATCH] Polish for Release (#2663)

---
 API/Services/Plus/ExternalMetadataService.cs               | 7 +++++--
 .../_components/register/register.component.html           | 6 +++---
 .../app/registration/user-login/user-login.component.html  | 4 ++--
 .../change-password/change-password.component.html         | 4 +++-
 openapi.json                                               | 2 +-
 5 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/API/Services/Plus/ExternalMetadataService.cs b/API/Services/Plus/ExternalMetadataService.cs
index 9a157479e..60f945741 100644
--- a/API/Services/Plus/ExternalMetadataService.cs
+++ b/API/Services/Plus/ExternalMetadataService.cs
@@ -147,7 +147,6 @@ public class ExternalMetadataService : IExternalMetadataService
 
 
             // Recommendations
-
             externalSeriesMetadata.ExternalRecommendations ??= new List<ExternalRecommendation>();
             var recs = await ProcessRecommendations(series, user, result.Recommendations, externalSeriesMetadata);
 
@@ -165,7 +164,11 @@ public class ExternalMetadataService : IExternalMetadataService
             {
                 Recommendations = recs,
                 Ratings = result.Ratings,
-                Reviews = result.Reviews
+                Reviews = result.Reviews.Select(r =>
+                {
+                    r.IsExternal = true;
+                    return r;
+                })
             };
         }
         catch (FlurlHttpException ex)
diff --git a/UI/Web/src/app/registration/_components/register/register.component.html b/UI/Web/src/app/registration/_components/register/register.component.html
index ab0d7fb9f..c9fe8ccf3 100644
--- a/UI/Web/src/app/registration/_components/register/register.component.html
+++ b/UI/Web/src/app/registration/_components/register/register.component.html
@@ -6,7 +6,7 @@
       <form [formGroup]="registerForm" (ngSubmit)="submit()">
         <div class="mb-3">
           <label for="username" class="form-label">{{t('username-label')}}</label>
-          <input id="username" class="form-control" formControlName="username" type="text"
+          <input id="username" class="form-control" formControlName="username" type="text" autocomplete="username"
                  [class.is-invalid]="registerForm.get('username')?.invalid && registerForm.get('username')?.touched" aria-describedby="username-validations">
           <div id="username-validations" class="invalid-feedback" *ngIf="registerForm.dirty || registerForm.touched">
             <div *ngIf="registerForm.get('username')?.errors?.required">
@@ -21,7 +21,7 @@
           <span class="visually-hidden" id="email-help">
             <ng-container [ngTemplateOutlet]="emailTooltip"></ng-container>
           </span>
-          <input class="form-control" type="email" inputmode="email" id="email" formControlName="email" required aria-describedby="email-help"
+          <input class="form-control" type="email" inputmode="email" id="email" autocomplete="email" formControlName="email" required aria-describedby="email-help"
                  [class.is-invalid]="registerForm.get('email')?.invalid && registerForm.get('email')?.touched">
           <div id="email-validations" class="invalid-feedback" *ngIf="registerForm.dirty || registerForm.touched">
             <div *ngIf="registerForm.get('email')?.errors?.required">
@@ -39,7 +39,7 @@
             {{t('password-validation')}}
           </ng-template>
           <span class="visually-hidden" id="password-help"><ng-container [ngTemplateOutlet]="passwordTooltip"></ng-container></span>
-          <input id="password" class="form-control" maxlength="32" minlength="6" pattern="^.{6,32}$" formControlName="password"
+          <input id="password" class="form-control" maxlength="32" minlength="6" pattern="^.{6,32}$" formControlName="password" autocomplete="new-password"
                  type="password" aria-describedby="password-help" [class.is-invalid]="registerForm.get('password')?.invalid && registerForm.get('password')?.touched">
           <div id="password-validations" class="invalid-feedback" *ngIf="registerForm.dirty || registerForm.touched">
             <div *ngIf="registerForm.get('password')?.errors?.required">
diff --git a/UI/Web/src/app/registration/user-login/user-login.component.html b/UI/Web/src/app/registration/user-login/user-login.component.html
index bc4964bfd..eb845d9ca 100644
--- a/UI/Web/src/app/registration/user-login/user-login.component.html
+++ b/UI/Web/src/app/registration/user-login/user-login.component.html
@@ -7,13 +7,13 @@
           <div class="card-text">
             <div class="mb-3">
               <label for="username" class="form-label visually-hidden">{{t('username')}}</label>
-              <input class="form-control custom-input" formControlName="username" id="username"
+              <input class="form-control custom-input" formControlName="username" id="username" autocomplete="username"
                      type="text" autofocus [placeholder]="t('username')">
             </div>
 
             <div class="mb-2">
               <label for="password" class="form-label visually-hidden">{{t('password')}}</label>
-              <input class="form-control custom-input" formControlName="password" name="password"
+              <input class="form-control custom-input" formControlName="password" name="password" autocomplete="current-password"
                      id="password" type="password" [placeholder]="t('password')">
             </div>
 
diff --git a/UI/Web/src/app/user-settings/change-password/change-password.component.html b/UI/Web/src/app/user-settings/change-password/change-password.component.html
index ab0034d70..85c274fa5 100644
--- a/UI/Web/src/app/user-settings/change-password/change-password.component.html
+++ b/UI/Web/src/app/user-settings/change-password/change-password.component.html
@@ -24,7 +24,7 @@
           <form [formGroup]="passwordChangeForm">
             <div class="mb-3">
               <label for="oldpass" class="form-label">{{t('current-password-label')}}</label>
-              <input class="form-control custom-input" type="password" id="oldpass" formControlName="oldPassword"
+              <input class="form-control custom-input" type="password" id="oldpass" formControlName="oldPassword" autocomplete="current-password"
                      [class.is-invalid]="passwordChangeForm.get('oldPassword')?.invalid && passwordChangeForm.get('oldPassword')?.touched">
               <div id="inviteForm-validations" class="invalid-feedback" *ngIf="passwordChangeForm.dirty || passwordChangeForm.touched">
                 <div *ngIf="passwordChangeForm.get('oldPassword')?.errors?.required">
@@ -36,6 +36,7 @@
             <div class="mb-3">
               <label for="new-password">{{t('new-password-label')}}</label>
               <input class="form-control" type="password" id="new-password" formControlName="password" aria-describedby="new-password-validations"
+                     autocomplete="new-password"
                      [class.is-invalid]="passwordChangeForm.get('password')?.invalid && passwordChangeForm.get('password')?.touched">
               <div id="new-password-validations" class="invalid-feedback" *ngIf="passwordChangeForm.dirty || passwordChangeForm.touched">
                 <div *ngIf="password?.errors?.required">
@@ -46,6 +47,7 @@
             <div class="mb-3">
               <label for="confirm-password">{{t('confirm-password-label')}}</label>
               <input class="form-control" type="password" id="confirm-password" formControlName="confirmPassword" aria-describedby="confirm-password-validations"
+                     autocomplete="new-password"
                      [class.is-invalid]="passwordChangeForm.get('confirmPassword')?.invalid && passwordChangeForm.get('confirmPassword')?.touched">
               <div id="confirm-password-validations" class="invalid-feedback" *ngIf="passwordChangeForm.dirty || passwordChangeForm.touched">
                 <div *ngIf="!passwordsMatch">
diff --git a/openapi.json b/openapi.json
index 36979837f..1d779afe5 100644
--- a/openapi.json
+++ b/openapi.json
@@ -7,7 +7,7 @@
       "name": "GPL-3.0",
       "url": "https://github.com/Kareadita/Kavita/blob/develop/LICENSE"
     },
-    "version": "0.7.13.7"
+    "version": "0.7.13.9"
   },
   "servers": [
     {