Release Testing Part 2 (#1794)

* Stop showing loading indicator when no next/prev chapter

* Fixed a bug where manage collections wasn't named correctly in UI.

* Slight tweaks on email flow

* Fixed a bug where we were grabbing wrong property for book layout mode

* Fixed an issue where pagination area wasn't properly spanning window on different scaling modes.

* Fixed a bug where right pagination area wasn't sticking to the right hand side on original scaling

* Added a note from reading an epub3

* Reworked some of the readme

API/Services/BookService.cs

@@ -623,7 +623,7 @@ public class BookService : IBookService
                             series = metadataItem.Content;
                             break;
                         case "collection-type":
-                            // These look to be genres from https://manual.calibre-ebook.com/sub_groups.html
+                            // These look to be genres from https://manual.calibre-ebook.com/sub_groups.html or can be "series"
                             break;
                     }
                 }

README.md

@@ -3,8 +3,7 @@
 
 ![new_github_preview_stills](https://user-images.githubusercontent.com/735851/169657008-37812c18-5490-4e2a-9dcb-4806f8c87c69.gif)
 
-Kavita is a fast, feature rich, cross platform reading server. Built with a focus for manga,
-and the goal of being a full solution for all your reading needs. Setup your own server and share
+Kavita is a fast, feature rich, cross platform reading server. Built with a focus for being a full solution for all your reading needs. Setup your own server and share
 your reading collection with your friends and family!
 
 [![Release](https://img.shields.io/github/release/Kareadita/Kavita.svg?style=flat&maxAge=3600)](https://github.com/Kareadita/Kavita/releases)
@@ -18,11 +17,12 @@ your reading collection with your friends and family!
 </div>
 
 ## Goals
-- [x] Serve up Manga/Webtoons/Comics (cbr, cbz, zip/rar, 7zip, raw images) and Books (epub, pdf)
+- [x] Serve up Manga/Webtoons/Comics (cbr, cbz, zip/rar/rar5, 7zip, raw images) and Books (epub, pdf)
 - [x] First class responsive readers that work great on any device (phone, tablet, desktop)
 - [x] Dark mode and customizable theming support
 - [ ] Provide a plugin system to allow external metadata integration and scrobbling for read status, ratings, and reviews
-- [x] Metadata should allow for collections, want to read integration from 3rd party services, genres.
+- [x] Rich Metadata support with filtering and searching
+- [x] Ways to group reading material: Collections, Reading Lists, Want to Read
 - [x] Ability to manage users, access, and ratings
 - [x] Fully Accessible with active accessibility audits
 - [x] Dedicated webtoon reading mode
@@ -57,18 +57,19 @@ Kavita is being actively developed and should be considered beta software until
 Kavita may be subject to changes in how the platform functions as it is being built out toward the
 vision. You may lose data and have to restart. The Kavita team strives to avoid any data loss.
 
+## Donate
+If you like Kavita, have gotten good use out of it, or feel like you want to say thanks with a few bucks, feel free to donate. Money will go towards
+expenses related to Kavita. Back us through [OpenCollective](https://opencollective.com/Kavita#backer). You can also use [Paypal](https://www.paypal.com/paypalme/majora2007?locale.x=en_US), however your name will not show below.
+
+
 ## Contributors
 
-This project exists thanks to all the people who contribute. [Contribute](CONTRIBUTING.md).
+This project exists thanks to all the people who contribute and downstream library maintainers. [Contribute](CONTRIBUTING.md).
 <a href="https://github.com/Kareadita/Kavita/graphs/contributors">
 <img src="https://opencollective.com/kavita/contributors.svg?width=890&button=false&avatarHeight=42" />
 </a>
 
 
-## Donate
-If you like Kavita, have gotten good use out of it, or feel like you want to say thanks with a few bucks, feel free to donate. Money will go towards
-expenses related to Kavita. Back us through [OpenCollective](https://opencollective.com/Kavita#backer). You can also use [Paypal](https://www.paypal.com/paypalme/majora2007?locale.x=en_US), however your name will not show below.
-
 ## Backers
 
 Thank you to all our backers! 🙏 [Become a backer](https://opencollective.com/Kavita#backer)

UI/Web/src/app/book-reader/_components/reader-settings/reader-settings.component.ts

@@ -250,7 +250,7 @@ export class ReaderSettingsComponent implements OnInit, OnDestroy {
     this.settingsForm.get('bookReaderMargin')?.setValue(this.user.preferences.bookReaderMargin);
     this.settingsForm.get('bookReaderReadingDirection')?.setValue(this.user.preferences.bookReaderReadingDirection);
     this.settingsForm.get('bookReaderTapToPaginate')?.setValue(this.user.preferences.bookReaderTapToPaginate);
-    this.settingsForm.get('layoutMode')?.setValue(this.user.preferences.layoutMode);
+    this.settingsForm.get('bookReaderLayoutMode')?.setValue(this.user.preferences.bookReaderLayoutMode);
     this.settingsForm.get('bookReaderImmersiveMode')?.setValue(this.user.preferences.bookReaderImmersiveMode);
     this.cdRef.detectChanges();
     this.styleUpdate.emit(this.pageStyles);

UI/Web/src/app/manga-reader/_components/manga-reader/manga-reader.component.html

@@ -44,7 +44,7 @@
             <!-- Pagination controls and screen hints-->
             <div class="pagination-area">
                 <div class="{{readerMode === ReaderMode.LeftRight ? 'left' : 'top'}} {{clickOverlayClass('left')}}" (click)="handlePageChange($event, KeyDirection.Left)" 
-                    [ngStyle]="{'height': (readerMode === ReaderMode.LeftRight ? ImageHeight: '25%')}">
+                    [ngStyle]="{'height': (readerMode === ReaderMode.LeftRight ? ImageHeight: '25%'), 'max-height': MaxHeight}">
                     <div *ngIf="showClickOverlay">
                         <i class="fa fa-angle-{{readingDirection === ReadingDirection.RightToLeft ? 'double-' : ''}}{{readerMode === ReaderMode.LeftRight ? 'left' : 'up'}}"
                          title="Previous Page" aria-hidden="true"></i>
@@ -53,7 +53,8 @@
                 <div class="{{readerMode === ReaderMode.LeftRight ? 'right' : 'bottom'}} {{clickOverlayClass('right')}}" (click)="handlePageChange($event, KeyDirection.Right)"
                     [ngStyle]="{'height': (readerMode === ReaderMode.LeftRight ? ImageHeight: '25%'),
                                 'left': 'inherit',
-                                'right': RightPaginationOffset + 'px'}">
+                                'right': RightPaginationOffset + 'px',
+                                'max-height': MaxHeight}">
                     <div *ngIf="showClickOverlay">
                         <i class="fa fa-angle-{{readingDirection === ReadingDirection.LeftToRight ? 'double-' : ''}}{{readerMode === ReaderMode.LeftRight ? 'right' : 'down'}}"
                          title="Next Page" aria-hidden="true"></i>

UI/Web/src/app/manga-reader/_components/manga-reader/manga-reader.component.ts

@@ -370,12 +370,22 @@ export class MangaReaderComponent implements OnInit, AfterViewInit, OnDestroy {
   }
 
   get ImageHeight() {
-    if (this.FittingOption !== FITTING_OPTION.HEIGHT) return this.mangaReaderService.getPageDimensions(this.pageNum)?.height  + 'px';
+    if (this.FittingOption !== FITTING_OPTION.HEIGHT) {
+      return this.mangaReaderService.getPageDimensions(this.pageNum)?.height  + 'px';
+    }
     return this.readingArea?.nativeElement?.clientHeight + 'px';
   }
 
+  // This is for the pagination area
+  get MaxHeight() {
+    if (this.FittingOption !== FITTING_OPTION.HEIGHT) {
+      return this.mangaReaderService.getPageDimensions(this.pageNum)?.height  + 'px';
+    }
+    return 'calc(var(--vh) * 100)';
+  }
+
   get RightPaginationOffset() {
-    if (this.readerMode === ReaderMode.LeftRight && this.FittingOption === FITTING_OPTION.HEIGHT) {
+    if (this.readerMode === ReaderMode.LeftRight && this.FittingOption !== FITTING_OPTION.WIDTH) {
       return (this.readingArea?.nativeElement?.scrollLeft || 0) * -1;
     }
     return 0;