From cb57e48000748955228356ee987dd5f97f6f3d1a Mon Sep 17 00:00:00 2001
From: Joe Milazzo <josephmajora@gmail.com>
Date: Wed, 9 Aug 2023 10:34:33 -0500
Subject: [PATCH] Last Fixes before Release (#2192)

* Removed Moq from the project. Fixed a localization string

* Fixed a bug with virtualized reading lists when reordering, it wouldn't use the correct order index.

* Added some german common strings cause weblate is a PIA to use.

* Added a bug marker for something that needs another release for
---
 API.Tests/API.Tests.csproj                    |  1 -
 API/Services/Tasks/Scanner/ProcessSeries.cs   |  1 +
 .../draggable-ordered-list.component.html     |  4 +-
 UI/Web/src/assets/langs/de.json               | 38 +++++++++----------
 UI/Web/src/assets/langs/en.json               |  2 +-
 openapi.json                                  |  2 +-
 6 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/API.Tests/API.Tests.csproj b/API.Tests/API.Tests.csproj
index 36bb142fe..24d6cb94c 100644
--- a/API.Tests/API.Tests.csproj
+++ b/API.Tests/API.Tests.csproj
@@ -8,7 +8,6 @@
     <ItemGroup>
         <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="7.0.10" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.0" />
-        <PackageReference Include="Moq" Version="4.20.1" />
         <PackageReference Include="NSubstitute" Version="5.0.0" />
         <PackageReference Include="System.IO.Abstractions.TestingHelpers" Version="19.2.51" />
         <PackageReference Include="TestableIO.System.IO.Abstractions.Wrappers" Version="19.2.51" />
diff --git a/API/Services/Tasks/Scanner/ProcessSeries.cs b/API/Services/Tasks/Scanner/ProcessSeries.cs
index 6ad7f6100..f30da8a47 100644
--- a/API/Services/Tasks/Scanner/ProcessSeries.cs
+++ b/API/Services/Tasks/Scanner/ProcessSeries.cs
@@ -146,6 +146,7 @@ public class ProcessSeries : IProcessSeries
             _logger.LogInformation("[ScannerService] Processing series {SeriesName}", series.OriginalName);
 
             // parsedInfos[0] is not the first volume or chapter. We need to find it using a ComicInfo check (as it uses firstParsedInfo for series sort)
+            // BUG: This check doesn't work for Books, as books usually have metadata on all files. (#2167)
             var firstParsedInfo = parsedInfos.FirstOrDefault(p => p.ComicInfo != null, firstInfo);
 
             UpdateVolumes(series, parsedInfos, forceUpdate);
diff --git a/UI/Web/src/app/reading-list/_components/draggable-ordered-list/draggable-ordered-list.component.html b/UI/Web/src/app/reading-list/_components/draggable-ordered-list/draggable-ordered-list.component.html
index ca0562b6b..0cd40a623 100644
--- a/UI/Web/src/app/reading-list/_components/draggable-ordered-list/draggable-ordered-list.component.html
+++ b/UI/Web/src/app/reading-list/_components/draggable-ordered-list/draggable-ordered-list.component.html
@@ -7,9 +7,9 @@
                     <div class="d-flex list-container">
                         <div class="me-3 align-middle">
                             <div style="padding-top: 40px">
-                                <label for="reorder-{{i}}" class="form-label visually-hidden">{{t('reorder-label')}}</label>
+                                <label for="reorder-{{item.order}}" class="form-label visually-hidden">{{t('reorder-label')}}</label>
                                 <input *ngIf="accessibilityMode" id="reorder-{{i}}" class="form-control" type="number" inputmode="numeric" min="0" [max]="items.length - 1" [value]="item.order" style="width: 60px"
-                                (focusout)="updateIndex(i, item)" (keydown.enter)="updateIndex(i, item)" aria-describedby="instructions">
+                                (focusout)="updateIndex(item.order, item)" (keydown.enter)="updateIndex(item.order, item)" aria-describedby="instructions">
                             </div>
                         </div>
 
diff --git a/UI/Web/src/assets/langs/de.json b/UI/Web/src/assets/langs/de.json
index af4b727e6..fc787d719 100644
--- a/UI/Web/src/assets/langs/de.json
+++ b/UI/Web/src/assets/langs/de.json
@@ -1657,28 +1657,28 @@
     },
     "common": {
         "reset-to-default": "",
-        "close": "",
-        "cancel": "",
-        "create": "",
-        "save": "",
+        "close": "Schließen",
+        "cancel": "Stornieren",
+        "create": "Erstellen",
+        "save": "Speichern",
         "reset": "",
-        "add": "",
+        "add": "Hinzufügen",
         "apply": "",
-        "delete": "",
-        "edit": "",
-        "help": "",
-        "submit": "",
-        "email": "",
-        "read": "",
-        "loading": "",
-        "username": "",
-        "password": "",
+        "delete": "Löschen",
+        "edit": "Bearbeiten",
+        "help": "Hilfe",
+        "submit": "Einreichen",
+        "email": "Email",
+        "read": "Lesen",
+        "loading": "Wird geladen…",
+        "username": "Nutzername",
+        "password": "Passwort",
         "promoted": "",
-        "select-all": "",
-        "deselect-all": "",
-        "series-count": "",
-        "item-count": "",
-        "book-num": "",
+        "select-all": "Wählen Sie Alle",
+        "deselect-all": "Alle abwählen",
+        "series-count": "{{num}}er-Serie",
+        "item-count": "{{num}} Artikel",
+        "book-num": "Buch",
         "issue-hash-num": "",
         "issue-num": "",
         "chapter-num": "",
diff --git a/UI/Web/src/assets/langs/en.json b/UI/Web/src/assets/langs/en.json
index 7d96cbea0..e6a19197f 100644
--- a/UI/Web/src/assets/langs/en.json
+++ b/UI/Web/src/assets/langs/en.json
@@ -429,7 +429,7 @@
         "month-ago": "a month ago",
         "months-ago": "{{value}} months ago",
         "year-ago": "a year ago",
-        "years-ago": "{[value}} years ago"
+        "years-ago": "{{value}} years ago"
     },
 
     "relationship-pipe": {
diff --git a/openapi.json b/openapi.json
index f0ca9cf28..8a829ef82 100644
--- a/openapi.json
+++ b/openapi.json
@@ -7,7 +7,7 @@
       "name": "GPL-3.0",
       "url": "https://github.com/Kareadita/Kavita/blob/develop/LICENSE"
     },
-    "version": "0.7.6.13"
+    "version": "0.7.6.14"
   },
   "servers": [
     {