Commit Graph

249 Commits

Author SHA1 Message Date
Joseph Milazzo 16a77fa8d6 Download Support (#298)
* Implemented the ability to download files (series, volume, chapter)

* Added RBS checks to ensure user is either an admin or has download role

* Added the ability to change a users feature RBS. Changed the Role seed to use reflection
2021-06-10 07:47:35 -05:00
Joseph Milazzo 8d8e7ce93b Book Grouping (#292)
* Implemented the ability to group books by series if certain calibre tags are in the epub.
2021-06-08 12:33:54 -05:00
Robbie Davis 4f29cf7cc7 Bugfix/manga reader pad zeros (#288)
* Switched to using existing NaturalSortComparer for ordering filenames before we reprocess them to ensure they are in the correct natural reading order.

Co-authored-by: Joseph Milazzo <joseph.v.milazzo@gmail.com>
2021-06-08 08:59:47 -05:00
Joseph Milazzo 7dae1da92f Logging Enhancements (#285)
* If the user is on Debug, allow logging DB params to the logger. Implemented the ability to change logger from UI and to keep the DB settings of LogLevel and Port in sync with appsettings.

* Exclude a lot more clutter from hitting Sentry

* Removed github action

* Small cleanup
2021-06-07 17:52:11 -05:00
Joseph Milazzo 6f124b6f8a Add try catch on Parser MinimumNumberFromRange in case something weird gets put in here. (#283) 2021-06-07 16:12:07 -05:00
Joseph Milazzo 41a5d1bf2c Fixed a bug on getting next/previous chapters where if chapters were … (#281)
* Fixed a bug on getting next/previous chapters where if chapters were not inserted into the DB in the natural order, then the next/prev chapter would be skewed.

* Make GetNextChapterId static
2021-06-07 14:49:38 -05:00
Joseph Milazzo 5259a1484a Implemented the ability to configure the default port for non-docker users. Docker users will always be 5000. (#280) 2021-06-07 14:36:35 -05:00
Joseph Milazzo 4606b54603 Removed the SeriesMetadata migration since users have updated to v0.4.1. Any other users will require a scan to get the SeriesMetadata generated. (#275) 2021-06-07 13:16:50 -05:00
Joseph Milazzo e4a9c468fe Version bump and reduced some sentry logs 2021-06-07 11:32:26 -05:00
Joseph Milazzo f0f74e867e Fixed the constraint issue with Metadata and ensure we log parameters on development modes. (#273) 2021-06-06 16:13:07 -05:00
Joseph Milazzo 8175ddf517 Fixed a critical crash in Scan library where Series Metadata was getting regenerated and unique constraint failed. (#269) 2021-06-05 16:30:50 -05:00
Joseph Milazzo aa7439178c Don't log exceptions to Sentry when debugging locally. Fixed a constraint issue with collection tags that prevented deleting series. Ensure when we scan we add SeriesMetadata objects to existing series. (#265) 2021-06-04 17:49:19 -05:00
Robbie Davis 606e4c8b12 Recently Added Page (#261)
- Updated route task for 'recently-added'.
- Refactored GetRecentlyAdded task instead of creating new API task. This way is more efficient and prevents bloat.
- Adding pageSize to UserParams.cs (got lost in PRs).
2021-06-04 10:09:33 -05:00
Joseph Milazzo e6cfa4feca Bugfix/anchor rewriting (#260)
* Added book reader reading direction preference

* Adds a new marker to the AppUserProgress to capture nearest anchor for resuming scroll point when reading books. Refactored bookmark api to return a BookmarkDto which includes this new data.

* Fixed the readme image displaying issue and changed up a bit more of the layout.
2021-06-03 18:33:24 -05:00
Joseph Milazzo 4910f1d1d0 Book Reading Progress Enhancement (#259)
* Added book reader reading direction preference

* Adds a new marker to the AppUserProgress to capture nearest anchor for resuming scroll point when reading books. Refactored bookmark api to return a BookmarkDto which includes this new data.
2021-06-03 18:33:13 -05:00
Leonardo Dias c12879cda9 feat: remove Webtoon option from Library Types (#254)
Fixes #251
2021-06-03 15:46:57 -05:00
Leonardo Dias b38ea8186e fix: error when resetting password of a non admin user (#252)
Fixes #246
2021-06-03 12:17:57 -05:00
Joseph Milazzo 03c9b7a11d Added book reader reading direction preference (#249) 2021-06-03 09:05:07 -05:00
Leonardo Dias 16d6b26c63 fix: wrong password length validation when registering a new user or resetting password (#247)
#244

Co-authored-by: leo2d <contato.leonardod@yahoo.com>
2021-06-03 07:16:32 -05:00
Joseph Milazzo 5083608f24 Bugfix/sentry and fixes (#243)
* Generate SeriesMetadata when creating Series from Scanner.

* Ignore errors from BookService

* Fixed a case where we used First() when it should have been FirstOrDefault() to fail when there are no cover images (or images)
2021-06-01 19:42:43 -05:00
Joseph Milazzo ce35c4f84a CB7 Support (#241)
* Added CB7 file extension support
2021-06-01 08:37:46 -05:00
Joseph Milazzo aaad82cb7a Reduce Unauthenticated Errors in Sentry (#238)
* Updated README to be explicit that kavita.db needs to be writable.

* Implemented a new Exception type that is for throwing a message to UI without logging in Sentry.
2021-06-01 06:57:46 -05:00
Joseph Milazzo 0a39a17407 TokenKey Generation (#235)
* Fixed #223. Now we generate a 128 byte JWT token key (recommendation) for user on first run.
2021-05-31 10:14:39 -05:00
Joseph Milazzo d7d7f9b529 Collection Support (#234)
* Readme refactored to be more clean and clear, taking inspiration from wiki.js's readme.

* Initial backend for Collections and basic metadata implemented.

* More build flavors for Raspberry Pi users and updated Install since we don't need users to set their own JWT Token Key. Update a typo in appsettings.json file for prod.

* Fixed #224. Sort before getting a First?Last() chatper

* The rough ability to add and get series metadata and tags.

* Fix a bug on getting metadata for when it doesn't exist.

* Fixed a bug where flattening directories with some unique filenames could cause reading order of images to be out of order.

* Added a seed code to ensure all series have SeriesMetdata

* Ensure all instances of opening an epub is using "using" so we don't lock the file. When we have a malformed html file, log the issues and inform the user we can't open the file.

* Book reader now handles @Import "" statements in CSS and inlines the css into css file that references them. This allows for them to be scoped. In addition, if the html or body tag had classes, we now send back a single div with those classes.

* Fixed GetSeriesDtoForCollectionAsync which was not properly returning series

* Implemented cover image for collection tag. Fixed an issue in metadata update call.

* Add check for user access when resolving series for a collection tag. When asking for all tags, if the user is not an admin, only give promotoed tags back.

* Implemented updateTag api

* Implemented the ability to update series the tags have access to.

* Cleanup, sorting, and null check

* More sorting changes

* Ensure we can delete tags when editing a series tags

* Fix order of update to make sure a tag is properly deleted

* Code smells
2021-05-30 17:24:23 -05:00
Joseph Milazzo 3c375da10c Bugfix/appsettings (#229)
* More build flavors for Raspberry Pi users and updated Install since we don't need users to set their own JWT Token Key. Update a typo in appsettings.json file for prod.
2021-05-20 18:16:00 -05:00
Joseph Milazzo 50af2f8ca5 Fixed #224. Sort before getting a First?Last() chatper (#228) 2021-05-20 18:09:15 -05:00
Joseph Milazzo fdc925812d Bugfix: Flatten wasn't consistent (#227)
* Ensure that when caching, the order of the cached files remains the same way as if we manually navigated through nested folders.
2021-05-20 18:01:14 -05:00
Joseph Milazzo 77c52717ce MinimumNumberFromRange exception (#222)
* More regex! Bonus is now a keyword for specials

* Regex enhancement, Sort chapters on next/prev chapter to ensure they always in proper order, and don't set JWT on starup when in development mode.

* Fixes KAVITA-H. Check to ensure non numeric characters are not in range string before attempting to parse a float out.
2021-05-17 09:31:16 -05:00
Joseph Milazzo 308e2b48a0 Bugfixes (#221)
* More regex! Bonus is now a keyword for specials

* Regex enhancement, Sort chapters on next/prev chapter to ensure they always in proper order, and don't set JWT on starup when in development mode.
2021-05-16 16:45:39 -05:00
Joseph Milazzo 2f793af34c More regex! Bonus is now a keyword for specials (#220) 2021-05-16 13:13:19 -05:00
Joseph Milazzo 03b49a5268 Implemented the ability to change the JWT key on runtime. (#217)
* Implemented the ability to change the JWT key on runtime.

* Added .7z file extension support

* Cleanup

* Added Feathub link

* Code cleanup

* Fixed up a build issue on CI
2021-05-14 08:07:03 -05:00
Joseph Milazzo 98e8b7297b Tell sentry to ignore some noisy messages, add a bounds check on an API, and tweak some ERRORs to be WARNINGs to better reflect their severity. (#216) 2021-05-13 11:36:16 -05:00
Joseph Milazzo beca4a4de5 Bugfix/parser (#214)
* Fixed #211

* Fixed #213. Somehow a + 1 got removed
2021-05-11 15:57:11 -05:00
Joseph Milazzo c8adaee3eb Sentry Integration (#212)
* Fixed a parsing case

* Integrated Sentry into the solution with anonymous users. Fixed some parsing issues and added BuildInfo into a separate project.

* Fixed some bad parser regex

* Removed bad reference to NLog

* Cleanup of some files not needed
2021-05-11 14:45:18 -05:00
Joseph Milazzo 6fc5e535df Fixed #206 (#207) 2021-05-10 09:50:26 -05:00
Joseph Milazzo ecc399b32a Fixed #204. Raised max password to 32 characters (#205) 2021-05-09 11:26:22 -05:00
Joseph Milazzo 8b1fbc0096 Implemented Dark Mode (#203) 2021-05-09 08:44:12 -05:00
Joseph Milazzo e37931b0da Regex addition (#200) 2021-05-06 16:51:16 -05:00
Joseph Milazzo f694145cd9 Feature/tech debt (#199)
* Added an icon for building the exe

* Technical debt
2021-05-05 21:00:50 -05:00
Joseph Milazzo d92e9e7602 Implemented the ability to move between volumes (reading) automatically without existing the app. (#198) 2021-05-05 16:48:39 -05:00
Joseph Milazzo 2be1630af3 Tap to Paginate User Pref (#197)
* Fixed In Progress and removed comments

* Tap to Paginate user setting is implemented. Fixes #193
2021-05-04 17:01:27 -05:00
Joseph Milazzo 9c43833989 Bugfixes/misc (#196)
* Removed an error log statment which wasn't valid. Was showing error when a comicinfo.xml was not found in a directory.

* Fixed #191. Don't overwrite summary information if we already have something set from UI.

* Fixes #192

* Fixed #194 by moving the Take to after the query runs, so we take only distinct series.

* Added another case for Regex parsing for VanDread-v01-c01.zip
2021-05-02 19:46:34 -05:00
Joseph Milazzo e2e755145c Book Feedback (#190)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.

* Delete extra attempts

* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.

* Updated message when duplicate series are found (not sure how this happens)

* Fixed a negation for deleting volumes where files still exist.

* Implemented the ability to automatically scale the manga reader based on screen size.

* Default to automatic scaling

* Fix an issue where malformed epubs wouldn't be readable due to incorrect keys in the OPF. We now check if key is valid and if not, try to correct it. This makes a page load about a second on malformed books.

* Fixed #176. Refactored the recently added query to be restricted to user's access to libraries.

* Fixed a one off bug with In Progress series

* Implemented the ability to refresh metadata of just a single series directly

* Fixed a parser case where Series c000 (v01) would fail to parse the series

* Fixed #189. In Progress now returns data properly for library access and in multiple libraries.

* Fixed #188 by adding an extra message for bad login and updating UI

* Generate a fallback for table of contents by parsing the toc file (if we can find one)
2021-05-02 10:00:47 -05:00
Joseph Milazzo 6d74215262 Feature/feedback (#185)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.

* Delete extra attempts

* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.

* Updated message when duplicate series are found (not sure how this happens)

* Fixed a negation for deleting volumes where files still exist.

* Implemented the ability to automatically scale the manga reader based on screen size.

* Default to automatic scaling

* Fix an issue where malformed epubs wouldn't be readable due to incorrect keys in the OPF. We now check if key is valid and if not, try to correct it. This makes a page load about a second on malformed books.

* Fixed #176. Refactored the recently added query to be restricted to user's access to libraries.

* Fixed a one off bug with In Progress series

* Implemented the ability to refresh metadata of just a single series directly
2021-04-30 17:23:31 -05:00
Joseph Milazzo 35a47f5d88 Book Feedback and small bugs (#183)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.

* Delete extra attempts

* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.

* Updated message when duplicate series are found (not sure how this happens)

* Fixed a negation for deleting volumes where files still exist.

* Implemented the ability to automatically scale the manga reader based on screen size.
2021-04-29 17:52:34 -05:00
Joseph Milazzo a01613f80f EPUB Support (#178)
* Added book filetype detection and reorganized tests due to size of file

* Added ability to get basic Parse Info from Book and Pages.

* We can now scan books and get them in a library with cover images.

* Take the first image in the epub if the cover isn't set.

* Implemented the ability to unzip the ebup to cache. Implemented a test api to load html files.

* Just some test code to figure out how to approach this.

* Fixed some merge conflicts

* Removed some dead code from merge

* Snapshot: I can now load everything properly into the UI by rewriting the urls before I send them back. I don't notice any lag from this method. It can be optimized further.

* Implemented a way to load the content in the browser not via an iframe.

* Added a note

* Anchor mappings is complete. New anchors are updated so references now resolve to javascript:void() for UI to take care of internally loading and the appropriate page is mapped to it. Anchors that are external have target="_blank" added so they don't force you out of the app and styles are of course inlined.

* Oops i need this

* Table of contents api implemented (rough) and some small enhancements to codebase for books.

* GetBookPageResources now only loads files from within the book. Nested chapter list support and images now use html parsing instead of string parsing.

* Fonts now are remapped to load from endpoint.

* book-resources now uses a key, ensuring the file is in proper format for lookup. Changed chapter list based on structure with one HEADER and nested chapters.

* Properly handle svg resource requests and when there are part anchors that are clickable, make sure we handle them in the UI by adding a kavita-page handler.

* Add Chapter group page even if one isn't set by using first page (without part) from nestedChildren.

* Added extra debug code for issue #163.

* Added new user preferences for books and updated the css so we scope it to our reading section.

* Cleaned up style code

* Implemented ability to save book preferences and some cleanup on existing apis.

* Added an api for checking if a user has read something in a library type before.

* Forgot to make sure the has reading progress is against a user lol.

* Remove cacheservice code for books, sine we use an in-memory method

* Handle svg images as well

* Enhanced cover image extraction to check for a "cover" image if the cover image wasn't set in OPF before falling back to the first image.

* Fixed an issue with special books not properly generating metadata due to not having filename set.

* Cleanup, removed warmup task code from statup/program and changed taskscheduler to schedule tasks on startup only (or if tasks are changed from UI).

* Code cleanup

* Code cleanup

* So much code. Lots of refactors to try to test scanner service. Moved a lot of the queries into Extensions to allow to easier test, even though it's hacky. Support @font-face src:url swaps with ' and ". Source summary information from epubs.

* Well...baseURL needs to come from BE and not from UI lol.

* Adjusted migrations so default values match Entity

* Removed comment

* I think I finally fixed #163! The issue was that when i checked if it had a parserInfo, i wasn't considering that the chapter range might have a - in it (0-6) and so when the code to check if range could parse out a number failed, it treated it like a special and checked range against info's filename.

* Some bugfixes

* Lots of testing, extracting code to make it easier to test. This code is buggy, but fixed a bug where 1) If we changed the normalization code, we would remove the whole db during a scan and 2) We weren't actually removing series properly.

Other than that, code is being extracted to remove duplication and centralize logic.

* More code cleanup and test cleanup to ensure scan loop is working as expected and matches expectaions from tests.

* Cleaned up the code and made it so if I change normalization, which I do in this branch, it wont break existing DBs.

* Some comic parser changes for partial chapter support.

* Added some code for directory service and scanner service along with python code to generate test files (not used yet). Fixed up all the tests.

* Code smells
2021-04-28 16:16:22 -05:00
Joseph Milazzo 2b99c8abfa Scan Bugfixes (#177)
* Added way  more logging for debugging issue #163.

Fixed #175

* Removed some comment that isn't needed

* Fixed a enumeration issue due to removing while enumerating
2021-04-16 12:21:16 -05:00
Joseph Milazzo 09a953be8c Feature/bugfix and regex (#174)
* Fixed #172

* Fixes #164

* Added a parse test for [Hidoi]_Amaenaideyo_MS_vol01_chp02.rar

* Fix annoying warning about SplitQuery on GetLibraryDtosForUsernameAsync
2021-04-13 14:30:57 -05:00
Joseph Milazzo d59d60d9ec Feature/unit tests (#171)
* Removed a duplicate loop that was already done earlier in method.

* Normalize now replaces underscores

* Added more Parser cases, Added test case for SeriesExtension (Name in List), and added MergeNameTest and some TODOs for where tests should go

* Added a test for removal

* Fixed bad merge

Co-authored-by: Andrew Song <asong641@gmail.com>
2021-04-13 10:24:44 -05:00
Joseph Milazzo 6ba00477e7 Cover Image - First and tests (#170)
* Changed how natural sort works to cover more cases

* Changed the name of CoverImage regex for Parser and added more cases.

* Changed how we get result from Task.Run()

* Defer execution of a loop till we really need it and added another TODO for later this iteration.

* Big refactor to cover image code to unify between IOCompression and SharpCompress. Both use methods to find the correct file. This results in one extra loop through entries, but simplifies code signficantly.

In addition, new unit tests for the methods that actually do the logic on choosing cover file and first file.

* Removed dead code

* Added missing doc
2021-04-11 18:15:12 -05:00