mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-23 15:30:34 -04:00
* Updated to net7.0 * Updated GA to .net 7 * Updated System.IO.Abstractions to use New factory. * Converted Regex into SourceGenerator in Parser. * Updated more regex to source generators. * Enabled Nullability and more regex changes throughout codebase. * Parser is 100% GeneratedRegexified * Lots of nullability code * Enabled nullability for all repositories. * Fixed another unit test * Refactored some code around and took care of some todos. * Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension * More nullability exercises. 500 warnings to go. * Fixed a bug where custom file uploads for entities wouldn't save in webP. * Nullability is done for all DTOs * Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement. * Use localization in book service after validating * Code smells * Switched to preview build of swashbuckle for .net7 support * Fixed up merge issues * Disable emulate comic book when on single page reader * Fixed a regression where double page renderer wouldn't layout the images correctly * Updated to swashbuckle which support .net 7 * Fixed a bad GA action * Some code cleanup * More code smells * Took care of most of nullable issues * Fixed a broken test due to having more than one test run in parallel * I'm really not sure why the unit tests are failing or are so extremely slow on .net 7 * Updated all dependencies * Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted. * Unit tests and code cleanup. Needs shakeout now. * Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project. * Refactored to use Builder pattern for all unit tests. * Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.
161 lines
4.9 KiB
C#
161 lines
4.9 KiB
C#
using System.Collections.Generic;
|
|
using API.Data;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Helpers;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Helpers;
|
|
|
|
public class PersonHelperTests
|
|
{
|
|
[Fact]
|
|
public void UpdatePeople_ShouldAddNewPeople()
|
|
{
|
|
var allPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer)
|
|
};
|
|
var peopleAdded = new List<Person>();
|
|
|
|
PersonHelper.UpdatePeople(allPeople, new[] {"Joseph Shmo", "Sally Ann"}, PersonRole.Writer, person =>
|
|
{
|
|
peopleAdded.Add(person);
|
|
});
|
|
|
|
Assert.Equal(2, peopleAdded.Count);
|
|
Assert.Equal(4, allPeople.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void UpdatePeople_ShouldNotAddDuplicatePeople()
|
|
{
|
|
var allPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer),
|
|
DbFactory.Person("Sally Ann", PersonRole.CoverArtist),
|
|
|
|
};
|
|
var peopleAdded = new List<Person>();
|
|
|
|
PersonHelper.UpdatePeople(allPeople, new[] {"Joe Shmo", "Sally Ann"}, PersonRole.CoverArtist, person =>
|
|
{
|
|
peopleAdded.Add(person);
|
|
});
|
|
|
|
Assert.Equal(3, allPeople.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void RemovePeople_ShouldRemovePeopleOfSameRole()
|
|
{
|
|
var existingPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer)
|
|
};
|
|
var peopleRemoved = new List<Person>();
|
|
PersonHelper.RemovePeople(existingPeople, new[] {"Joe Shmo", "Sally Ann"}, PersonRole.Writer, person =>
|
|
{
|
|
peopleRemoved.Add(person);
|
|
});
|
|
|
|
Assert.NotEqual(existingPeople, peopleRemoved);
|
|
Assert.Equal(1, peopleRemoved.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void RemovePeople_ShouldRemovePeopleFromBothRoles()
|
|
{
|
|
var existingPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer)
|
|
};
|
|
var peopleRemoved = new List<Person>();
|
|
PersonHelper.RemovePeople(existingPeople, new[] {"Joe Shmo", "Sally Ann"}, PersonRole.Writer, person =>
|
|
{
|
|
peopleRemoved.Add(person);
|
|
});
|
|
|
|
Assert.NotEqual(existingPeople, peopleRemoved);
|
|
Assert.Equal(1, peopleRemoved.Count);
|
|
|
|
PersonHelper.RemovePeople(existingPeople, new[] {"Joe Shmo"}, PersonRole.CoverArtist, person =>
|
|
{
|
|
peopleRemoved.Add(person);
|
|
});
|
|
|
|
Assert.Equal(0, existingPeople.Count);
|
|
Assert.Equal(2, peopleRemoved.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void RemovePeople_ShouldRemovePeopleOfSameRole_WhenNothingPassed()
|
|
{
|
|
var existingPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer),
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist)
|
|
};
|
|
var peopleRemoved = new List<Person>();
|
|
PersonHelper.RemovePeople(existingPeople, new List<string>(), PersonRole.Writer, person =>
|
|
{
|
|
peopleRemoved.Add(person);
|
|
});
|
|
|
|
Assert.NotEqual(existingPeople, peopleRemoved);
|
|
Assert.Equal(2, peopleRemoved.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void KeepOnlySamePeopleBetweenLists()
|
|
{
|
|
var existingPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer),
|
|
DbFactory.Person("Sally", PersonRole.Writer),
|
|
};
|
|
|
|
var peopleFromChapters = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
};
|
|
|
|
var peopleRemoved = new List<Person>();
|
|
PersonHelper.KeepOnlySamePeopleBetweenLists(existingPeople,
|
|
peopleFromChapters, person =>
|
|
{
|
|
peopleRemoved.Add(person);
|
|
});
|
|
|
|
Assert.Equal(2, peopleRemoved.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void AddPeople_ShouldAddOnlyNonExistingPeople()
|
|
{
|
|
var existingPeople = new List<Person>
|
|
{
|
|
DbFactory.Person("Joe Shmo", PersonRole.CoverArtist),
|
|
DbFactory.Person("Joe Shmo", PersonRole.Writer),
|
|
DbFactory.Person("Sally", PersonRole.Writer),
|
|
};
|
|
|
|
|
|
PersonHelper.AddPersonIfNotExists(existingPeople, DbFactory.Person("Joe Shmo", PersonRole.CoverArtist));
|
|
Assert.Equal(3, existingPeople.Count);
|
|
|
|
PersonHelper.AddPersonIfNotExists(existingPeople, DbFactory.Person("Joe Shmo", PersonRole.Writer));
|
|
Assert.Equal(3, existingPeople.Count);
|
|
|
|
PersonHelper.AddPersonIfNotExists(existingPeople, DbFactory.Person("Joe Shmo Two", PersonRole.CoverArtist));
|
|
Assert.Equal(4, existingPeople.Count);
|
|
}
|
|
|
|
}
|