mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-03 05:34:21 -04:00
* Have language from epubs populate metadata * series detail needs to reload the underlying volumes when scan event comes in, not just metadata. * Added Id to chapter detail modal (for debugging) * Implement IDisposable on applicable Unit Tests * Removed unused using statements * Fixed a bug where images would flash like crazy during a scan because the code to refresh the underlying image wasn't checking the entity type or Id. * When filtering rating, only apply the filter to your account. * Removed Disposable on tests
312 lines
11 KiB
C#
312 lines
11 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Data.Common;
|
|
using System.IO.Abstractions.TestingHelpers;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using API.Data;
|
|
using API.Data.Metadata;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Parser;
|
|
using API.Services;
|
|
using API.Services.Tasks.Scanner;
|
|
using API.Tests.Helpers;
|
|
using AutoMapper;
|
|
using Microsoft.Data.Sqlite;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Services;
|
|
|
|
internal class MockReadingItemService : IReadingItemService
|
|
{
|
|
private readonly DefaultParser _defaultParser;
|
|
|
|
public MockReadingItemService(DefaultParser defaultParser)
|
|
{
|
|
_defaultParser = defaultParser;
|
|
}
|
|
|
|
public ComicInfo GetComicInfo(string filePath)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
public int GetNumberOfPages(string filePath, MangaFormat format)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
public string GetCoverImage(string fileFilePath, string fileName, MangaFormat format)
|
|
{
|
|
return string.Empty;
|
|
}
|
|
|
|
public void Extract(string fileFilePath, string targetDirectory, MangaFormat format, int imageCount = 1)
|
|
{
|
|
throw new System.NotImplementedException();
|
|
}
|
|
|
|
public ParserInfo Parse(string path, string rootPath, LibraryType type)
|
|
{
|
|
return _defaultParser.Parse(path, rootPath, type);
|
|
}
|
|
}
|
|
|
|
public class ParseScannedFilesTests
|
|
{
|
|
private readonly ILogger<ParseScannedFiles> _logger = Substitute.For<ILogger<ParseScannedFiles>>();
|
|
private readonly IUnitOfWork _unitOfWork;
|
|
|
|
private readonly DbConnection _connection;
|
|
private readonly DataContext _context;
|
|
|
|
private const string CacheDirectory = "C:/kavita/config/cache/";
|
|
private const string CoverImageDirectory = "C:/kavita/config/covers/";
|
|
private const string BackupDirectory = "C:/kavita/config/backups/";
|
|
private const string DataDirectory = "C:/data/";
|
|
|
|
public ParseScannedFilesTests()
|
|
{
|
|
var contextOptions = new DbContextOptionsBuilder()
|
|
.UseSqlite(CreateInMemoryDatabase())
|
|
.Options;
|
|
_connection = RelationalOptionsExtension.Extract(contextOptions).Connection;
|
|
|
|
_context = new DataContext(contextOptions);
|
|
Task.Run(SeedDb).GetAwaiter().GetResult();
|
|
|
|
_unitOfWork = new UnitOfWork(_context, Substitute.For<IMapper>(), null);
|
|
|
|
// Since ProcessFile relies on _readingItemService, we can implement our own versions of _readingItemService so we have control over how the calls work
|
|
}
|
|
|
|
#region Setup
|
|
|
|
private static DbConnection CreateInMemoryDatabase()
|
|
{
|
|
var connection = new SqliteConnection("Filename=:memory:");
|
|
|
|
connection.Open();
|
|
|
|
return connection;
|
|
}
|
|
|
|
private async Task<bool> SeedDb()
|
|
{
|
|
await _context.Database.MigrateAsync();
|
|
var filesystem = CreateFileSystem();
|
|
|
|
await Seed.SeedSettings(_context, new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), filesystem));
|
|
|
|
var setting = await _context.ServerSetting.Where(s => s.Key == ServerSettingKey.CacheDirectory).SingleAsync();
|
|
setting.Value = CacheDirectory;
|
|
|
|
setting = await _context.ServerSetting.Where(s => s.Key == ServerSettingKey.BackupDirectory).SingleAsync();
|
|
setting.Value = BackupDirectory;
|
|
|
|
_context.ServerSetting.Update(setting);
|
|
|
|
_context.Library.Add(new Library()
|
|
{
|
|
Name = "Manga",
|
|
Folders = new List<FolderPath>()
|
|
{
|
|
new FolderPath()
|
|
{
|
|
Path = DataDirectory
|
|
}
|
|
}
|
|
});
|
|
return await _context.SaveChangesAsync() > 0;
|
|
}
|
|
|
|
private async Task ResetDB()
|
|
{
|
|
_context.Series.RemoveRange(_context.Series.ToList());
|
|
|
|
await _context.SaveChangesAsync();
|
|
}
|
|
|
|
private static MockFileSystem CreateFileSystem()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
fileSystem.Directory.SetCurrentDirectory("C:/kavita/");
|
|
fileSystem.AddDirectory("C:/kavita/config/");
|
|
fileSystem.AddDirectory(CacheDirectory);
|
|
fileSystem.AddDirectory(CoverImageDirectory);
|
|
fileSystem.AddDirectory(BackupDirectory);
|
|
fileSystem.AddDirectory(DataDirectory);
|
|
|
|
return fileSystem;
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region GetInfosByName
|
|
|
|
[Fact]
|
|
public void GetInfosByName_ShouldReturnGivenMatchingSeriesName()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), fileSystem);
|
|
var psf = new ParseScannedFiles(Substitute.For<ILogger<ParseScannedFiles>>(), ds,
|
|
new MockReadingItemService(new DefaultParser(ds)));
|
|
|
|
var infos = new List<ParserInfo>()
|
|
{
|
|
ParserInfoFactory.CreateParsedInfo("Accel World", "1", "0", "Accel World v1.cbz", false),
|
|
ParserInfoFactory.CreateParsedInfo("Accel World", "2", "0", "Accel World v2.cbz", false)
|
|
};
|
|
var parsedSeries = new Dictionary<ParsedSeries, List<ParserInfo>>
|
|
{
|
|
{
|
|
new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Accel World",
|
|
NormalizedName = API.Parser.Parser.Normalize("Accel World")
|
|
},
|
|
infos
|
|
},
|
|
{
|
|
new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Pdf,
|
|
Name = "Accel World",
|
|
NormalizedName = API.Parser.Parser.Normalize("Accel World")
|
|
},
|
|
new List<ParserInfo>()
|
|
}
|
|
};
|
|
|
|
var series = DbFactory.Series("Accel World");
|
|
series.Format = MangaFormat.Pdf;
|
|
|
|
Assert.Empty(ParseScannedFiles.GetInfosByName(parsedSeries, series));
|
|
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.Equal(2, ParseScannedFiles.GetInfosByName(parsedSeries, series).Count());
|
|
|
|
}
|
|
|
|
[Fact]
|
|
public void GetInfosByName_ShouldReturnGivenMatchingNormalizedSeriesName()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), fileSystem);
|
|
var psf = new ParseScannedFiles(Substitute.For<ILogger<ParseScannedFiles>>(), ds,
|
|
new MockReadingItemService(new DefaultParser(ds)));
|
|
|
|
var infos = new List<ParserInfo>()
|
|
{
|
|
ParserInfoFactory.CreateParsedInfo("Accel World", "1", "0", "Accel World v1.cbz", false),
|
|
ParserInfoFactory.CreateParsedInfo("Accel World", "2", "0", "Accel World v2.cbz", false)
|
|
};
|
|
var parsedSeries = new Dictionary<ParsedSeries, List<ParserInfo>>
|
|
{
|
|
{
|
|
new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Accel World",
|
|
NormalizedName = API.Parser.Parser.Normalize("Accel World")
|
|
},
|
|
infos
|
|
},
|
|
{
|
|
new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Pdf,
|
|
Name = "Accel World",
|
|
NormalizedName = API.Parser.Parser.Normalize("Accel World")
|
|
},
|
|
new List<ParserInfo>()
|
|
}
|
|
};
|
|
|
|
var series = DbFactory.Series("accel world");
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.Equal(2, ParseScannedFiles.GetInfosByName(parsedSeries, series).Count());
|
|
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region MergeName
|
|
|
|
[Fact]
|
|
public void MergeName_ShouldMergeMatchingFormatAndName()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
fileSystem.AddDirectory("C:/Data/");
|
|
fileSystem.AddFile("C:/Data/Accel World v1.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.pdf", new MockFileData(string.Empty));
|
|
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), fileSystem);
|
|
var psf = new ParseScannedFiles(Substitute.For<ILogger<ParseScannedFiles>>(), ds,
|
|
new MockReadingItemService(new DefaultParser(ds)));
|
|
|
|
|
|
psf.ScanLibrariesForSeries(LibraryType.Manga, new List<string>() {"C:/Data/"}, out _, out _);
|
|
|
|
Assert.Equal("Accel World", psf.MergeName(ParserInfoFactory.CreateParsedInfo("Accel World", "1", "0", "Accel World v1.cbz", false)));
|
|
Assert.Equal("Accel World", psf.MergeName(ParserInfoFactory.CreateParsedInfo("accel_world", "1", "0", "Accel World v1.cbz", false)));
|
|
Assert.Equal("Accel World", psf.MergeName(ParserInfoFactory.CreateParsedInfo("accelworld", "1", "0", "Accel World v1.cbz", false)));
|
|
}
|
|
|
|
[Fact]
|
|
public void MergeName_ShouldMerge_MismatchedFormatSameName()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
fileSystem.AddDirectory("C:/Data/");
|
|
fileSystem.AddFile("C:/Data/Accel World v1.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.pdf", new MockFileData(string.Empty));
|
|
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), fileSystem);
|
|
var psf = new ParseScannedFiles(Substitute.For<ILogger<ParseScannedFiles>>(), ds,
|
|
new MockReadingItemService(new DefaultParser(ds)));
|
|
|
|
|
|
psf.ScanLibrariesForSeries(LibraryType.Manga, new List<string>() {"C:/Data/"}, out _, out _);
|
|
|
|
Assert.Equal("Accel World", psf.MergeName(ParserInfoFactory.CreateParsedInfo("Accel World", "1", "0", "Accel World v1.epub", false)));
|
|
Assert.Equal("Accel World", psf.MergeName(ParserInfoFactory.CreateParsedInfo("accel_world", "1", "0", "Accel World v1.epub", false)));
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region ScanLibrariesForSeries
|
|
|
|
[Fact]
|
|
public void ScanLibrariesForSeries_ShouldFindFiles()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
fileSystem.AddDirectory("C:/Data/");
|
|
fileSystem.AddFile("C:/Data/Accel World v1.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.cbz", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Accel World v2.pdf", new MockFileData(string.Empty));
|
|
fileSystem.AddFile("C:/Data/Nothing.pdf", new MockFileData(string.Empty));
|
|
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), fileSystem);
|
|
var psf = new ParseScannedFiles(Substitute.For<ILogger<ParseScannedFiles>>(), ds,
|
|
new MockReadingItemService(new DefaultParser(ds)));
|
|
|
|
|
|
var parsedSeries = psf.ScanLibrariesForSeries(LibraryType.Manga, new List<string>() {"C:/Data/"}, out _, out _);
|
|
|
|
Assert.Equal(3, parsedSeries.Values.Count);
|
|
Assert.NotEmpty(parsedSeries.Keys.Where(p => p.Format == MangaFormat.Archive && p.Name.Equals("Accel World")));
|
|
|
|
}
|
|
|
|
|
|
#endregion
|
|
}
|