mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-20 22:10:33 -04:00
* Updated number inputs with a more mobile friendly control * Started writing lots of unit tests on PersonHelper to try and hammer out foreign constraint * Fixes side-nav actionable alignment * Added some unit tests * Buffed out the unit tests * Applied input modes throughout the app * Fixed a small bug in refresh token validation to make it work correctly * Try out a new way to block multithreading from interacting with people during series metadata update. * Fixed the lock code to properly lock, which should help with any constraint issues. * Locking notes * Tweaked locking on people to prevent a constraint issue. This slows down the scanner a bit, but not much. Will tweak after validating on a user's server. * Replaced all DBFactory.Series with SeriesBuilder. * Replaced all DBFactory.Volume() with VolumeBuilder * Replaced SeriesMetadata with Builder * Replaced DBFactory.CollectionTag * Lots of refactoring to streamline entity creation * Fixed one of the unit tests * Refactored all of new Library() * Removed tag and genre * Removed new SeriesMetadata * Refactored new Volume() * MangaFile() * ReadingList() * Refactored all of Chapter and ReadingList * Add title to all event widget flows * Updated Base Url to inform user it doesn't work for docker users with non-root user. * Added unit test coverage to FormatChapterTitle and FormatChapterName. * Started on Unit test for scanner, but need to finish it later. --------- Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>
272 lines
10 KiB
C#
272 lines
10 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.IO.Abstractions.TestingHelpers;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Helpers;
|
|
using API.Helpers.Builders;
|
|
using API.Services;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Helpers;
|
|
|
|
public class CacheHelperTests
|
|
{
|
|
private const string TestCoverImageDirectory = @"c:\";
|
|
private const string TestCoverImageFile = "thumbnail.jpg";
|
|
private readonly string _testCoverPath = Path.Join(TestCoverImageDirectory, TestCoverImageFile);
|
|
private const string TestCoverArchive = @"file in folder.zip";
|
|
private readonly ICacheHelper _cacheHelper;
|
|
|
|
public CacheHelperTests()
|
|
{
|
|
var file = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now.Subtract(TimeSpan.FromMinutes(1))
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), file },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), file }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
_cacheHelper = new CacheHelper(fileService);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("", false)]
|
|
[InlineData("C:/", false)]
|
|
[InlineData(null, false)]
|
|
public void CoverImageExists_DoesFileExist(string coverImage, bool exists)
|
|
{
|
|
Assert.Equal(exists, _cacheHelper.CoverImageExists(coverImage));
|
|
}
|
|
|
|
[Fact]
|
|
public void CoverImageExists_FileExists()
|
|
{
|
|
Assert.True(_cacheHelper.CoverImageExists(TestCoverArchive));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_OnFirstRun()
|
|
{
|
|
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now)
|
|
.Build();
|
|
Assert.True(_cacheHelper.ShouldUpdateCoverImage(null, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetNotLocked()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now)
|
|
.Build();
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetNotLocked_2()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now)
|
|
.Build();
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now,
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetLocked()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now)
|
|
.Build();
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, true));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetLocked_Modified()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now)
|
|
.Build();
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, true));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_CoverImageSetAndReplaced_Modified()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var created = DateTime.Now.Subtract(TimeSpan.FromHours(1));
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(DateTime.Now.Subtract(TimeSpan.FromMinutes(1)))
|
|
.Build();
|
|
|
|
Assert.True(cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, created,
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceCreated()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new ChapterBuilder("1")
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.WithCreated(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
Assert.True(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceLastModified()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new ChapterBuilder("1")
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.WithCreated(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
|
|
Assert.True(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceLastModified_ForceUpdate()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new ChapterBuilder("1")
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.WithCreated(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, true, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void IsFileUnmodifiedSinceCreationOrLastScan_ModifiedSinceLastScan()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now,
|
|
CreationTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new ChapterBuilder("1")
|
|
.WithLastModified(DateTime.Now.Subtract(TimeSpan.FromMinutes(10)))
|
|
.WithCreated(DateTime.Now.Subtract(TimeSpan.FromMinutes(10)))
|
|
.Build();
|
|
|
|
var file = new MangaFileBuilder(TestCoverArchive, MangaFormat.Archive)
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_ModifiedSinceLastScan_ButLastModifiedSame()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new ChapterBuilder("1")
|
|
.WithLastModified(DateTime.Now)
|
|
.WithCreated(DateTime.Now.Subtract(TimeSpan.FromMinutes(10)))
|
|
.Build();
|
|
|
|
var file = new MangaFileBuilder(Path.Join(TestCoverImageDirectory, TestCoverArchive), MangaFormat.Archive)
|
|
.WithLastModified(filesystemFile.LastWriteTime.DateTime)
|
|
.Build();
|
|
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
}
|