mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-19 13:34:15 -04:00
* Added a lot of tests * More tests! Added a Parser.NormalizePath to normalize all paths within Kavita. * Fixed a bug where MarkChaptersAsUnread implementation wasn't consistent between different files and lead to extra row generation for no reason. * Added more unit tests * Found a better implementation for Natural Sorting. Added tests and validate it works. Next commit will swap out natural Sort for new Extension. * Replaced NaturalSortComparer with OrderByNatural. * Drastically simplified and sped up FindFirstEntry for finding cover images in archives * Initial fix for a epub bug where metadata defines key as absolute path but document uses a relative path. We now have a hack to correct for the epub.
94 lines
5.1 KiB
C#
94 lines
5.1 KiB
C#
using System.Linq;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Entities.Metadata;
|
|
using API.Extensions;
|
|
using API.Parser;
|
|
using API.Services.Tasks.Scanner;
|
|
using API.Tests.Helpers;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Extensions
|
|
{
|
|
public class SeriesExtensionsTests
|
|
{
|
|
[Theory]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker than Black"}, true)]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker_than_Black"}, true)]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker then Black!"}, false)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"Salem's Lot"}, true)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"salems lot"}, true)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"salem's lot"}, true)]
|
|
// Different normalizations pass as we check normalization against an on-the-fly calculation so we don't delete series just because we change how normalization works
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot", "salems lot"}, new [] {"salem's lot"}, true)]
|
|
[InlineData(new [] {"Rent-a-Girlfriend", "Rent-a-Girlfriend", "Kanojo, Okarishimasu", "rentagirlfriend"}, new [] {"Kanojo, Okarishimasu"}, true)]
|
|
public void NameInListTest(string[] seriesInput, string[] list, bool expected)
|
|
{
|
|
var series = new Series()
|
|
{
|
|
Name = seriesInput[0],
|
|
LocalizedName = seriesInput[1],
|
|
OriginalName = seriesInput[2],
|
|
NormalizedName = seriesInput.Length == 4 ? seriesInput[3] : API.Parser.Parser.Normalize(seriesInput[0]),
|
|
Metadata = new SeriesMetadata()
|
|
};
|
|
|
|
Assert.Equal(expected, series.NameInList(list));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker than Black"}, MangaFormat.Archive, true)]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker_than_Black"}, MangaFormat.Archive, true)]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, new [] {"Darker then Black!"}, MangaFormat.Archive, false)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"Salem's Lot"}, MangaFormat.Archive, true)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"salems lot"}, MangaFormat.Archive, true)]
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot"}, new [] {"salem's lot"}, MangaFormat.Archive, true)]
|
|
// Different normalizations pass as we check normalization against an on-the-fly calculation so we don't delete series just because we change how normalization works
|
|
[InlineData(new [] {"Salem's Lot", "Salem's Lot", "Salem's Lot", "salems lot"}, new [] {"salem's lot"}, MangaFormat.Archive, true)]
|
|
[InlineData(new [] {"Rent-a-Girlfriend", "Rent-a-Girlfriend", "Kanojo, Okarishimasu", "rentagirlfriend"}, new [] {"Kanojo, Okarishimasu"}, MangaFormat.Archive, true)]
|
|
public void NameInListParserInfoTest(string[] seriesInput, string[] list, MangaFormat format, bool expected)
|
|
{
|
|
var series = new Series()
|
|
{
|
|
Name = seriesInput[0],
|
|
LocalizedName = seriesInput[1],
|
|
OriginalName = seriesInput[2],
|
|
NormalizedName = seriesInput.Length == 4 ? seriesInput[3] : API.Parser.Parser.Normalize(seriesInput[0]),
|
|
Metadata = new SeriesMetadata(),
|
|
};
|
|
|
|
var parserInfos = list.Select(s => new ParsedSeries()
|
|
{
|
|
Name = s,
|
|
NormalizedName = API.Parser.Parser.Normalize(s),
|
|
}).ToList();
|
|
|
|
// This doesn't do any checks against format
|
|
Assert.Equal(expected, series.NameInList(parserInfos));
|
|
}
|
|
|
|
|
|
[Theory]
|
|
[InlineData(new [] {"Darker than Black", "Darker Than Black", "Darker than Black"}, "Darker than Black", true)]
|
|
[InlineData(new [] {"Rent-a-Girlfriend", "Rent-a-Girlfriend", "Kanojo, Okarishimasu", "rentagirlfriend"}, "Kanojo, Okarishimasu", true)]
|
|
[InlineData(new [] {"Rent-a-Girlfriend", "Rent-a-Girlfriend", "Kanojo, Okarishimasu", "rentagirlfriend"}, "Rent", false)]
|
|
public void NameInParserInfoTest(string[] seriesInput, string parserSeries, bool expected)
|
|
{
|
|
var series = new Series()
|
|
{
|
|
Name = seriesInput[0],
|
|
LocalizedName = seriesInput[1],
|
|
OriginalName = seriesInput[2],
|
|
NormalizedName = seriesInput.Length == 4 ? seriesInput[3] : API.Parser.Parser.Normalize(seriesInput[0]),
|
|
Metadata = new SeriesMetadata()
|
|
};
|
|
var info = new ParserInfo();
|
|
info.Series = parserSeries;
|
|
|
|
Assert.Equal(expected, series.NameInParserInfo(info));
|
|
}
|
|
|
|
|
|
}
|
|
}
|