mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-05-31 12:14:44 -04:00
* Updated to net7.0 * Updated GA to .net 7 * Updated System.IO.Abstractions to use New factory. * Converted Regex into SourceGenerator in Parser. * Updated more regex to source generators. * Enabled Nullability and more regex changes throughout codebase. * Parser is 100% GeneratedRegexified * Lots of nullability code * Enabled nullability for all repositories. * Fixed another unit test * Refactored some code around and took care of some todos. * Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension * More nullability exercises. 500 warnings to go. * Fixed a bug where custom file uploads for entities wouldn't save in webP. * Nullability is done for all DTOs * Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement. * Use localization in book service after validating * Code smells * Switched to preview build of swashbuckle for .net7 support * Fixed up merge issues * Disable emulate comic book when on single page reader * Fixed a regression where double page renderer wouldn't layout the images correctly * Updated to swashbuckle which support .net 7 * Fixed a bad GA action * Some code cleanup * More code smells * Took care of most of nullable issues * Fixed a broken test due to having more than one test run in parallel * I'm really not sure why the unit tests are failing or are so extremely slow on .net 7 * Updated all dependencies * Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted. * Unit tests and code cleanup. Needs shakeout now. * Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project. * Refactored to use Builder pattern for all unit tests. * Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.
303 lines
10 KiB
C#
303 lines
10 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.IO.Abstractions.TestingHelpers;
|
|
using API.Entities;
|
|
using API.Helpers;
|
|
using API.Services;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Helpers;
|
|
|
|
public class CacheHelperTests
|
|
{
|
|
private const string TestCoverImageDirectory = @"c:\";
|
|
private const string TestCoverImageFile = "thumbnail.jpg";
|
|
private readonly string _testCoverPath = Path.Join(TestCoverImageDirectory, TestCoverImageFile);
|
|
private const string TestCoverArchive = @"file in folder.zip";
|
|
private readonly ICacheHelper _cacheHelper;
|
|
|
|
public CacheHelperTests()
|
|
{
|
|
var file = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now.Subtract(TimeSpan.FromMinutes(1))
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), file },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), file }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
_cacheHelper = new CacheHelper(fileService);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("", false)]
|
|
[InlineData("C:/", false)]
|
|
[InlineData(null, false)]
|
|
public void CoverImageExists_DoesFileExist(string coverImage, bool exists)
|
|
{
|
|
Assert.Equal(exists, _cacheHelper.CoverImageExists(coverImage));
|
|
}
|
|
|
|
[Fact]
|
|
public void CoverImageExists_FileExists()
|
|
{
|
|
Assert.True(_cacheHelper.CoverImageExists(TestCoverArchive));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_OnFirstRun()
|
|
{
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now
|
|
};
|
|
Assert.True(_cacheHelper.ShouldUpdateCoverImage(null, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetNotLocked()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now
|
|
};
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetNotLocked_2()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now
|
|
};
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now,
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetLocked()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now
|
|
};
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, true));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_ShouldNotUpdateOnSecondRunWithCoverImageSetLocked_Modified()
|
|
{
|
|
// Represents first run
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now
|
|
};
|
|
Assert.False(_cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, DateTime.Now.Subtract(TimeSpan.FromMinutes(1)),
|
|
false, true));
|
|
}
|
|
|
|
[Fact]
|
|
public void ShouldUpdateCoverImage_CoverImageSetAndReplaced_Modified()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var created = DateTime.Now.Subtract(TimeSpan.FromHours(1));
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = DateTime.Now.Subtract(TimeSpan.FromMinutes(1))
|
|
};
|
|
Assert.True(cacheHelper.ShouldUpdateCoverImage(_testCoverPath, file, created,
|
|
false, false));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceCreated()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new Chapter()
|
|
{
|
|
Number = "1",
|
|
Range = "1",
|
|
Created = filesystemFile.LastWriteTime.DateTime,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
Assert.True(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceLastModified()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new Chapter()
|
|
{
|
|
Number = "1",
|
|
Range = "1",
|
|
Created = filesystemFile.LastWriteTime.DateTime,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
Assert.True(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_NotChangedSinceLastModified_ForceUpdate()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new Chapter()
|
|
{
|
|
Number = "1",
|
|
Range = "1",
|
|
Created = filesystemFile.LastWriteTime.DateTime,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = TestCoverArchive,
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, true, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void IsFileUnmodifiedSinceCreationOrLastScan_ModifiedSinceLastScan()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now,
|
|
CreationTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new Chapter()
|
|
{
|
|
Number = "1",
|
|
Range = "1",
|
|
Created = DateTime.Now.Subtract(TimeSpan.FromMinutes(10)),
|
|
LastModified = DateTime.Now.Subtract(TimeSpan.FromMinutes(10))
|
|
};
|
|
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = Path.Join(TestCoverImageDirectory, TestCoverArchive),
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
[Fact]
|
|
public void HasFileNotChangedSinceCreationOrLastScan_ModifiedSinceLastScan_ButLastModifiedSame()
|
|
{
|
|
var filesystemFile = new MockFileData("")
|
|
{
|
|
LastWriteTime = DateTimeOffset.Now
|
|
};
|
|
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
|
|
{
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverArchive), filesystemFile },
|
|
{ Path.Join(TestCoverImageDirectory, TestCoverImageFile), filesystemFile }
|
|
});
|
|
|
|
var fileService = new FileService(fileSystem);
|
|
var cacheHelper = new CacheHelper(fileService);
|
|
|
|
var chapter = new Chapter()
|
|
{
|
|
Number = "1",
|
|
Range = "1",
|
|
Created = DateTime.Now.Subtract(TimeSpan.FromMinutes(10)),
|
|
LastModified = DateTime.Now
|
|
};
|
|
|
|
var file = new MangaFile()
|
|
{
|
|
FilePath = Path.Join(TestCoverImageDirectory, TestCoverArchive),
|
|
LastModified = filesystemFile.LastWriteTime.DateTime
|
|
};
|
|
Assert.False(cacheHelper.IsFileUnmodifiedSinceCreationOrLastScan(chapter, false, file));
|
|
}
|
|
|
|
}
|