mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-03 21:54:47 -04:00
* Updated to net7.0 * Updated GA to .net 7 * Updated System.IO.Abstractions to use New factory. * Converted Regex into SourceGenerator in Parser. * Updated more regex to source generators. * Enabled Nullability and more regex changes throughout codebase. * Parser is 100% GeneratedRegexified * Lots of nullability code * Enabled nullability for all repositories. * Fixed another unit test * Refactored some code around and took care of some todos. * Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension * More nullability exercises. 500 warnings to go. * Fixed a bug where custom file uploads for entities wouldn't save in webP. * Nullability is done for all DTOs * Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement. * Use localization in book service after validating * Code smells * Switched to preview build of swashbuckle for .net7 support * Fixed up merge issues * Disable emulate comic book when on single page reader * Fixed a regression where double page renderer wouldn't layout the images correctly * Updated to swashbuckle which support .net 7 * Fixed a bad GA action * Some code cleanup * More code smells * Took care of most of nullable issues * Fixed a broken test due to having more than one test run in parallel * I'm really not sure why the unit tests are failing or are so extremely slow on .net 7 * Updated all dependencies * Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted. * Unit tests and code cleanup. Needs shakeout now. * Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project. * Refactored to use Builder pattern for all unit tests. * Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.
198 lines
7.1 KiB
C#
198 lines
7.1 KiB
C#
using System.Collections.Generic;
|
|
using System.Data.Common;
|
|
using System.IO.Abstractions.TestingHelpers;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using API.Data;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Services;
|
|
using API.Services.Tasks;
|
|
using API.SignalR;
|
|
using AutoMapper;
|
|
using Microsoft.Data.Sqlite;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
|
using Microsoft.Extensions.Configuration;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Services;
|
|
|
|
public class BackupServiceTests
|
|
{
|
|
private readonly ILogger<BackupService> _logger = Substitute.For<ILogger<BackupService>>();
|
|
private readonly IUnitOfWork _unitOfWork;
|
|
private readonly IEventHub _messageHub = Substitute.For<IEventHub>();
|
|
private readonly IConfiguration _config;
|
|
|
|
private readonly DbConnection _connection;
|
|
private readonly DataContext _context;
|
|
|
|
private const string CacheDirectory = "C:/kavita/config/cache/";
|
|
private const string CoverImageDirectory = "C:/kavita/config/covers/";
|
|
private const string BackupDirectory = "C:/kavita/config/backups/";
|
|
private const string LogDirectory = "C:/kavita/config/logs/";
|
|
private const string ConfigDirectory = "C:/kavita/config/";
|
|
private const string BookmarkDirectory = "C:/kavita/config/bookmarks";
|
|
private const string ThemesDirectory = "C:/kavita/config/theme";
|
|
|
|
public BackupServiceTests()
|
|
{
|
|
var contextOptions = new DbContextOptionsBuilder()
|
|
.UseSqlite(CreateInMemoryDatabase())
|
|
.Options;
|
|
_connection = RelationalOptionsExtension.Extract(contextOptions).Connection;
|
|
|
|
_context = new DataContext(contextOptions);
|
|
Task.Run(SeedDb).GetAwaiter().GetResult();
|
|
|
|
_unitOfWork = new UnitOfWork(_context, Substitute.For<IMapper>(), null);
|
|
_config = Substitute.For<IConfiguration>();
|
|
|
|
}
|
|
|
|
#region Setup
|
|
|
|
private static DbConnection CreateInMemoryDatabase()
|
|
{
|
|
var connection = new SqliteConnection("Filename=:memory:");
|
|
|
|
connection.Open();
|
|
|
|
return connection;
|
|
}
|
|
|
|
public void Dispose() => _connection.Dispose();
|
|
|
|
private async Task<bool> SeedDb()
|
|
{
|
|
await _context.Database.MigrateAsync();
|
|
var filesystem = CreateFileSystem();
|
|
|
|
await Seed.SeedSettings(_context, new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), filesystem));
|
|
|
|
var setting = await _context.ServerSetting.Where(s => s.Key == ServerSettingKey.CacheDirectory).SingleAsync();
|
|
setting.Value = CacheDirectory;
|
|
|
|
setting = await _context.ServerSetting.Where(s => s.Key == ServerSettingKey.BackupDirectory).SingleAsync();
|
|
setting.Value = BackupDirectory;
|
|
|
|
_context.ServerSetting.Update(setting);
|
|
|
|
_context.Library.Add(new Library()
|
|
{
|
|
Name = "Manga",
|
|
Folders = new List<FolderPath>()
|
|
{
|
|
new FolderPath()
|
|
{
|
|
Path = "C:/data/"
|
|
}
|
|
}
|
|
});
|
|
return await _context.SaveChangesAsync() > 0;
|
|
}
|
|
|
|
private async Task ResetDB()
|
|
{
|
|
_context.Series.RemoveRange(_context.Series.ToList());
|
|
|
|
await _context.SaveChangesAsync();
|
|
}
|
|
|
|
private static MockFileSystem CreateFileSystem()
|
|
{
|
|
var fileSystem = new MockFileSystem();
|
|
fileSystem.Directory.SetCurrentDirectory("C:/kavita/");
|
|
fileSystem.AddDirectory("C:/kavita/config/");
|
|
fileSystem.AddDirectory(CacheDirectory);
|
|
fileSystem.AddDirectory(CoverImageDirectory);
|
|
fileSystem.AddDirectory(BackupDirectory);
|
|
fileSystem.AddDirectory(LogDirectory);
|
|
fileSystem.AddDirectory(ThemesDirectory);
|
|
fileSystem.AddDirectory(BookmarkDirectory);
|
|
fileSystem.AddDirectory("C:/data/");
|
|
|
|
return fileSystem;
|
|
}
|
|
|
|
#endregion
|
|
|
|
|
|
|
|
#region GetLogFiles
|
|
|
|
[Fact]
|
|
public void GetLogFiles_ExpectAllFiles_NoRollingFiles()
|
|
{
|
|
var filesystem = CreateFileSystem();
|
|
filesystem.AddFile($"{LogDirectory}kavita.log", new MockFileData(""));
|
|
filesystem.AddFile($"{LogDirectory}kavita1.log", new MockFileData(""));
|
|
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), filesystem);
|
|
var backupService = new BackupService(_logger, _unitOfWork, ds, _messageHub);
|
|
|
|
var backupLogFiles = backupService.GetLogFiles(false).ToList();
|
|
Assert.Single(backupLogFiles);
|
|
Assert.Equal(API.Services.Tasks.Scanner.Parser.Parser.NormalizePath($"{LogDirectory}kavita.log"), API.Services.Tasks.Scanner.Parser.Parser.NormalizePath(backupLogFiles.First()));
|
|
}
|
|
|
|
[Fact]
|
|
public void GetLogFiles_ExpectAllFiles_WithRollingFiles()
|
|
{
|
|
var filesystem = CreateFileSystem();
|
|
filesystem.AddFile($"{LogDirectory}kavita.log", new MockFileData(""));
|
|
filesystem.AddFile($"{LogDirectory}kavita20200213.log", new MockFileData(""));
|
|
|
|
var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), filesystem);
|
|
var backupService = new BackupService(_logger, _unitOfWork, ds, _messageHub);
|
|
|
|
var backupLogFiles = backupService.GetLogFiles().Select(API.Services.Tasks.Scanner.Parser.Parser.NormalizePath).ToList();
|
|
Assert.NotEmpty(backupLogFiles.Where(file => file.Equals(API.Services.Tasks.Scanner.Parser.Parser.NormalizePath($"{LogDirectory}kavita.log")) || file.Equals(API.Services.Tasks.Scanner.Parser.Parser.NormalizePath($"{LogDirectory}kavita1.log"))));
|
|
}
|
|
|
|
|
|
#endregion
|
|
|
|
#region BackupFiles
|
|
|
|
// I don't think I can unit test this due to ZipFile.Create
|
|
// [Fact]
|
|
// public async Task BackupDatabase_ExpectAllFiles()
|
|
// {
|
|
// var filesystem = CreateFileSystem();
|
|
// filesystem.AddFile($"{LogDirectory}kavita.log", new MockFileData(""));
|
|
// filesystem.AddFile($"{ConfigDirectory}kavita.db", new MockFileData(""));
|
|
// filesystem.AddFile($"{CoverImageDirectory}1.png", new MockFileData(""));
|
|
// filesystem.AddFile($"{BookmarkDirectory}1.png", new MockFileData(""));
|
|
// filesystem.AddFile($"{ConfigDirectory}appsettings.json", new MockFileData(""));
|
|
// filesystem.AddFile($"{ThemesDirectory}joe.css", new MockFileData(""));
|
|
//
|
|
//
|
|
// var ds = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), filesystem);
|
|
// var inMemorySettings = new Dictionary<string, string> {
|
|
// {"Logging:File:Path", $"{LogDirectory}kavita.log"},
|
|
// {"Logging:File:MaxRollingFiles", "0"},
|
|
// };
|
|
// IConfiguration configuration = new ConfigurationBuilder()
|
|
// .AddInMemoryCollection(inMemorySettings)
|
|
// .Build();
|
|
//
|
|
// var backupService = new BackupService(_logger, _unitOfWork, ds, configuration, _messageHub);
|
|
//
|
|
// await backupService.BackupDatabase();
|
|
//
|
|
//
|
|
// var files = ds.GetFiles(BackupDirectory).ToList();
|
|
// Assert.NotEmpty(files);
|
|
// var zipFile = files.FirstOrDefault();
|
|
// Assert.NotNull(zipFile);
|
|
// using var zipArchive = ZipFile.OpenRead(zipFile);
|
|
//
|
|
// }
|
|
|
|
#endregion
|
|
}
|