mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-23 15:30:34 -04:00
* Took care of some notes in the code * Fixed an issue where Extra might get flagged as special too early, if in a word like Extraordinary * Moved Tag cleanup code into Scanner service. Added a SplitQuery to another heavy API. Refactored Scan loop to remove parallelism and use async instead. * Lots of rework on the codebase to support detailed messages and easier management of message sending. Need to take a break on this work. * Progress is being made, but slowly. Code is broken in this commit. * Progress is being made, but slowly. Code is broken in this commit. * Fixed merge issue * Fixed unit tests * CoverUpdate is now hooked into new ProgressEvent structure * Refactored code to remove custom observables and have everything use standard messages$ * Refactored a ton of instances to NotificationProgressEvent style and tons of the UI to respect that too. UI is still a bit buggy, but wholistically the work is done. * Working much better. Sometimes events come in too fast. Currently cover update progress doesn't display on UI * Fixed unit tests * Removed SignalREvent to minimize internal event types. Updated the UI to use progress bars. Finished SiteThemeService. * Merged metadata refresh progress events and changed library scan events to merge cleaner in the UI * Changed RefreshMetadataProgress to CoverUpdateProgress to reflect the event better. * Theme Cleanup (#1089) * Fixed e-ink theme not properly applying correctly * Fixed some seed changes. Changed card checkboxes to use our themed ones * Fixed recently added carousel not going to recently-added page * Fixed an issue where no results found would show when searching for a library name * Cleaned up list a bit, typeahead dropdown still needs work * Added a TODO to streamline series-card component * Removed ng-lazyload-image module since we don't use it. We use lazysizes * Darken card on hover * Fixing accordion focus style * ux pass updates - Fixed typeahead width - Fixed changelog download buttons - Fixed a select - Fixed various input box-shadows - Fixed all anchors to only have underline on hover - Added navtab hover and active effects * more ux pass - Fixed spacing on theme cards - Fixed some light theme issues - Exposed text-muted-color for theme card subtitle color * UX pass fixes - Changed back to bright green for primary on dark theme - Changed fa icon to black on e-ink * Merged changelog component * Fixed anchor buttons text decoration * Changed nav tabs to have a background color instead of open active state * When user is not authenticated, make sure we set default theme (dark) * Cleanup on carousel * Updated Users tab to use small buttons with icons to align with Library tab * Cleaned up brand to not underline, removed default link underline on hover in dropdown and pill tabs * Fixed collection detail posters not rendering Co-authored-by: Robbie Davis <robbie@therobbiedavis.com> * Bump versions by dotnet-bump-version. * Tweaked some of the emitting code * Some css, but pretty bad. Robbie please save me * Removed a todo * styling update * Only send filename on FileScanProgress * Some console.log spam cleanup * Various updates * Show events widget activity based on activeEvents * progress bar color updates * Code cleanup Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>
204 lines
9.4 KiB
C#
204 lines
9.4 KiB
C#
using System;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using API.Data;
|
|
using API.Entities.Enums;
|
|
using API.SignalR;
|
|
using Hangfire;
|
|
using Microsoft.AspNetCore.SignalR;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace API.Services.Tasks
|
|
{
|
|
public interface ICleanupService
|
|
{
|
|
Task Cleanup();
|
|
Task CleanupDbEntries();
|
|
void CleanupCacheDirectory();
|
|
Task DeleteSeriesCoverImages();
|
|
Task DeleteChapterCoverImages();
|
|
Task DeleteTagCoverImages();
|
|
Task CleanupBackups();
|
|
Task CleanupBookmarks();
|
|
}
|
|
/// <summary>
|
|
/// Cleans up after operations on reoccurring basis
|
|
/// </summary>
|
|
public class CleanupService : ICleanupService
|
|
{
|
|
private readonly ILogger<CleanupService> _logger;
|
|
private readonly IUnitOfWork _unitOfWork;
|
|
private readonly IEventHub _eventHub;
|
|
private readonly IDirectoryService _directoryService;
|
|
|
|
public CleanupService(ILogger<CleanupService> logger,
|
|
IUnitOfWork unitOfWork, IEventHub eventHub,
|
|
IDirectoryService directoryService)
|
|
{
|
|
_logger = logger;
|
|
_unitOfWork = unitOfWork;
|
|
_eventHub = eventHub;
|
|
_directoryService = directoryService;
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Cleans up Temp, cache, deleted cover images, and old database backups
|
|
/// </summary>
|
|
[AutomaticRetry(Attempts = 3, LogEvents = false, OnAttemptsExceeded = AttemptsExceededAction.Fail)]
|
|
public async Task Cleanup()
|
|
{
|
|
_logger.LogInformation("Starting Cleanup");
|
|
await SendProgress(0F, "Starting cleanup");
|
|
_logger.LogInformation("Cleaning temp directory");
|
|
_directoryService.ClearDirectory(_directoryService.TempDirectory);
|
|
await SendProgress(0.1F, "Cleaning temp directory");
|
|
CleanupCacheDirectory();
|
|
await SendProgress(0.25F, "Cleaning old database backups");
|
|
_logger.LogInformation("Cleaning old database backups");
|
|
await CleanupBackups();
|
|
await SendProgress(0.50F, "Cleaning deleted cover images");
|
|
_logger.LogInformation("Cleaning deleted cover images");
|
|
await DeleteSeriesCoverImages();
|
|
await SendProgress(0.6F, "Cleaning deleted cover images");
|
|
await DeleteChapterCoverImages();
|
|
await SendProgress(0.7F, "Cleaning deleted cover images");
|
|
await DeleteTagCoverImages();
|
|
await SendProgress(0.8F, "Cleaning deleted cover images");
|
|
await SendProgress(1F, "Cleanup finished");
|
|
_logger.LogInformation("Cleanup finished");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Cleans up abandon rows in the DB
|
|
/// </summary>
|
|
public async Task CleanupDbEntries()
|
|
{
|
|
await _unitOfWork.AppUserProgressRepository.CleanupAbandonedChapters();
|
|
await _unitOfWork.PersonRepository.RemoveAllPeopleNoLongerAssociated();
|
|
await _unitOfWork.GenreRepository.RemoveAllGenreNoLongerAssociated();
|
|
await _unitOfWork.CollectionTagRepository.RemoveTagsWithoutSeries();
|
|
}
|
|
|
|
private async Task SendProgress(float progress, string subtitle)
|
|
{
|
|
await _eventHub.SendMessageAsync(MessageFactory.NotificationProgress,
|
|
MessageFactory.CleanupProgressEvent(progress, subtitle));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all series images that are not in the database. They must follow <see cref="ImageService.SeriesCoverImageRegex"/> filename pattern.
|
|
/// </summary>
|
|
public async Task DeleteSeriesCoverImages()
|
|
{
|
|
var images = await _unitOfWork.SeriesRepository.GetAllCoverImagesAsync();
|
|
var files = _directoryService.GetFiles(_directoryService.CoverImageDirectory, ImageService.SeriesCoverImageRegex);
|
|
_directoryService.DeleteFiles(files.Where(file => !images.Contains(_directoryService.FileSystem.Path.GetFileName(file))));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all chapter/volume images that are not in the database. They must follow <see cref="ImageService.ChapterCoverImageRegex"/> filename pattern.
|
|
/// </summary>
|
|
public async Task DeleteChapterCoverImages()
|
|
{
|
|
var images = await _unitOfWork.ChapterRepository.GetAllCoverImagesAsync();
|
|
var files = _directoryService.GetFiles(_directoryService.CoverImageDirectory, ImageService.ChapterCoverImageRegex);
|
|
_directoryService.DeleteFiles(files.Where(file => !images.Contains(_directoryService.FileSystem.Path.GetFileName(file))));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all collection tag images that are not in the database. They must follow <see cref="ImageService.CollectionTagCoverImageRegex"/> filename pattern.
|
|
/// </summary>
|
|
public async Task DeleteTagCoverImages()
|
|
{
|
|
var images = await _unitOfWork.CollectionTagRepository.GetAllCoverImagesAsync();
|
|
var files = _directoryService.GetFiles(_directoryService.CoverImageDirectory, ImageService.CollectionTagCoverImageRegex);
|
|
_directoryService.DeleteFiles(files.Where(file => !images.Contains(_directoryService.FileSystem.Path.GetFileName(file))));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all files and directories in the cache directory
|
|
/// </summary>
|
|
public void CleanupCacheDirectory()
|
|
{
|
|
_logger.LogInformation("Performing cleanup of Cache directory");
|
|
_directoryService.ExistOrCreate(_directoryService.CacheDirectory);
|
|
|
|
try
|
|
{
|
|
_directoryService.ClearDirectory(_directoryService.CacheDirectory);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, "There was an issue deleting one or more folders/files during cleanup");
|
|
}
|
|
|
|
_logger.LogInformation("Cache directory purged");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes Database backups older than 30 days. If all backups are older than 30 days, the latest is kept.
|
|
/// </summary>
|
|
public async Task CleanupBackups()
|
|
{
|
|
const int dayThreshold = 30;
|
|
_logger.LogInformation("Beginning cleanup of Database backups at {Time}", DateTime.Now);
|
|
var backupDirectory =
|
|
(await _unitOfWork.SettingsRepository.GetSettingAsync(ServerSettingKey.BackupDirectory)).Value;
|
|
if (!_directoryService.Exists(backupDirectory)) return;
|
|
|
|
var deltaTime = DateTime.Today.Subtract(TimeSpan.FromDays(dayThreshold));
|
|
var allBackups = _directoryService.GetFiles(backupDirectory).ToList();
|
|
var expiredBackups = allBackups.Select(filename => _directoryService.FileSystem.FileInfo.FromFileName(filename))
|
|
.Where(f => f.CreationTime < deltaTime)
|
|
.ToList();
|
|
|
|
if (expiredBackups.Count == allBackups.Count)
|
|
{
|
|
_logger.LogInformation("All expired backups are older than {Threshold} days. Removing all but last backup", dayThreshold);
|
|
var toDelete = expiredBackups.OrderByDescending(f => f.CreationTime).ToList();
|
|
_directoryService.DeleteFiles(toDelete.Take(toDelete.Count - 1).Select(f => f.FullName));
|
|
}
|
|
else
|
|
{
|
|
_directoryService.DeleteFiles(expiredBackups.Select(f => f.FullName));
|
|
}
|
|
_logger.LogInformation("Finished cleanup of Database backups at {Time}", DateTime.Now);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all files in the BookmarkDirectory that don't currently have bookmarks in the Database
|
|
/// </summary>
|
|
public Task CleanupBookmarks()
|
|
{
|
|
// This is disabled for now while we test and validate a new method of deleting bookmarks
|
|
return Task.CompletedTask;
|
|
// Search all files in bookmarks/ except bookmark files and delete those
|
|
// var bookmarkDirectory =
|
|
// (await _unitOfWork.SettingsRepository.GetSettingAsync(ServerSettingKey.BookmarkDirectory)).Value;
|
|
// var allBookmarkFiles = _directoryService.GetFiles(bookmarkDirectory, searchOption: SearchOption.AllDirectories).Select(Parser.Parser.NormalizePath);
|
|
// var bookmarks = (await _unitOfWork.UserRepository.GetAllBookmarksAsync())
|
|
// .Select(b => Parser.Parser.NormalizePath(_directoryService.FileSystem.Path.Join(bookmarkDirectory,
|
|
// b.FileName)));
|
|
//
|
|
//
|
|
// var filesToDelete = allBookmarkFiles.AsEnumerable().Except(bookmarks).ToList();
|
|
// _logger.LogDebug("[Bookmarks] Bookmark cleanup wants to delete {Count} files", filesToDelete.Count);
|
|
//
|
|
// if (filesToDelete.Count == 0) return;
|
|
//
|
|
// _directoryService.DeleteFiles(filesToDelete);
|
|
//
|
|
// // Clear all empty directories
|
|
// foreach (var directory in _directoryService.FileSystem.Directory.GetDirectories(bookmarkDirectory, "", SearchOption.AllDirectories))
|
|
// {
|
|
// if (_directoryService.FileSystem.Directory.GetFiles(directory, "", SearchOption.AllDirectories).Length == 0 &&
|
|
// _directoryService.FileSystem.Directory.GetDirectories(directory).Length == 0)
|
|
// {
|
|
// _directoryService.FileSystem.Directory.Delete(directory, false);
|
|
// }
|
|
// }
|
|
}
|
|
}
|
|
}
|