mirror of
				https://github.com/Kareadita/Kavita.git
				synced 2025-10-31 02:27:04 -04:00 
			
		
		
		
	* Updated number inputs with a more mobile friendly control * Started writing lots of unit tests on PersonHelper to try and hammer out foreign constraint * Fixes side-nav actionable alignment * Added some unit tests * Buffed out the unit tests * Applied input modes throughout the app * Fixed a small bug in refresh token validation to make it work correctly * Try out a new way to block multithreading from interacting with people during series metadata update. * Fixed the lock code to properly lock, which should help with any constraint issues. * Locking notes * Tweaked locking on people to prevent a constraint issue. This slows down the scanner a bit, but not much. Will tweak after validating on a user's server. * Replaced all DBFactory.Series with SeriesBuilder. * Replaced all DBFactory.Volume() with VolumeBuilder * Replaced SeriesMetadata with Builder * Replaced DBFactory.CollectionTag * Lots of refactoring to streamline entity creation * Fixed one of the unit tests * Refactored all of new Library() * Removed tag and genre * Removed new SeriesMetadata * Refactored new Volume() * MangaFile() * ReadingList() * Refactored all of Chapter and ReadingList * Add title to all event widget flows * Updated Base Url to inform user it doesn't work for docker users with non-root user. * Added unit test coverage to FormatChapterTitle and FormatChapterName. * Started on Unit test for scanner, but need to finish it later. --------- Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>
		
			
				
	
	
		
			114 lines
		
	
	
		
			3.7 KiB
		
	
	
	
		
			C#
		
	
	
	
	
	
			
		
		
	
	
			114 lines
		
	
	
		
			3.7 KiB
		
	
	
	
		
			C#
		
	
	
	
	
	
| using System;
 | |
| using System.Collections.Generic;
 | |
| using System.Linq;
 | |
| using API.Data;
 | |
| using API.DTOs.Metadata;
 | |
| using API.Entities;
 | |
| using API.Extensions;
 | |
| using API.Helpers.Builders;
 | |
| 
 | |
| namespace API.Helpers;
 | |
| 
 | |
| public static class GenreHelper
 | |
| {
 | |
|     /// <summary>
 | |
|     ///
 | |
|     /// </summary>
 | |
|     /// <param name="allGenres"></param>
 | |
|     /// <param name="names"></param>
 | |
|     /// <param name="action"></param>
 | |
|     public static void UpdateGenre(ICollection<Genre> allGenres, IEnumerable<string> names, Action<Genre> action)
 | |
|     {
 | |
|         foreach (var name in names)
 | |
|         {
 | |
|             if (string.IsNullOrEmpty(name.Trim())) continue;
 | |
| 
 | |
|             var normalizedName = name.ToNormalized();
 | |
|             var genre = allGenres.FirstOrDefault(p => p.NormalizedTitle != null && p.NormalizedTitle.Equals(normalizedName));
 | |
|             if (genre == null)
 | |
|             {
 | |
|                 genre = new GenreBuilder(name).Build();
 | |
|                 allGenres.Add(genre);
 | |
|             }
 | |
| 
 | |
|             action(genre);
 | |
|         }
 | |
|     }
 | |
| 
 | |
| 
 | |
|     public static void KeepOnlySameGenreBetweenLists(ICollection<Genre> existingGenres, ICollection<Genre> removeAllExcept, Action<Genre>? action = null)
 | |
|     {
 | |
|         var existing = existingGenres.ToList();
 | |
|         foreach (var genre in existing)
 | |
|         {
 | |
|             var existingPerson = removeAllExcept.FirstOrDefault(g => genre.NormalizedTitle != null && genre.NormalizedTitle.Equals(g.NormalizedTitle));
 | |
|             if (existingPerson != null) continue;
 | |
|             existingGenres.Remove(genre);
 | |
|             action?.Invoke(genre);
 | |
|         }
 | |
| 
 | |
|     }
 | |
| 
 | |
|     /// <summary>
 | |
|     /// Adds the genre to the list if it's not already in there. This will ignore the ExternalTag.
 | |
|     /// </summary>
 | |
|     /// <param name="metadataGenres"></param>
 | |
|     /// <param name="genre"></param>
 | |
|     public static void AddGenreIfNotExists(ICollection<Genre> metadataGenres, Genre genre)
 | |
|     {
 | |
|         var existingGenre = metadataGenres.FirstOrDefault(p =>
 | |
|             p.NormalizedTitle == genre.Title?.ToNormalized());
 | |
|         if (existingGenre == null)
 | |
|         {
 | |
|             metadataGenres.Add(genre);
 | |
|         }
 | |
|     }
 | |
| 
 | |
| 
 | |
| 
 | |
|     public static void UpdateGenreList(ICollection<GenreTagDto>? tags, Series series,
 | |
|         IReadOnlyCollection<Genre> allTags, Action<Genre> handleAdd, Action onModified)
 | |
|     {
 | |
|         if (tags == null) return;
 | |
|         var isModified = false;
 | |
|         // I want a union of these 2 lists. Return only elements that are in both lists, but the list types are different
 | |
|         var existingTags = series.Metadata.Genres.ToList();
 | |
|         foreach (var existing in existingTags)
 | |
|         {
 | |
|             // NOTE: Why don't I use a NormalizedName here (outside of memory pressure from string creation)?
 | |
|             if (tags.SingleOrDefault(t => t.Id == existing.Id) == null)
 | |
|             {
 | |
|                 // Remove tag
 | |
|                 series.Metadata.Genres.Remove(existing);
 | |
|                 isModified = true;
 | |
|             }
 | |
|         }
 | |
| 
 | |
|         // At this point, all tags that aren't in dto have been removed.
 | |
|         foreach (var tagTitle in tags.Select(t => t.Title))
 | |
|         {
 | |
|             var normalizedTitle = tagTitle.ToNormalized();
 | |
|             var existingTag = allTags.SingleOrDefault(t => t.NormalizedTitle == normalizedTitle);
 | |
|             if (existingTag != null)
 | |
|             {
 | |
|                 if (series.Metadata.Genres.All(t => t.NormalizedTitle != normalizedTitle))
 | |
|                 {
 | |
|                     handleAdd(existingTag);
 | |
|                     isModified = true;
 | |
|                 }
 | |
|             }
 | |
|             else
 | |
|             {
 | |
|                 // Add new tag
 | |
|                 handleAdd(new GenreBuilder(tagTitle).Build());
 | |
|                 isModified = true;
 | |
|             }
 | |
|         }
 | |
| 
 | |
|         if (isModified)
 | |
|         {
 | |
|             onModified();
 | |
|         }
 | |
|     }
 | |
| }
 |