mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-11-03 19:17:05 -05:00
25703d6fe0
* Strip just isbn: from epub isbns and log when it's back (books) * Tweaked to allow invalid GTINs but only valid ISBN 10/13s will be saved to Kavita. * Fixed a bug with parsing series from a filename that is just a chapter range and no chapter/volume keywords. * Show the media issue count before you open accordion * Added a inpage filter for Media issues * Cleanup styles * Fixed up some code in epub isbn parsing when it's null * Encode filenames when downloading so that non english characters can be passed properly to UI. * Added support to parse ComicInfo's with Empty Tags. * Reset development settings. * Tweaked the code in generating reading lists to avoid extra work when not needed. * Fix comicvine's favicon * Fixed up a unit test * Tweaked the favicon code to ignore icons that have query parameters * More favicon work. Expanded ability to grab icons a bit. Added in ability to not keep requesting favicons when we failed to parse already. * Added a note for later * Fixed stats server url * Added more debugging * Fixed unit tests
85 lines
3.4 KiB
C#
85 lines
3.4 KiB
C#
using System.IO;
|
||
using System.IO.Abstractions;
|
||
using API.Services;
|
||
using EasyCaching.Core;
|
||
using Microsoft.Extensions.Logging;
|
||
using NSubstitute;
|
||
using Xunit;
|
||
|
||
namespace API.Tests.Services;
|
||
|
||
public class BookServiceTests
|
||
{
|
||
private readonly IBookService _bookService;
|
||
private readonly ILogger<BookService> _logger = Substitute.For<ILogger<BookService>>();
|
||
|
||
public BookServiceTests()
|
||
{
|
||
var directoryService = new DirectoryService(Substitute.For<ILogger<DirectoryService>>(), new FileSystem());
|
||
_bookService = new BookService(_logger, directoryService,
|
||
new ImageService(Substitute.For<ILogger<ImageService>>(), directoryService, Substitute.For<IEasyCachingProviderFactory>())
|
||
, Substitute.For<IMediaErrorService>());
|
||
}
|
||
|
||
[Theory]
|
||
[InlineData("The Golden Harpoon; Or, Lost Among the Floes A Story of the Whaling Grounds.epub", 16)]
|
||
[InlineData("Non-existent file.epub", 0)]
|
||
[InlineData("Non an ebub.pdf", 0)]
|
||
[InlineData("test_ſ.pdf", 1)] // This is dependent on Docnet bug https://github.com/GowenGit/docnet/issues/80
|
||
[InlineData("test.pdf", 1)]
|
||
public void GetNumberOfPagesTest(string filePath, int expectedPages)
|
||
{
|
||
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/BookService");
|
||
Assert.Equal(expectedPages, _bookService.GetNumberOfPages(Path.Join(testDirectory, filePath)));
|
||
}
|
||
|
||
[Fact]
|
||
public void ShouldHaveComicInfo()
|
||
{
|
||
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/BookService");
|
||
var archive = Path.Join(testDirectory, "The Golden Harpoon; Or, Lost Among the Floes A Story of the Whaling Grounds.epub");
|
||
const string summaryInfo = "Book Description";
|
||
|
||
var comicInfo = _bookService.GetComicInfo(archive);
|
||
Assert.NotNull(comicInfo);
|
||
Assert.Equal(summaryInfo, comicInfo.Summary);
|
||
Assert.Equal("genre1, genre2", comicInfo.Genre);
|
||
}
|
||
|
||
[Fact]
|
||
public void ShouldHaveComicInfo_WithAuthors()
|
||
{
|
||
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/BookService");
|
||
var archive = Path.Join(testDirectory, "The Golden Harpoon; Or, Lost Among the Floes A Story of the Whaling Grounds.epub");
|
||
|
||
var comicInfo = _bookService.GetComicInfo(archive);
|
||
Assert.NotNull(comicInfo);
|
||
Assert.Equal("Roger Starbuck,Junya Inoue", comicInfo.Writer);
|
||
}
|
||
|
||
[Fact]
|
||
public void ShouldParseAsVolumeGroup_WithoutSeriesIndex()
|
||
{
|
||
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/BookService");
|
||
var archive = Path.Join(testDirectory, "TitleWithVolume_NoSeriesOrSeriesIndex.epub");
|
||
|
||
var comicInfo = _bookService.GetComicInfo(archive);
|
||
Assert.NotNull(comicInfo);
|
||
Assert.Equal("1", comicInfo.Volume);
|
||
Assert.Equal("Accel World", comicInfo.Series);
|
||
}
|
||
|
||
[Fact]
|
||
public void ShouldParseAsVolumeGroup_WithSeriesIndex()
|
||
{
|
||
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/BookService");
|
||
var archive = Path.Join(testDirectory, "TitleWithVolume.epub");
|
||
|
||
var comicInfo = _bookService.GetComicInfo(archive);
|
||
Assert.NotNull(comicInfo);
|
||
Assert.Equal("1.0", comicInfo.Volume);
|
||
Assert.Equal("Accel World", comicInfo.Series);
|
||
}
|
||
|
||
}
|