mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-03 05:34:21 -04:00
bbe8f800f6
* Refactored all files to have Interfaces within the same file. Started moving over to file-scoped namespaces. * Refactored common methods for getting underlying file's cover, pages, and extracting into 1 interface. * More refactoring around removing dependence on explicit filetype testing for getting information. * Code is buildable, tests are broken. Huge refactor (not completed) which makes most of DirectoryService testable with a mock filesystem (and thus the services that utilize it). * Finished porting DirectoryService to use mocked filesystem implementation. * Added a null check * Added a null check * Finished all unit tests for DirectoryService. * Some misc cleanup on the code * Fixed up some bugs from refactoring scan loop. * Implemented CleanupService testing and refactored more of DirectoryService to be non-static. Fixed a bug where cover file cleanup wasn't properly finding files due to a regex bug. * Fixed an issue in CleanupBackup() where we weren't properly selecting database files older than 30 days. Finished CleanupService Tests. * Refactored Flatten and RemoveNonImages to directory service to allow CacheService to be testable. * Finally have CacheService tested. Rewrote GetCachedPagePath() to be much more straightforward & performant. * Updated DefaultParserTests.cs to contain all existing tests and follow new test layout format. * All tests fixed up
65 lines
2.1 KiB
C#
65 lines
2.1 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using API.Data;
|
|
using API.Entities;
|
|
|
|
namespace API.Helpers;
|
|
|
|
public static class GenreHelper
|
|
{
|
|
/// <summary>
|
|
///
|
|
/// </summary>
|
|
/// <param name="allPeople"></param>
|
|
/// <param name="names"></param>
|
|
/// <param name="isExternal"></param>
|
|
/// <param name="action"></param>
|
|
public static void UpdateGenre(ICollection<Genre> allPeople, IEnumerable<string> names, bool isExternal, Action<Genre> action)
|
|
{
|
|
foreach (var name in names)
|
|
{
|
|
if (string.IsNullOrEmpty(name.Trim())) continue;
|
|
|
|
var normalizedName = Parser.Parser.Normalize(name);
|
|
var genre = allPeople.FirstOrDefault(p =>
|
|
p.NormalizedTitle.Equals(normalizedName) && p.ExternalTag == isExternal);
|
|
if (genre == null)
|
|
{
|
|
genre = DbFactory.Genre(name, false);
|
|
allPeople.Add(genre);
|
|
}
|
|
|
|
action(genre);
|
|
}
|
|
}
|
|
|
|
public static void KeepOnlySameGenreBetweenLists(ICollection<Genre> existingGenres, ICollection<Genre> removeAllExcept, Action<Genre> action = null)
|
|
{
|
|
var existing = existingGenres.ToList();
|
|
foreach (var genre in existing)
|
|
{
|
|
var existingPerson = removeAllExcept.FirstOrDefault(g => g.ExternalTag == genre.ExternalTag && genre.NormalizedTitle.Equals(g.NormalizedTitle));
|
|
if (existingPerson != null) continue;
|
|
existingGenres.Remove(genre);
|
|
action?.Invoke(genre);
|
|
}
|
|
|
|
}
|
|
|
|
/// <summary>
|
|
/// Adds the genre to the list if it's not already in there. This will ignore the ExternalTag.
|
|
/// </summary>
|
|
/// <param name="metadataGenres"></param>
|
|
/// <param name="genre"></param>
|
|
public static void AddGenreIfNotExists(ICollection<Genre> metadataGenres, Genre genre)
|
|
{
|
|
var existingGenre = metadataGenres.FirstOrDefault(p =>
|
|
p.NormalizedTitle == Parser.Parser.Normalize(genre.Title));
|
|
if (existingGenre == null)
|
|
{
|
|
metadataGenres.Add(genre);
|
|
}
|
|
}
|
|
}
|