mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-22 15:00:34 -04:00
* Implemented a workaround for nginx users with BlockCommonExploits enabled, which would interfere with book image escaping done by Kavita when images had ../ in their path. * Added back to top support on all pages but those that untilize virtual scrolling without a parent scroll. * Hide jumpbar on pages where there is no scroll * Refactored jumbar code into a dedicated service * Stash some jumpkey resume code as I can't get it working with the virtual scroller. * Don't allow non-admins to see File locations on card detail drawer. * Some cleanup on GetServerInfo * When an error occurs in register, delete the user on exception. * Fixed a NPE in Stat collection for brand new users * When we catch an exception on registering a new user, delete the user as rolling back doesn't do anything. * Don't close typeahead when we are selecting options from it * Added shortcut key H to open shortcut modal on manga reader * When processing progress updates on cards, for volumes, properly find the chapter to update pages read. * Hide cover image on reading list if it's not set and fixed a missing closing div tag * Hide collection poster when nothing is set on collection detail * Small fix around updating state * Sped up the bookmark image call by removing one DB call * Fixed broken test from change in bookmark code * Fixed an oversight where if there is no tag in ComicInfo after a chapter was updated with People or Genres, then the People/Genres would never be removed. * Added test with TagHelper * Fixed a bug where 2 clear buttons would show on search bar due to browser injecting their own. Search bar wont show clear button until text is typed. * Fixed a bug where InstallID wasn't being selected correctly in converter
132 lines
3.5 KiB
C#
132 lines
3.5 KiB
C#
using System.Collections.Generic;
|
|
using API.Data;
|
|
using API.Entities;
|
|
using API.Helpers;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Helpers;
|
|
|
|
public class GenreHelperTests
|
|
{
|
|
[Fact]
|
|
public void UpdateGenre_ShouldAddNewGenre()
|
|
{
|
|
var allGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
};
|
|
var genreAdded = new List<Genre>();
|
|
|
|
GenreHelper.UpdateGenre(allGenres, new[] {"Action", "Adventure"}, false, genre =>
|
|
{
|
|
genreAdded.Add(genre);
|
|
});
|
|
|
|
Assert.Equal(2, genreAdded.Count);
|
|
Assert.Equal(4, allGenres.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void UpdateGenre_ShouldNotAddDuplicateGenre()
|
|
{
|
|
var allGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
|
|
};
|
|
var genreAdded = new List<Genre>();
|
|
|
|
GenreHelper.UpdateGenre(allGenres, new[] {"Action", "Scifi"}, false, genre =>
|
|
{
|
|
genreAdded.Add(genre);
|
|
});
|
|
|
|
Assert.Equal(3, allGenres.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void AddGenre_ShouldAddOnlyNonExistingGenre()
|
|
{
|
|
var existingGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
};
|
|
|
|
|
|
GenreHelper.AddGenreIfNotExists(existingGenres, DbFactory.Genre("Action", false));
|
|
Assert.Equal(3, existingGenres.Count);
|
|
|
|
GenreHelper.AddGenreIfNotExists(existingGenres, DbFactory.Genre("action", false));
|
|
Assert.Equal(3, existingGenres.Count);
|
|
|
|
GenreHelper.AddGenreIfNotExists(existingGenres, DbFactory.Genre("Shonen", false));
|
|
Assert.Equal(4, existingGenres.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void AddGenre_ShouldNotAddSameNameAndExternal()
|
|
{
|
|
var existingGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
};
|
|
|
|
|
|
GenreHelper.AddGenreIfNotExists(existingGenres, DbFactory.Genre("Action", true));
|
|
Assert.Equal(3, existingGenres.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void KeepOnlySamePeopleBetweenLists()
|
|
{
|
|
var existingGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
};
|
|
|
|
var peopleFromChapters = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
};
|
|
|
|
var genreRemoved = new List<Genre>();
|
|
GenreHelper.KeepOnlySameGenreBetweenLists(existingGenres,
|
|
peopleFromChapters, genre =>
|
|
{
|
|
genreRemoved.Add(genre);
|
|
});
|
|
|
|
Assert.Equal(1, genreRemoved.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void RemoveEveryoneIfNothingInRemoveAllExcept()
|
|
{
|
|
var existingGenres = new List<Genre>
|
|
{
|
|
DbFactory.Genre("Action", false),
|
|
DbFactory.Genre("Sci-fi", false),
|
|
};
|
|
|
|
var peopleFromChapters = new List<Genre>();
|
|
|
|
var genreRemoved = new List<Genre>();
|
|
GenreHelper.KeepOnlySameGenreBetweenLists(existingGenres,
|
|
peopleFromChapters, genre =>
|
|
{
|
|
genreRemoved.Add(genre);
|
|
});
|
|
|
|
Assert.Equal(2, genreRemoved.Count);
|
|
}
|
|
}
|