mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-03 21:54:47 -04:00
* Moved LibraryWatcher to utilize a queue for calculating the change event to ensure the Watcher doesn't get overwhelmed on large moves. * Fixed a security vulnerability (https://huntr.dev/bounties/8a3e652f-d6bf-436e-877e-0eaf5c69ef95/). This will be disclosed in Stable release changelog. * Tweaked the log message template * Removed some dead code from Configuration json patcher * Fixed a bug with the ComicInfo finding to properly handle root level. Fixed a bug where sometimes scanner wouldn't choose the first file with ComicInfo for filling out information. * Added new setting for managing how many logs files are allowed, just like how backups work. * Added unit tests for new CleanupLogs code * Fixed a bug where manga reader background color wasn't actually sending from the UI * Added new stats for tracking to help understand usage in the app and what features are used or not. * Fixed Stats url * Fixed a bug where volumes that had larger than 1 difference wouldn't properly return next/prev chapter (for continuous reader) * Remove a redundant test step in build pipeline, since it's already done at PR stage. * Updated dockerfile to use the new Heath check endpoint * Allow force to pass through to scan loop * Removed some old config stuff from a safety check on config in entrypoint.sh * Fixed broken unit tests due to new RBS check and how we setup mock data.
281 lines
10 KiB
C#
281 lines
10 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Diagnostics;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using API.Data;
|
|
using Hangfire;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace API.Services.Tasks.Scanner;
|
|
|
|
/// <summary>
|
|
/// Change information
|
|
/// </summary>
|
|
public class Change
|
|
{
|
|
/// <summary>
|
|
/// Gets or sets the type of the change.
|
|
/// </summary>
|
|
/// <value>
|
|
/// The type of the change.
|
|
/// </value>
|
|
public WatcherChangeTypes ChangeType { get; set; }
|
|
|
|
/// <summary>
|
|
/// Gets or sets the full path.
|
|
/// </summary>
|
|
/// <value>
|
|
/// The full path.
|
|
/// </value>
|
|
public string FullPath { get; set; }
|
|
|
|
/// <summary>
|
|
/// Gets or sets the name.
|
|
/// </summary>
|
|
/// <value>
|
|
/// The name.
|
|
/// </value>
|
|
public string Name { get; set; }
|
|
|
|
/// <summary>
|
|
/// Gets or sets the old full path.
|
|
/// </summary>
|
|
/// <value>
|
|
/// The old full path.
|
|
/// </value>
|
|
public string OldFullPath { get; set; }
|
|
|
|
/// <summary>
|
|
/// Gets or sets the old name.
|
|
/// </summary>
|
|
/// <value>
|
|
/// The old name.
|
|
/// </value>
|
|
public string OldName { get; set; }
|
|
}
|
|
|
|
public interface ILibraryWatcher
|
|
{
|
|
/// <summary>
|
|
/// Start watching all library folders
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
Task StartWatching();
|
|
/// <summary>
|
|
/// Stop watching all folders
|
|
/// </summary>
|
|
void StopWatching();
|
|
/// <summary>
|
|
/// Essentially stops then starts watching. Useful if there is a change in folders or libraries
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
Task RestartWatching();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Responsible for watching the file system and processing change events. This is mainly responsible for invoking
|
|
/// Scanner to quickly pickup on changes.
|
|
/// </summary>
|
|
public class LibraryWatcher : ILibraryWatcher
|
|
{
|
|
private readonly IDirectoryService _directoryService;
|
|
private readonly IUnitOfWork _unitOfWork;
|
|
private readonly ILogger<LibraryWatcher> _logger;
|
|
private readonly IScannerService _scannerService;
|
|
|
|
private readonly Dictionary<string, IList<FileSystemWatcher>> _watcherDictionary = new ();
|
|
/// <summary>
|
|
/// This is just here to prevent GC from Disposing our watchers
|
|
/// </summary>
|
|
private readonly IList<FileSystemWatcher> _fileWatchers = new List<FileSystemWatcher>();
|
|
private static IList<string> _libraryFolders = new List<string>();
|
|
/// <summary>
|
|
/// The amount of time until the Schedule ScanFolder task should be executed
|
|
/// </summary>
|
|
/// <remarks>The Job will be enqueued instantly</remarks>
|
|
private readonly TimeSpan _queueWaitTime;
|
|
|
|
|
|
public LibraryWatcher(IDirectoryService directoryService, IUnitOfWork unitOfWork, ILogger<LibraryWatcher> logger, IScannerService scannerService, IHostEnvironment environment)
|
|
{
|
|
_directoryService = directoryService;
|
|
_unitOfWork = unitOfWork;
|
|
_logger = logger;
|
|
_scannerService = scannerService;
|
|
|
|
_queueWaitTime = environment.IsDevelopment() ? TimeSpan.FromSeconds(30) : TimeSpan.FromMinutes(5);
|
|
|
|
}
|
|
|
|
public async Task StartWatching()
|
|
{
|
|
_logger.LogInformation("[LibraryWatcher] Starting file watchers");
|
|
|
|
_libraryFolders = (await _unitOfWork.LibraryRepository.GetLibraryDtosAsync())
|
|
.SelectMany(l => l.Folders)
|
|
.Distinct()
|
|
.Select(Parser.Parser.NormalizePath)
|
|
.Where(_directoryService.Exists)
|
|
.ToList();
|
|
foreach (var libraryFolder in _libraryFolders)
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Watching {FolderPath}", libraryFolder);
|
|
var watcher = new FileSystemWatcher(libraryFolder);
|
|
|
|
watcher.Changed += OnChanged;
|
|
watcher.Created += OnCreated;
|
|
watcher.Deleted += OnDeleted;
|
|
watcher.Error += OnError;
|
|
|
|
watcher.Filter = "*.*";
|
|
watcher.IncludeSubdirectories = true;
|
|
watcher.EnableRaisingEvents = true;
|
|
_fileWatchers.Add(watcher);
|
|
if (!_watcherDictionary.ContainsKey(libraryFolder))
|
|
{
|
|
_watcherDictionary.Add(libraryFolder, new List<FileSystemWatcher>());
|
|
}
|
|
|
|
_watcherDictionary[libraryFolder].Add(watcher);
|
|
}
|
|
_logger.LogInformation("[LibraryWatcher] Watching {Count} folders", _fileWatchers.Count);
|
|
}
|
|
|
|
public void StopWatching()
|
|
{
|
|
_logger.LogInformation("[LibraryWatcher] Stopping watching folders");
|
|
foreach (var fileSystemWatcher in _watcherDictionary.Values.SelectMany(watcher => watcher))
|
|
{
|
|
fileSystemWatcher.EnableRaisingEvents = false;
|
|
fileSystemWatcher.Changed -= OnChanged;
|
|
fileSystemWatcher.Created -= OnCreated;
|
|
fileSystemWatcher.Deleted -= OnDeleted;
|
|
fileSystemWatcher.Error -= OnError;
|
|
fileSystemWatcher.Dispose();
|
|
}
|
|
_fileWatchers.Clear();
|
|
_watcherDictionary.Clear();
|
|
}
|
|
|
|
public async Task RestartWatching()
|
|
{
|
|
StopWatching();
|
|
await StartWatching();
|
|
}
|
|
|
|
private void OnChanged(object sender, FileSystemEventArgs e)
|
|
{
|
|
if (e.ChangeType != WatcherChangeTypes.Changed) return;
|
|
_logger.LogDebug("[LibraryWatcher] Changed: {FullPath}, {Name}", e.FullPath, e.Name);
|
|
BackgroundJob.Enqueue(() => ProcessChange(e.FullPath, string.IsNullOrEmpty(_directoryService.FileSystem.Path.GetExtension(e.Name))));
|
|
}
|
|
|
|
private void OnCreated(object sender, FileSystemEventArgs e)
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Created: {FullPath}, {Name}", e.FullPath, e.Name);
|
|
BackgroundJob.Enqueue(() => ProcessChange(e.FullPath, !_directoryService.FileSystem.File.Exists(e.Name)));
|
|
}
|
|
|
|
/// <summary>
|
|
/// From testing, on Deleted only needs to pass through the event when a folder is deleted. If a file is deleted, Changed will handle automatically.
|
|
/// </summary>
|
|
/// <param name="sender"></param>
|
|
/// <param name="e"></param>
|
|
private void OnDeleted(object sender, FileSystemEventArgs e) {
|
|
var isDirectory = string.IsNullOrEmpty(_directoryService.FileSystem.Path.GetExtension(e.Name));
|
|
if (!isDirectory) return;
|
|
_logger.LogDebug("[LibraryWatcher] Deleted: {FullPath}, {Name}", e.FullPath, e.Name);
|
|
BackgroundJob.Enqueue(() => ProcessChange(e.FullPath, true));
|
|
}
|
|
|
|
|
|
private void OnError(object sender, ErrorEventArgs e)
|
|
{
|
|
_logger.LogError(e.GetException(), "[LibraryWatcher] An error occured, likely too many watches occured at once. Restarting Watchers");
|
|
Task.Run(RestartWatching);
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Processes the file or folder change. If the change is a file change and not from a supported extension, it will be ignored.
|
|
/// </summary>
|
|
/// <remarks>This will ignore image files that are added to the system. However, they may still trigger scans due to folder changes.</remarks>
|
|
/// <remarks>This is public only because Hangfire will invoke it. Do not call external to this class.</remarks>
|
|
/// <param name="filePath">File or folder that changed</param>
|
|
/// <param name="isDirectoryChange">If the change is on a directory and not a file</param>
|
|
public void ProcessChange(string filePath, bool isDirectoryChange = false)
|
|
{
|
|
var sw = Stopwatch.StartNew();
|
|
_logger.LogDebug("[LibraryWatcher] Processing change of {FilePath}", filePath);
|
|
try
|
|
{
|
|
// If not a directory change AND file is not an archive or book, ignore
|
|
if (!isDirectoryChange &&
|
|
!(Parser.Parser.IsArchive(filePath) || Parser.Parser.IsBook(filePath)))
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Change from {FilePath} is not an archive or book, ignoring change", filePath);
|
|
return;
|
|
}
|
|
|
|
// var libraryFolders = (await _unitOfWork.LibraryRepository.GetLibraryDtosAsync())
|
|
// .SelectMany(l => l.Folders)
|
|
// .Distinct()
|
|
// .Select(Parser.Parser.NormalizePath)
|
|
// .Where(_directoryService.Exists)
|
|
// .ToList();
|
|
|
|
var fullPath = GetFolder(filePath, _libraryFolders);
|
|
if (string.IsNullOrEmpty(fullPath))
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Change from {FilePath} could not find root level folder, ignoring change", filePath);
|
|
return;
|
|
}
|
|
|
|
// Check if this task has already enqueued or is being processed, before enquing
|
|
|
|
var alreadyScheduled =
|
|
TaskScheduler.HasAlreadyEnqueuedTask(ScannerService.Name, "ScanFolder", new object[] {fullPath});
|
|
_logger.LogDebug("[LibraryWatcher] {FullPath} already enqueued: {Value}", fullPath, alreadyScheduled);
|
|
if (!alreadyScheduled)
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Scheduling ScanFolder for {Folder}", fullPath);
|
|
BackgroundJob.Schedule(() => _scannerService.ScanFolder(fullPath), _queueWaitTime);
|
|
}
|
|
else
|
|
{
|
|
_logger.LogDebug("[LibraryWatcher] Skipped scheduling ScanFolder for {Folder} as a job already queued",
|
|
fullPath);
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogError(ex, "[LibraryWatcher] An error occured when processing a watch event");
|
|
}
|
|
_logger.LogDebug("[LibraryWatcher] ProcessChange ran in {ElapsedMilliseconds}ms", sw.ElapsedMilliseconds);
|
|
}
|
|
|
|
private string GetFolder(string filePath, IList<string> libraryFolders)
|
|
{
|
|
var parentDirectory = _directoryService.GetParentDirectoryName(filePath);
|
|
if (string.IsNullOrEmpty(parentDirectory))
|
|
{
|
|
return string.Empty;
|
|
}
|
|
if (string.IsNullOrEmpty(parentDirectory)) return string.Empty;
|
|
|
|
// We need to find the library this creation belongs to
|
|
// Multiple libraries can point to the same base folder. In this case, we need use FirstOrDefault
|
|
var libraryFolder = libraryFolders.FirstOrDefault(f => parentDirectory.Contains(f));
|
|
if (string.IsNullOrEmpty(libraryFolder)) return string.Empty;
|
|
|
|
var rootFolder = _directoryService.GetFoldersTillRoot(libraryFolder, filePath).ToList();
|
|
if (!rootFolder.Any()) return string.Empty;
|
|
|
|
// Select the first folder and join with library folder, this should give us the folder to scan.
|
|
return Parser.Parser.NormalizePath(_directoryService.FileSystem.Path.Join(libraryFolder, rootFolder.First()));
|
|
}
|
|
}
|