mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-23 07:20:32 -04:00
* Updated to net7.0 * Updated GA to .net 7 * Updated System.IO.Abstractions to use New factory. * Converted Regex into SourceGenerator in Parser. * Updated more regex to source generators. * Enabled Nullability and more regex changes throughout codebase. * Parser is 100% GeneratedRegexified * Lots of nullability code * Enabled nullability for all repositories. * Fixed another unit test * Refactored some code around and took care of some todos. * Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension * More nullability exercises. 500 warnings to go. * Fixed a bug where custom file uploads for entities wouldn't save in webP. * Nullability is done for all DTOs * Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement. * Use localization in book service after validating * Code smells * Switched to preview build of swashbuckle for .net7 support * Fixed up merge issues * Disable emulate comic book when on single page reader * Fixed a regression where double page renderer wouldn't layout the images correctly * Updated to swashbuckle which support .net 7 * Fixed a bad GA action * Some code cleanup * More code smells * Took care of most of nullable issues * Fixed a broken test due to having more than one test run in parallel * I'm really not sure why the unit tests are failing or are so extremely slow on .net 7 * Updated all dependencies * Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted. * Unit tests and code cleanup. Needs shakeout now. * Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project. * Refactored to use Builder pattern for all unit tests. * Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.
197 lines
6.5 KiB
C#
197 lines
6.5 KiB
C#
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using API.Data;
|
|
using API.Entities;
|
|
using API.Entities.Enums;
|
|
using API.Extensions;
|
|
using API.Helpers;
|
|
using API.Services.Tasks.Scanner;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Helpers;
|
|
|
|
public class SeriesHelperTests
|
|
{
|
|
#region FindSeries
|
|
[Fact]
|
|
public void FindSeries_ShouldFind_SameFormat()
|
|
{
|
|
var series = DbFactory.Series("Darker than Black");
|
|
series.OriginalName = "Something Random";
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Darker than Black",
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Darker than Black".ToLower(),
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Darker than Black".ToUpper(),
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
}
|
|
|
|
[Fact]
|
|
public void FindSeries_ShouldFind_NullName()
|
|
{
|
|
var series = DbFactory.Series("Darker than Black");
|
|
series.OriginalName = null;
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Darker than Black",
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
}
|
|
|
|
[Fact]
|
|
public void FindSeries_ShouldNotFind_WrongFormat()
|
|
{
|
|
var series = DbFactory.Series("Darker than Black");
|
|
series.OriginalName = "Something Random";
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.False(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Darker than Black",
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
|
|
Assert.False(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Darker than Black".ToLower(),
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
|
|
Assert.False(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Darker than Black".ToUpper(),
|
|
NormalizedName = "Darker than Black".ToNormalized()
|
|
}));
|
|
}
|
|
|
|
[Fact]
|
|
public void FindSeries_ShouldFind_UsingOriginalName()
|
|
{
|
|
var series = DbFactory.Series("Darker than Black");
|
|
series.OriginalName = "Something Random";
|
|
series.Format = MangaFormat.Image;
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random",
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random".ToLower(),
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random".ToUpper(),
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "SomethingRandom".ToUpper(),
|
|
NormalizedName = "SomethingRandom".ToNormalized()
|
|
}));
|
|
}
|
|
|
|
[Fact]
|
|
public void FindSeries_ShouldFind_UsingLocalizedName()
|
|
{
|
|
var series = DbFactory.Series("Darker than Black");
|
|
series.LocalizedName = "Something Random";
|
|
series.Format = MangaFormat.Image;
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random",
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random".ToLower(),
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "Something Random".ToUpper(),
|
|
NormalizedName = "Something Random".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Image,
|
|
Name = "SomethingRandom".ToUpper(),
|
|
NormalizedName = "SomethingRandom".ToNormalized()
|
|
}));
|
|
}
|
|
|
|
[Fact]
|
|
public void FindSeries_ShouldFind_UsingLocalizedName_2()
|
|
{
|
|
var series = DbFactory.Series("My Dress-Up Darling");
|
|
series.LocalizedName = "Sono Bisque Doll wa Koi wo Suru";
|
|
series.Format = MangaFormat.Archive;
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "My Dress-Up Darling",
|
|
NormalizedName = "My Dress-Up Darling".ToNormalized()
|
|
}));
|
|
|
|
Assert.True(SeriesHelper.FindSeries(series, new ParsedSeries()
|
|
{
|
|
Format = MangaFormat.Archive,
|
|
Name = "Sono Bisque Doll wa Koi wo Suru".ToLower(),
|
|
NormalizedName = "Sono Bisque Doll wa Koi wo Suru".ToNormalized()
|
|
}));
|
|
}
|
|
#endregion
|
|
|
|
[Fact]
|
|
public void RemoveMissingSeries_Should_RemoveSeries()
|
|
{
|
|
var existingSeries = new List<Series>()
|
|
{
|
|
EntityFactory.CreateSeries("Darker than Black Vol 1"),
|
|
EntityFactory.CreateSeries("Darker than Black"),
|
|
EntityFactory.CreateSeries("Beastars"),
|
|
};
|
|
var missingSeries = new List<Series>()
|
|
{
|
|
EntityFactory.CreateSeries("Darker than Black Vol 1"),
|
|
};
|
|
existingSeries = SeriesHelper.RemoveMissingSeries(existingSeries, missingSeries, out var removeCount).ToList();
|
|
|
|
Assert.DoesNotContain(missingSeries[0].Name, existingSeries.Select(s => s.Name));
|
|
Assert.Equal(missingSeries.Count, removeCount);
|
|
}
|
|
}
|