mirror of
https://github.com/Kareadita/Kavita.git
synced 2025-06-16 12:04:17 -04:00
* Navigate users to library page instead of home to prevent history block. * Cleaned up the Contributing to describe new code structure * Fixed a critical bug for how we find files for a chapter download (use ChapterId for lookup, not MangaFile.Id). Refactored how downloading works on the UI side to use the backend's filename whenever possible, else provide a custom name (and use backend's extension) for bundled downloads. * Fixed a bug where scroll intersection wasn't working on books without a table of content, even though it should have. * If user is using a direct url and hits an authentication guard, cache the url, allow authentication, then redirect them to said url * Added a transaction for bookmarking due to a rare case (in dev machines) where bookmark progress can duplicate * Re-enabled webtoon preference in reader settings. Refactored gotopage into it's own, dedicated handler to simplify logic. * Moved the prefetching code to occur whenever the page number within infinite scroller changes. This results in an easier to understand functioning. * Fixed isElementVisible() which was not properly calculating element visibility * GoToPage going forwards is working as expected, going backwards is completly broken * After performing a gotopage, make sure we update the scrolling direction based on the delta. * Removed some stuff thats not used, split the prefetching code up into separate functions to prepare for a rewrite. * Reworked prefetching to ensure we have a buffer of pages around ourselves. It is not fully tested, but working much better than previous implementation. Will be enhanced with DOM Pruning. * Cleaned up some old cruft from the backend code * Cleaned up the webtoon page change handler to use setPageNum, which will handle the correct prefetching of next/prev chapter * More cleanup around the codebase * Refactored the code to use a map to keep track of what is loaded or not, which works better than max/min in cases where you jump to a page that doesn't have anything preloaded and loads images out of order * Fixed a bad placement of code for when you are unauthenticated, the code will now redirect to the original location you requested before you had to login. * Some cleanup. Fixed the scrolling issue with prev page, spec seems to not work on intersection observer. using 0.01 instead of 0.0.
116 lines
5.0 KiB
C#
116 lines
5.0 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using API.Services;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace API.Tests.Services
|
|
{
|
|
|
|
public class DirectoryServiceTests
|
|
{
|
|
private readonly DirectoryService _directoryService;
|
|
private readonly ILogger<DirectoryService> _logger = Substitute.For<ILogger<DirectoryService>>();
|
|
|
|
public DirectoryServiceTests()
|
|
{
|
|
_directoryService = new DirectoryService(_logger);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFilesTest_Should_Be28()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/ScannerService/Manga");
|
|
// ReSharper disable once CollectionNeverQueried.Local
|
|
var files = new List<string>();
|
|
var fileCount = DirectoryService.TraverseTreeParallelForEach(testDirectory, s => files.Add(s),
|
|
API.Parser.Parser.ArchiveFileExtensions, _logger);
|
|
|
|
Assert.Equal(28, fileCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFiles_WithCustomRegex_ShouldPass_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService/regex");
|
|
var files = _directoryService.GetFiles(testDirectory, @"file\d*.txt");
|
|
Assert.Equal(2, files.Count());
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFiles_TopLevel_ShouldBeEmpty_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService");
|
|
var files = _directoryService.GetFiles(testDirectory);
|
|
Assert.Empty(files);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFilesWithExtensions_ShouldBeEmpty_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService/extensions");
|
|
var files = _directoryService.GetFiles(testDirectory, "*.txt");
|
|
Assert.Empty(files);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFilesWithExtensions_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService/extension");
|
|
var files = _directoryService.GetFiles(testDirectory, ".cbz|.rar");
|
|
Assert.Equal(3, files.Count());
|
|
}
|
|
|
|
[Fact]
|
|
public void GetFilesWithExtensions_BadDirectory_ShouldBeEmpty_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService/doesntexist");
|
|
var files = _directoryService.GetFiles(testDirectory, ".cbz|.rar");
|
|
Assert.Empty(files);
|
|
}
|
|
|
|
[Fact]
|
|
public void ListDirectory_SubDirectory_Test()
|
|
{
|
|
var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/DirectoryService/");
|
|
var dirs = _directoryService.ListDirectory(testDirectory);
|
|
Assert.Contains(dirs, s => s.Contains("regex"));
|
|
|
|
}
|
|
|
|
[Fact]
|
|
public void ListDirectory_NoSubDirectory_Test()
|
|
{
|
|
var dirs = _directoryService.ListDirectory("");
|
|
Assert.DoesNotContain(dirs, s => s.Contains("regex"));
|
|
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("C:/Manga/", "C:/Manga/Love Hina/Specials/Omake/", "Omake,Specials,Love Hina")]
|
|
[InlineData("C:/Manga/", "C:/Manga/Love Hina/Specials/Omake", "Omake,Specials,Love Hina")]
|
|
[InlineData("C:/Manga", "C:/Manga/Love Hina/Specials/Omake/", "Omake,Specials,Love Hina")]
|
|
[InlineData("C:/Manga", @"C:\Manga\Love Hina\Specials\Omake\", "Omake,Specials,Love Hina")]
|
|
[InlineData(@"/manga/", @"/manga/Love Hina/Specials/Omake/", "Omake,Specials,Love Hina")]
|
|
[InlineData(@"/manga/", @"/manga/", "")]
|
|
[InlineData(@"E:\test", @"E:\test\Sweet X Trouble\Sweet X Trouble - Chapter 001.cbz", "Sweet X Trouble")]
|
|
[InlineData(@"C:\/mount/gdrive/Library/Test Library/Comics/", @"C:\/mount/gdrive/Library/Test Library/Comics\godzilla rivals vs hedorah\vol 1\", "vol 1,godzilla rivals vs hedorah")]
|
|
[InlineData(@"/manga/", @"/manga/Btooom!/Vol.1 Chapter 2/1.cbz", "Vol.1 Chapter 2,Btooom!")]
|
|
[InlineData(@"C:/", @"C://Btooom!/Vol.1 Chapter 2/1.cbz", "Vol.1 Chapter 2,Btooom!")]
|
|
[InlineData(@"C:\\", @"C://Btooom!/Vol.1 Chapter 2/1.cbz", "Vol.1 Chapter 2,Btooom!")]
|
|
[InlineData(@"C://mount/gdrive/Library/Test Library/Comics", @"C://mount/gdrive/Library/Test Library/Comics/Dragon Age/Test", "Test,Dragon Age")]
|
|
public void GetFoldersTillRoot_Test(string rootPath, string fullpath, string expectedArray)
|
|
{
|
|
var expected = expectedArray.Split(",");
|
|
if (expectedArray.Equals(string.Empty))
|
|
{
|
|
expected = Array.Empty<string>();
|
|
}
|
|
Assert.Equal(expected, DirectoryService.GetFoldersTillRoot(rootPath, fullpath));
|
|
}
|
|
}
|
|
}
|