From 0c6d527f3cda1cdeb8206d67d721197372d792dc Mon Sep 17 00:00:00 2001
From: Zoe Roux <zoe.roux@sdg.moe>
Date: Mon, 13 Sep 2021 21:10:26 +0200
Subject: [PATCH] CI: Enforcing coding style

---
 .github/workflows/build.yml |  4 ++--
 src/Directory.Build.props   | 10 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3a21e2a3..a4a98525 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -45,8 +45,8 @@ jobs:
         shell: bash
         run: |
           echo "PROJECT=$([ "${{runner.os}}" == "Windows" ] \
-            && echo " -p:IncludeConsole=true src/Kyoo.Host.WindowsTrait" \
-            || echo src/Kyoo.Host.Console)" >> $GITHUB_ENV
+            && echo " -p:IncludeConsole=true -p:CheckCodingStyle=false src/Kyoo.Host.WindowsTrait" \
+            || echo " -p:CheckCodingStyle=false  src/Kyoo.Host.Console")" >> $GITHUB_ENV
       - name: Build the app
         env:
           INCLUDE: ${{env.INCLUDE}};C:\Program Files\FFmpeg\include
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index fe57ef74..b9d5b35c 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -3,9 +3,15 @@
 		<IsWindows Condition="$([MSBuild]::IsOSPlatform('Windows'))">true</IsWindows>
 		<IsOSX Condition="$([MSBuild]::IsOSPlatform('OSX'))">true</IsOSX>
 		<IsLinux Condition="$([MSBuild]::IsOSPlatform('Linux'))">true</IsLinux>
+
+
+		<!-- TODO the next thing does not work on rider, enabling coding style check by default. -->
+		<!--<CheckCodingStyle Condition="$(BuildingInsideVisualStudio) == true">true</CheckCodingStyle>-->
+		<!--<CheckCodingStyle Condition="$(BuildingInsideReSharper) == true">true</CheckCodingStyle>-->
+		<CheckCodingStyle Condition="$(CheckCodingStyle) == ''">true</CheckCodingStyle>
 	</PropertyGroup>
 
-	<ItemGroup>
+	<ItemGroup Condition="$(CheckCodingStyle) == true">
 		<PackageReference Include="SerilogAnalyzer" Version="0.15.0" PrivateAssets="All" />
 		<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.354" PrivateAssets="All" />
 
@@ -13,7 +19,7 @@
 		<None Include="$(MSBuildThisFileDirectory)../.editorconfig" Link=".editorconfig" Visible="false" />
 	</ItemGroup>
 
-	<PropertyGroup>
+	<PropertyGroup Condition="$(CheckCodingStyle) == true">
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
 		<NoWarn>CS1591;SA1600;SA1601</NoWarn>
 		<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>