Fix react native video new props

This commit is contained in:
Zoe Roux 2024-05-20 00:09:56 +02:00
parent f0b5b55b13
commit 5049ad25b5
No known key found for this signature in database
4 changed files with 75 additions and 62 deletions

View File

@ -39,7 +39,6 @@ import { episodeDisplayNumber } from "../details/episode";
import { ErrorView } from "../errors";
import { Back, Hover, LoadingIndicator } from "./components/hover";
import { useVideoKeyboard } from "./keyboard";
import { MediaSessionManager } from "./media-session";
import { Video, durationAtom, fullscreenAtom } from "./state";
import { WatchStatusObserver } from "./watch-status-observer";
@ -90,6 +89,15 @@ export const Player = ({
data && data.type === "episode" && data.nextEpisode
? `/watch/${data.nextEpisode.slug}?t=0`
: undefined;
const title =
data &&
(data.type === "movie"
? data.name
: `${data.show!.name} ${episodeDisplayNumber({
seasonNumber: data.seasonNumber,
episodeNumber: data.episodeNumber,
absoluteNumber: data.absoluteNumber,
})}`);
useVideoKeyboard(info?.subtitles, info?.fonts, previous, next);
@ -119,26 +127,7 @@ export const Player = ({
return (
<>
{data && (
<Head
title={
data.type === "movie"
? data.name
: `${data.show!.name} ${episodeDisplayNumber({
seasonNumber: data.seasonNumber,
episodeNumber: data.episodeNumber,
absoluteNumber: data.absoluteNumber,
})}`
}
description={data.overview}
/>
)}
<MediaSessionManager
title={data?.name ?? t("show.episodeNoMetadata")}
image={data?.thumbnail?.high}
next={next}
previous={previous}
/>
<Head title={title} description={data?.overview} />
{data && info && (
<WatchStatusObserver type={type} slug={data.slug} duration={info.durationSeconds} />
)}
@ -150,6 +139,13 @@ export const Player = ({
})}
>
<Video
metadata={{
title: title ?? t("show.episodeNoMetadata"),
description: data?.overview ?? undefined,
imageUri: data?.thumbnail?.high,
next: next,
previous: previous,
}}
links={data?.links}
audios={info?.audios}
subtitles={info?.subtitles}

View File

@ -104,6 +104,7 @@ export const Video = memo(function Video({
setError,
fonts,
startTime: startTimeP,
metadata,
...props
}: {
links?: Episode["links"];
@ -113,6 +114,13 @@ export const Video = memo(function Video({
setError: (error: string | undefined) => void;
fonts?: string[];
startTime?: number | null;
metadata: {
title?: string;
description?: string;
imageUri?: string;
previous?: string;
next?: string;
};
} & Partial<VideoProps>) {
const ref = useRef<ElementRef<typeof NativeVideo> | null>(null);
const [isPlaying, setPlay] = useAtom(playAtom);
@ -220,8 +228,12 @@ export const Video = memo(function Video({
source={{
uri: source,
startPosition: startTime.current ? startTime.current * 1000 : undefined,
metadata: metadata,
...links,
}}
showNotificationControls
playInBackground
playWhenInactive
paused={!isPlaying}
muted={isMuted}
volume={volume}

View File

@ -19,6 +19,7 @@
*/
import "react-native-video";
import type { ReactVideoSourceProperties } from "react-native-video";
declare module "react-native-video" {
interface ReactVideoProps {
@ -27,7 +28,7 @@ declare module "react-native-video" {
onMediaUnsupported?: () => void;
}
export type VideoProps = Omit<ReactVideoProps, "source"> & {
source: { uri: string; hls: string | null; startPosition?: number };
source: ReactVideoSourceProperties & { hls: string | null };
};
}
@ -120,7 +121,7 @@ const Video = forwardRef<VideoRef, VideoProps>(function Video(
type: SelectedTrackType.INDEX,
value: subtitles?.indexOf(subtitle),
}
: { type: SelectedTrackType.DISABLED }
: { type: SelectedTrackType.DISABLED, value: "" }
}
{...props}
/>

View File

@ -38,6 +38,7 @@ import toVttBlob from "srt-webvtt";
import { useForceRerender, useYoshiki } from "yoshiki";
import { useDisplayName } from "../utils";
import { PlayMode, audioAtom, playAtom, playModeAtom, progressAtom, subtitleAtom } from "./state";
import { MediaSessionManager } from "./media-session";
let hls: Hls | null = null;
@ -208,6 +209,8 @@ const Video = forwardRef<{ seek: (value: number) => void }, VideoProps>(function
const setProgress = useSetAtom(progressAtom);
return (
<>
<MediaSessionManager {...source.metadata} />
<video
ref={ref}
src={source.uri}
@ -248,6 +251,7 @@ const Video = forwardRef<{ seek: (value: number) => void }, VideoProps>(function
onEnded={onEnd}
{...css({ width: "100%", height: "100%", objectFit: "contain" })}
/>
</>
);
});