Migrate to dotnet8

back/Dockerfile

@@ -1,4 +1,4 @@
-FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:7.0 as builder
+FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:8.0 as builder
 ARG TARGETARCH
 WORKDIR /kyoo
 

back/Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/dotnet/sdk:7.0
+FROM mcr.microsoft.com/dotnet/sdk:8.0
 RUN apt-get update && apt-get install -y curl
 WORKDIR /app
 

back/src/Directory.Build.props

@@ -1,7 +1,7 @@
 <Project>
 	<PropertyGroup>
-		<TargetFramework>net7.0</TargetFramework>
+		<TargetFramework>net8.0</TargetFramework>
-		<LangVersion>preview</LangVersion>
+		<LangVersion>default</LangVersion>
 		<Company>Kyoo</Company>
 		<Authors>Kyoo</Authors>
 		<Copyright>Copyright (c) Kyoo</Copyright>

back/src/Kyoo.Abstractions/Models/Exceptions/DuplicatedItemException.cs

@@ -17,7 +17,6 @@
 // along with Kyoo. If not, see <https://www.gnu.org/licenses/>.
 
 using System;
-using System.Runtime.Serialization;
 
 namespace Kyoo.Abstractions.Models.Exceptions;
 
@@ -25,28 +24,10 @@ namespace Kyoo.Abstractions.Models.Exceptions;
 /// An exception raised when an item already exists in the database.
 /// </summary>
 [Serializable]
-public class DuplicatedItemException : Exception
+public class DuplicatedItemException(object? existing = null) : Exception("Already exists in the database.")
 {
 	/// <summary>
 	/// The existing object.
 	/// </summary>
-	public object? Existing { get; }
+	public object? Existing { get; } = existing;
-
-	/// <summary>
-	/// Create a new <see cref="DuplicatedItemException"/> with the default message.
-	/// </summary>
-	/// <param name="existing">The existing object.</param>
-	public DuplicatedItemException(object? existing = null)
-		: base("Already exists in the database.")
-	{
-		Existing = existing;
-	}
-
-	/// <summary>
-	/// The serialization constructor.
-	/// </summary>
-	/// <param name="info">Serialization infos</param>
-	/// <param name="context">The serialization context</param>
-	protected DuplicatedItemException(SerializationInfo info, StreamingContext context)
-		: base(info, context) { }
 }

back/src/Kyoo.Abstractions/Models/Exceptions/ItemNotFoundException.cs

@@ -17,7 +17,6 @@
 // along with Kyoo. If not, see <https://www.gnu.org/licenses/>.
 
 using System;
-using System.Runtime.Serialization;
 
 namespace Kyoo.Abstractions.Models.Exceptions;
 
@@ -39,12 +38,4 @@ public class ItemNotFoundException : Exception
 	/// <param name="message">The message of the exception</param>
 	public ItemNotFoundException(string message)
 		: base(message) { }
-
-	/// <summary>
-	/// The serialization constructor
-	/// </summary>
-	/// <param name="info">Serialization infos</param>
-	/// <param name="context">The serialization context</param>
-	protected ItemNotFoundException(SerializationInfo info, StreamingContext context)
-		: base(info, context) { }
 }

back/src/Kyoo.Abstractions/Models/Exceptions/UnauthorizedException.cs

@@ -17,7 +17,6 @@
 // along with Kyoo. If not, see <https://www.gnu.org/licenses/>.
 
 using System;
-using System.Runtime.Serialization;
 
 namespace Kyoo.Abstractions.Models.Exceptions;
 
@@ -29,7 +28,4 @@ public class UnauthorizedException : Exception
 
 	public UnauthorizedException(string message)
 		: base(message) { }
-
-	protected UnauthorizedException(SerializationInfo info, StreamingContext context)
-		: base(info, context) { }
 }

back/src/Kyoo.Authentication/Views/AuthApi.cs

@@ -446,7 +446,7 @@ public class AuthApi(
 	{
 		Stream img = await thumbs.GetUserImage(User.GetIdOrThrow());
 		// Allow clients to cache the image for 6 month.
-		Response.Headers.Add("Cache-Control", $"public, max-age={60 * 60 * 24 * 31 * 6}");
+		Response.Headers.CacheControl = $"public, max-age={60 * 60 * 24 * 31 * 6}";
 		return File(img, "image/webp", true);
 	}
 

back/src/Kyoo.Core/Views/Helper/CrudThumbsApi.cs

@@ -74,10 +74,10 @@ public class CrudThumbsApi<T> : CrudApi<T>
 		if (!identifier.Match(id => false, slug => slug == "random"))
 		{
 			// Allow clients to cache the image for 6 month.
-			Response.Headers.Add("Cache-Control", $"public, max-age={60 * 60 * 24 * 31 * 6}");
+			Response.Headers.CacheControl = $"public, max-age={60 * 60 * 24 * 31 * 6}";
 		}
 		else
-			Response.Headers.Add("Cache-Control", $"public, no-store");
+			Response.Headers.CacheControl = $"public, no-store";
 		return PhysicalFile(Path.GetFullPath(path), "image/webp", true);
 	}
 

back/src/Kyoo.Core/Views/Resources/UserApi.cs

@@ -59,11 +59,11 @@ public class UserApi(ILibraryManager libraryManager, IThumbnailsManager thumbs)
 		);
 		Stream img = await thumbs.GetUserImage(gid);
 		if (identifier.Is("random"))
-			Response.Headers.Add("Cache-Control", $"public, no-store");
+			Response.Headers.CacheControl = $"public, no-store";
 		else
 		{
 			// Allow clients to cache the image for 6 month.
-			Response.Headers.Add("Cache-Control", $"public, max-age={60 * 60 * 24 * 31 * 6}");
+			Response.Headers.CacheControl = $"public, max-age={60 * 60 * 24 * 31 * 6}";
 		}
 		return File(img, "image/webp", true);
 	}

back/src/Kyoo.Postgresql/Migrations/20231128171554_Initial.cs

@@ -23,8 +23,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class Initial : Migration
 {
@@ -567,4 +567,3 @@ namespace Kyoo.Postgresql.Migrations
 		migrationBuilder.DropTable(name: "studios");
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20231204000849_Watchlist.cs

@@ -22,8 +22,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class Watchlist : Migration
 {
@@ -221,4 +221,3 @@ namespace Kyoo.Postgresql.Migrations
 			.OldAnnotation("Npgsql:Enum:watch_status", "completed,watching,droped,planned");
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20231220093441_Settings.cs

@@ -2,8 +2,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class Settings : Migration
 {
@@ -25,4 +25,3 @@ namespace Kyoo.Postgresql.Migrations
 		migrationBuilder.DropColumn(name: "settings", table: "users");
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240120154137_RuntimeNullable.cs

@@ -1,9 +1,9 @@
-using Microsoft.EntityFrameworkCore.Migrations;
+using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class RuntimeNullable : Migration
 {
@@ -55,4 +55,3 @@ namespace Kyoo.Postgresql.Migrations
 		);
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240204193443_RemoveUserLogo.cs

@@ -1,7 +1,7 @@
 using Microsoft.EntityFrameworkCore.Migrations;
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class RemoveUserLogo : Migration
 {
@@ -32,4 +32,3 @@ namespace Kyoo.Postgresql.Migrations
 		);
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240217143306_AddIssues.cs

@@ -3,8 +3,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class AddIssues : Migration
 {
@@ -65,4 +65,3 @@ namespace Kyoo.Postgresql.Migrations
 		);
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240219170615_AddPlayPermission.cs

@@ -2,8 +2,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class AddPlayPermission : Migration
 {
@@ -19,4 +19,3 @@ namespace Kyoo.Postgresql.Migrations
 	/// <inheritdoc />
 	protected override void Down(MigrationBuilder migrationBuilder) { }
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240229202049_AddUserExternalId.cs

@@ -2,8 +2,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class AddUserExternalId : Migration
 {
@@ -25,4 +25,3 @@ namespace Kyoo.Postgresql.Migrations
 		migrationBuilder.DropColumn(name: "external_id", table: "users");
 	}
 }
-}

back/src/Kyoo.Postgresql/Migrations/20240302151906_MakePasswordOptional.cs

@@ -2,8 +2,8 @@ using Microsoft.EntityFrameworkCore.Migrations;
 
 #nullable disable
 
-namespace Kyoo.Postgresql.Migrations
+namespace Kyoo.Postgresql.Migrations;
-{
+
 /// <inheritdoc />
 public partial class MakePasswordOptional : Migration
 {
@@ -35,4 +35,3 @@ namespace Kyoo.Postgresql.Migrations
 		);
 	}
 }
-}

shell.nix

@@ -8,8 +8,8 @@
     ]);
   dotnet = with pkgs.dotnetCorePackages;
     combinePackages [
-      sdk_7_0
+      sdk_8_0
-      aspnetcore_7_0
+      aspnetcore_8_0
       aspnetcore_6_0
     ];
 in