From 6265f9bc2c5049d7c8f7fd9cec485ed6619a783a Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Thu, 1 Feb 2024 00:51:18 +0100 Subject: [PATCH] Use onMediaUnsupported on android too --- front/packages/primitives/src/snackbar.tsx | 2 +- front/packages/ui/src/player/video.tsx | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/front/packages/primitives/src/snackbar.tsx b/front/packages/primitives/src/snackbar.tsx index 81216d14..73fb4e8d 100644 --- a/front/packages/primitives/src/snackbar.tsx +++ b/front/packages/primitives/src/snackbar.tsx @@ -32,7 +32,7 @@ export type Snackbar = { key?: string; label: string; duration: number; - actions: Action[]; + actions?: Action[]; }; export type Action = { diff --git a/front/packages/ui/src/player/video.tsx b/front/packages/ui/src/player/video.tsx index bba5a0ee..7a5bfcc1 100644 --- a/front/packages/ui/src/player/video.tsx +++ b/front/packages/ui/src/player/video.tsx @@ -64,7 +64,7 @@ const videoAtom = atom(0); const clientId = uuid.v4() as string; const Video = forwardRef(function Video( - { onLoad, onBuffer, source, subtitles, ...props }, + { onLoad, onBuffer, onError, onMediaUnsupported, source, subtitles, ...props }, ref, ) { const { css } = useYoshiki(); @@ -98,6 +98,11 @@ const Video = forwardRef(function Video( onLoad?.(info); }} onBuffer={onBuffer} + onError={(e) => { + // 24001 is codec error + if (e.error.errorCode === "24001") onMediaUnsupported?.(); + else onError?.(e); + }} selectedVideoTrack={ video === -1 ? { type: SelectedVideoTrackType.AUDO }