Cutlery/Kyoo
1
0
Fork 0
mirror of https://github.com/zoriya/Kyoo.git synced 2025-05-31 20:24:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Move sc_threshold and no_scenecut to hwaccel flags

Browse Source
This commit is contained in:
Zoe Roux 2024-02-23 15:28:11 +00:00
parent f4980cefde
commit b042b4cf60
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
transcoder/src/hwaccel.go
View File

@ -20,6 +20,8 @@ func DetectHardwareAccel() HwAccelT {
EncodeFlags: []string{ EncodeFlags: []string{
"-c:v", "h264_nvenc", "-c:v", "h264_nvenc",
"-preset", "fast", "-preset", "fast",
// the exivalent of -sc_threshold on nvidia.
"-no-scenecut", "1",
}, },
// if the decode goes into system memory, we need to prepend the filters with "hwupload_cuda". // if the decode goes into system memory, we need to prepend the filters with "hwupload_cuda".
// since we use hwaccel_output_format, decoded data stays in gpu memory so we must not specify it (it errors) // since we use hwaccel_output_format, decoded data stays in gpu memory so we must not specify it (it errors)
@ -33,6 +35,10 @@ func DetectHardwareAccel() HwAccelT {
"-c:v", "libx264", "-c:v", "libx264",
// superfast or ultrafast would produce a file extremly big so we prever veryfast or faster. // superfast or ultrafast would produce a file extremly big so we prever veryfast or faster.
"-preset", "faster", "-preset", "faster",
// sc_threshold is a scene detection mechanisum used to create a keyframe when the scene changes
// this is on by default and inserts keyframes where we don't want to (it also breaks force_key_frames)
// we disable it to prevents whole scenes from behing removed due to the -f segment failing to find the corresonding keyframe
"-sc_threshold", "0",
}, },
// we could put :force_original_aspect_ratio=decrease:force_divisible_by=2 here but we already calculate a correct width and // we could put :force_original_aspect_ratio=decrease:force_divisible_by=2 here but we already calculate a correct width and
// aspect ratio in our code so there is no need. // aspect ratio in our code so there is no need.

4
transcoder/src/videostream.go
View File

@ -64,10 +64,6 @@ func (vs *VideoStream) getTranscodeArgs(segments string) []string {
"-maxrate", fmt.Sprint(vs.quality.MaxBitrate()), "-maxrate", fmt.Sprint(vs.quality.MaxBitrate()),
// Force segments to be split exactly on keyframes (only works when transcoding) // Force segments to be split exactly on keyframes (only works when transcoding)
"-force_key_frames", segments, "-force_key_frames", segments,
// sc_threshold is a scene detection mechanisum used to create a keyframe when the scene changes
// this is on by default and inserts keyframes where we don't want to (it also breaks force_key_frames)
// we disable it to prevents whole scenes from behing removed due to the -f segment failing to find the corresonding keyframe
"-sc_threshold", "0",
"-strict", "-2", "-strict", "-2",
) )
return args return args