Fixing module loading

Kyoo.Common/Controllers/IPlugin.cs

@@ -46,6 +46,12 @@ namespace Kyoo.Controllers
 		/// put typeof(ILibraryManager).
 		/// </remarks>
 		Type[] Requires { get; }
+		
+		/// <summary>
+		/// True if this plugin is needed to start Kyoo. If this is true and a dependency could not be met, app startup
+		/// will be canceled. If this is false, Kyoo's startup will continue without enabling this plugin.
+		/// </summary>
+		bool IsRequired { get; }
 
 		/// <summary>
 		/// A configure method that will be run on plugin's startup.

Kyoo.Common/Models/Exceptions/MissingDependencyException.cs

@@ -14,7 +14,7 @@ namespace Kyoo.Models.Exceptions
 		/// <param name="plugin">The name of the plugin that can't be loaded.</param>
 		/// <param name="dependency">The name of the missing dependency.</param>
 		public MissingDependencyException(string plugin, string dependency)
-			: base($"No {dependency} are available in kyoo but the plugin {plugin} requires it.")
+			: base($"No {dependency} are available in Kyoo but the plugin {plugin} requires it.")
 		{}
 	}
 }

Kyoo.Postgresql/PostgresModule.cs

@@ -29,6 +29,9 @@ namespace Kyoo.Postgresql
 
 		/// <inheritdoc />
 		public Type[] Requires => Array.Empty<Type>();
+		
+		/// <inheritdoc />
+		public bool IsRequired => true;
 
 
 		/// <summary>

Kyoo/Controllers/PluginManager.cs

@@ -88,14 +88,17 @@ namespace Kyoo.Controllers
 					return assembly.GetTypes()
 						.Where(x => typeof(IPlugin).IsAssignableFrom(x))
 						.Where(x => _plugins.All(y => y.GetType() != x))
-						.Select(x => (IPlugin)_container.Resolve(x));
+						.Select(x => (IPlugin)_container.Resolve(x))
+						.ToArray();
 				}
 				catch (Exception ex)
 				{
 					_logger.LogError(ex, "Could not load the plugin at {Path}", path);
 					return Array.Empty<IPlugin>();
 				}
-			}).ToArray();
+			}).ToList();
+			if (!_plugins.Any())
+				newPlugins.Add(new CoreModule());
 			_plugins.AddRange(newPlugins);
 
 			ICollection<Type> available = _plugins.SelectMany(x => x.Provides).ToArray();
@@ -103,8 +106,14 @@ namespace Kyoo.Controllers
 			{
 				Type missing = plugin.Requires.FirstOrDefault(x => available.All(y => !y.IsAssignableTo(x)));
 				if (missing != null)
-					throw new MissingDependencyException(plugin.Name, missing.Name);
+				{
-				plugin.Configure(_container);
+					Exception error = new MissingDependencyException(plugin.Name, missing.Name);
+					_logger.LogCritical(error, "A plugin's dependency could not be met");
+					if (plugin.IsRequired)
+						Environment.Exit(1);
+				}
+				else
+					plugin.Configure(_container);
 			}
 
 			if (!_plugins.Any())

Kyoo/CoreModule.cs

@@ -48,6 +48,9 @@ namespace Kyoo
 			typeof(DatabaseContext)
 		};
 
+		/// <inheritdoc />
+		public bool IsRequired => true;
+		
         /// <inheritdoc />
         public void Configure(IUnityContainer container)
 		{

Kyoo/Program.cs

@@ -49,7 +49,14 @@ namespace Kyoo
 			IWebHostBuilder host = CreateWebHostBuilder(args);
 			if (debug != null)
 				host = host.UseEnvironment(debug == true ? "Development" : "Production");
-			await host.Build().RunAsync();
+			try
+			{
+				await host.Build().RunAsync();
+			}
+			catch (Exception ex)
+			{
+				new Logger<Startup>(new LoggerFactory()).LogCritical(ex, "Unhandled exception");
+			}
 		}
 
 		/// <summary>
@@ -74,7 +81,7 @@ namespace Kyoo
 		{
 			UnityContainer container = new();
 			container.EnableDebugDiagnostic();
-			
+
 			return new WebHostBuilder()
 				.UseContentRoot(AppDomain.CurrentDomain.BaseDirectory)
 				.UseConfiguration(SetupConfig(new ConfigurationBuilder(), args).Build())

Kyoo/Startup.cs

@@ -44,6 +44,8 @@ namespace Kyoo
 		{
 			string publicUrl = _configuration.GetValue<string>("public_url");
 
+			services.AddMvc().AddControllersAsServices();
+			
 			services.AddSpaStaticFiles(configuration =>
 			{
 				configuration.RootPath = Path.Join(AppDomain.CurrentDomain.BaseDirectory, "wwwroot");
@@ -141,6 +143,11 @@ namespace Kyoo
 				AllowedOrigins = { new Uri(publicUrl).GetLeftPart(UriPartial.Authority) }
 			});
 		}
+
+		public void ConfigureContainer(IUnityContainer container)
+		{
+			// TODO move this to the configure section and figure out a way to reload ControllerActivators with the updated unity container
+		}
 		
 		public void Configure(IUnityContainer container, IApplicationBuilder app, IWebHostEnvironment env)
 		{
@@ -204,7 +211,7 @@ namespace Kyoo
 				if (env.IsDevelopment())
 					spa.UseAngularCliServer("start");
 			});
-
+			
 			container.RegisterType<IPluginManager, PluginManager>(new SingletonLifetimeManager());
 			IPluginManager pluginManager = new PluginManager(container, _configuration, new Logger<PluginManager>(_loggerFactory));
 			pluginManager.ReloadPlugins();