From 65a1e1ea9ab5541778fa613262d4a430efdfe577 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 00:07:20 +0200 Subject: [PATCH 01/11] Allowing neutral to work --- .github/workflows/release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e62bb55a..3d3ce29c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,6 +19,7 @@ jobs: ref: ${{github.ref}} repo-token: ${{secrets.GITHUB_TOKEN}} running-workflow-name: release + allowed-conclusions: success,skipped,cancelled,neutral - name: Generate changelog uses: mikepenz/release-changelog-builder-action@v1 env: From 9942fc5b6d774e599e17a995f2c27b114f019b5d Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 00:13:17 +0200 Subject: [PATCH 02/11] Update release.yml --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3d3ce29c..331f57cc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -14,7 +14,7 @@ jobs: - name: Set commit environment run: echo "COMMIT_SHA=$(git rev-list -n 1 ${{github.ref}})" >> $GITHUB_ENV - name: Wait for builds & tests to finish - uses: lewagon/wait-on-check-action@v0.2 + uses: lewagon/wait-on-check-action@master with: ref: ${{github.ref}} repo-token: ${{secrets.GITHUB_TOKEN}} From 9d40598eb1dd14b46a85f105894972a454001c6c Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 19:29:19 +0200 Subject: [PATCH 03/11] Fixing version's regex --- .github/workflows/release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 331f57cc..6f73c56c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -37,6 +37,7 @@ jobs: with: PROJECT_FILE_PATH: Kyoo.Common/Kyoo.Common.csproj PACKAGE_NAME: Kyoo.Common + VERSION_REGEX: ^\s*(.*)<\/PackageVersion>\s*$ NUGET_KEY: ${{secrets.NUGET_API_KEY}} INCLUDE_SYMBOLS: true - name: Create Release From a39c6fa2215bd8e1c1325a5843796735311bfdca Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 19:34:55 +0200 Subject: [PATCH 04/11] Removing sha from docker's tags --- .github/workflows/docker.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 55de4897..e61395ff 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -18,8 +18,6 @@ jobs: tags: | type=ref,event=tag type=ref,event=branch - type=ref,event=pr - type=sha,prefix= - name: Set up QEMU uses: docker/setup-qemu-action@v1 - name: Set up Docker Buildx From 9ab3534d282336453bfe2eaf79f53a97be40265c Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 20:33:38 +0200 Subject: [PATCH 05/11] Update release.yml --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6f73c56c..484d5036 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -46,5 +46,5 @@ jobs: draft: true release_name: ${{github.ref}} body: ${{steps.github_release.outputs.changelog}} - arficats: ./artifacts/**/* + artifacts: ./artifacts/**/* token: ${{secrets.GITHUB_TOKEN}} From 48881d739d96cc3b298664847639b08a3a997bb7 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 21:47:27 +0200 Subject: [PATCH 06/11] Adding a bug report issue template --- .github/ISSUE_TEMPLATE/bug-report.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug-report.md diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md new file mode 100644 index 00000000..959bd1a2 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -0,0 +1,20 @@ +--- +name: Bug Report +about: Create a bug report to help improve Kyoo +title: "[BUG] " +labels: bug +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. + +**Expected Behavior** +A clear and concise description of what you expected to happen. + +**Environment:** + - Platform [e.g. Windows / Linux] + - Action Version [e.g. v0.0.1 or a git commit's SHA] From d977ee277f2f2f29324c885c62a41592615d3110 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Mon, 19 Apr 2021 21:54:35 +0200 Subject: [PATCH 07/11] Adding a feature request issue template --- .github/ISSUE_TEMPLATE/feature-request.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/feature-request.md diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md new file mode 100644 index 00000000..19432212 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -0,0 +1,18 @@ +--- +name: Feature Request +about: Suggest a new feature for Kyoo (don't forget to check projects first) +title: "[FEATURE] " +labels: enhancement +--- + +**Is your feature request related to a problem? If yes, please describe.** +A clear and concise description of what the problem is. + +**Describe the feature you'd like** +A clear and concise description of what you want Kyoo to have. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 364c0cba53ac8e37db890c750cdd1b3569762ab1 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Tue, 20 Apr 2021 00:16:17 +0200 Subject: [PATCH 08/11] Create feature-proposal.md --- .../PULL_REQUEST_TEMPLATE/feature-proposal.md | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/feature-proposal.md diff --git a/.github/PULL_REQUEST_TEMPLATE/feature-proposal.md b/.github/PULL_REQUEST_TEMPLATE/feature-proposal.md new file mode 100644 index 00000000..6d910f7e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/feature-proposal.md @@ -0,0 +1,27 @@ +--- +name: Feature Proposal +about: Propose code for a new feature of Kyoo +title: "[FEATURE] " +labels: enhancement +--- + +## Proposed changes + +Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. +If it fixes a bug or resolves a feature request, be sure to link to that issue. + +## Informations + - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) + - [ ] New public API added + - [ ] Non-breaking changes + +## Checklist + + - [ ] I have added tests that prove my fix is effective or that my feature works + - [ ] I have added necessary documentation (if appropriate) + +## Further comments + +If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did +and what alternatives you considered, etc... + From cb277c390a732f0b1a6ed31f2302489540a4f3dc Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Tue, 20 Apr 2021 00:16:58 +0200 Subject: [PATCH 09/11] Update changelog.json --- deployment/changelog.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deployment/changelog.json b/deployment/changelog.json index a52bfdcf..4e7c94ec 100644 --- a/deployment/changelog.json +++ b/deployment/changelog.json @@ -2,11 +2,11 @@ "categories": [ { "title": "## Features", - "labels": ["feature"] + "labels": ["enhancement"] }, { "title": "## Fixes", - "labels": ["fix"] + "labels": ["bug"] }, { "title": "## Web App", @@ -15,4 +15,4 @@ ], "template": "${{CHANGELOG}}\n\n
\nOthers\n\n${{UNCATEGORIZED}}\n
", "pr_template": "- ${{TITLE}} (PR: #${{NUMBER}})" -} \ No newline at end of file +} From 4bcb515a403a32f520649453fb19484a2cbe0439 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Tue, 20 Apr 2021 00:18:59 +0200 Subject: [PATCH 10/11] Create bug-fix.md --- .github/PULL_REQUEST_TEMPLATE/bug-fix.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/bug-fix.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bug-fix.md b/.github/PULL_REQUEST_TEMPLATE/bug-fix.md new file mode 100644 index 00000000..6dd29447 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/bug-fix.md @@ -0,0 +1,21 @@ +--- +name: Bug Fix +about: Propose code for a bug fix +title: "[BUG] " +labels: bug +--- + +## Proposed changes + +Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. +If it fixes a bug or resolves a feature request, be sure to link to that issue. + +## Checklist + + - [ ] I have added tests that prove my fix is effective or that my feature works + - [ ] I have added necessary documentation (if appropriate) + +## Further comments + +If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did +and what alternatives you considered, etc... From c9416ede659d955fea0a92ac6fa31bfdf5660b32 Mon Sep 17 00:00:00 2001 From: Zoe Roux Date: Tue, 20 Apr 2021 00:22:34 +0200 Subject: [PATCH 11/11] Create webapp.md --- .github/PULL_REQUEST_TEMPLATE/webapp.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/webapp.md diff --git a/.github/PULL_REQUEST_TEMPLATE/webapp.md b/.github/PULL_REQUEST_TEMPLATE/webapp.md new file mode 100644 index 00000000..55527706 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/webapp.md @@ -0,0 +1,21 @@ +--- +name: Feature Proposal +about: Propose code for a change on the webapp of Kyoo +title: "[WEBAPP] " +labels: webapp +--- + +## Kyoo.WebApp Pull Request + +Please link a pull request from the [Kyoo.WebApp](https://github.com/AnonymusRaccoon/Kyoo.WebApp) repository, this pull request should +only be a shortcut to the one on this repository to inform users of changes. + +## Proposed changes + +Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. + +## Further comments + +If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did +and what alternatives you considered, etc... +