From 8a7b5cc87d0e8351569fa4e8772da781327d7cd4 Mon Sep 17 00:00:00 2001
From: advplyr <advplyr@protonmail.com>
Date: Tue, 24 Sep 2024 16:47:09 -0500
Subject: [PATCH] Ensure series-column-unique migration is idempotent

---
 server/managers/MigrationManager.js           |  3 +--
 .../v2.13.5-series-column-unique.js           | 20 +++++++++++++------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/server/managers/MigrationManager.js b/server/managers/MigrationManager.js
index 706e359c..beaf8a4d 100644
--- a/server/managers/MigrationManager.js
+++ b/server/managers/MigrationManager.js
@@ -38,6 +38,7 @@ class MigrationManager {
     if (!(await fs.pathExists(this.configPath))) throw new Error(`Config path does not exist: ${this.configPath}`)
 
     this.migrationsDir = path.join(this.configPath, 'migrations')
+    await fs.ensureDir(this.migrationsDir)
 
     this.serverVersion = this.extractVersionFromTag(serverVersion)
     if (!this.serverVersion) throw new Error(`Invalid server version: ${serverVersion}. Expected a version tag like v1.2.3.`)
@@ -222,8 +223,6 @@ class MigrationManager {
   }
 
   async copyMigrationsToConfigDir() {
-    await fs.ensureDir(this.migrationsDir) // Ensure the target directory exists
-
     if (!(await fs.pathExists(this.migrationsSourceDir))) return
 
     const files = await fs.readdir(this.migrationsSourceDir)
diff --git a/server/migrations/v2.13.5-series-column-unique.js b/server/migrations/v2.13.5-series-column-unique.js
index 1860772d..2724221a 100644
--- a/server/migrations/v2.13.5-series-column-unique.js
+++ b/server/migrations/v2.13.5-series-column-unique.js
@@ -16,7 +16,15 @@
  */
 async function up({ context: { queryInterface, logger } }) {
   // Upwards migration script
-  logger.info('UPGRADE BEGIN: 2.13.5-series-column-unique ')
+  logger.info('[2.13.5 migration] UPGRADE BEGIN: 2.13.5-series-column-unique ')
+
+  // Check if the unique index already exists
+  const seriesIndexes = await queryInterface.showIndex('Series')
+  if (seriesIndexes.some((index) => index.name === 'unique_series_name_per_library')) {
+    logger.info('[2.13.5 migration] Unique index on Series.name and Series.libraryId already exists')
+    logger.info('[2.13.5 migration] UPGRADE END: 2.13.5-series-column-unique ')
+    return
+  }
 
   // The steps taken to deduplicate the series are as follows:
   // 1. Find all duplicate series in the `Series` table.
@@ -173,9 +181,9 @@ async function up({ context: { queryInterface, logger } }) {
     unique: true,
     name: 'unique_series_name_per_library'
   })
-  logger.info('Added unique index on Series.name and Series.libraryId')
+  logger.info('[2.13.5 migration] Added unique index on Series.name and Series.libraryId')
 
-  logger.info('UPGRADE END: 2.13.5-series-column-unique ')
+  logger.info('[2.13.5 migration] UPGRADE END: 2.13.5-series-column-unique ')
 }
 
 /**
@@ -186,13 +194,13 @@ async function up({ context: { queryInterface, logger } }) {
  */
 async function down({ context: { queryInterface, logger } }) {
   // Downward migration script
-  logger.info('DOWNGRADE BEGIN: 2.13.5-series-column-unique ')
+  logger.info('[2.13.5 migration] DOWNGRADE BEGIN: 2.13.5-series-column-unique ')
 
   // Remove the unique index
   await queryInterface.removeIndex('Series', 'unique_series_name_per_library')
-  logger.info('Removed unique index on Series.name and Series.libraryId')
+  logger.info('[2.13.5 migration] Removed unique index on Series.name and Series.libraryId')
 
-  logger.info('DOWNGRADE END: 2.13.5-series-column-unique ')
+  logger.info('[2.13.5 migration] DOWNGRADE END: 2.13.5-series-column-unique ')
 }
 
 module.exports = { up, down }