From c307b1e6fbb0147732bfe98079fb713b7fccc670 Mon Sep 17 00:00:00 2001 From: Lars Kiesow Date: Mon, 21 Nov 2022 01:54:25 +0100 Subject: [PATCH 1/2] No feed log level This patch drops the log level for logging requests to non-existing feeds from error to debug. The reasoning behind this is that this is a client error and a client error is returned and can be handled by the client. Otherwise anyone can easily spam the logs with error messages by just requesting non-existing feeds. --- server/managers/RssFeedManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/managers/RssFeedManager.js b/server/managers/RssFeedManager.js index 5b333849..b681a0d9 100644 --- a/server/managers/RssFeedManager.js +++ b/server/managers/RssFeedManager.js @@ -33,7 +33,7 @@ class RssFeedManager { async getFeed(req, res) { var feed = this.feeds[req.params.id] if (!feed) { - Logger.error(`[RssFeedManager] Feed not found ${req.params.id}`) + Logger.debug(`[RssFeedManager] Feed not found ${req.params.id}`) res.sendStatus(404) return } From a2f17236422a70aa9cce29b97584784fb7fc74c2 Mon Sep 17 00:00:00 2001 From: advplyr Date: Mon, 21 Nov 2022 06:39:32 -0600 Subject: [PATCH 2/2] Update log level for RSS feed requests --- server/managers/RssFeedManager.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/managers/RssFeedManager.js b/server/managers/RssFeedManager.js index b681a0d9..ce15bbea 100644 --- a/server/managers/RssFeedManager.js +++ b/server/managers/RssFeedManager.js @@ -55,7 +55,7 @@ class RssFeedManager { getFeedItem(req, res) { var feed = this.feeds[req.params.id] if (!feed) { - Logger.error(`[RssFeedManager] Feed not found ${req.params.id}`) + Logger.debug(`[RssFeedManager] Feed not found ${req.params.id}`) res.sendStatus(404) return } @@ -71,7 +71,7 @@ class RssFeedManager { getFeedCover(req, res) { var feed = this.feeds[req.params.id] if (!feed) { - Logger.error(`[RssFeedManager] Feed not found ${req.params.id}`) + Logger.debug(`[RssFeedManager] Feed not found ${req.params.id}`) res.sendStatus(404) return }