mirror of
				https://github.com/advplyr/audiobookshelf.git
				synced 2025-11-04 03:17:00 -05:00 
			
		
		
		
	This patch fixes the problem that toggling one of the options in the user account dialog will automatically submit the form. The problem got introduced as a combination of the recent accessibility fixes where some elements got turned into HTML button elements to make them keyboard accessible. Doing that, I did not realize that the default type of a button is `submit` [1]. This causes no problems at most places, but will cause problem within a form (e.g. the user account settings) where toggling an option is now identical to clicking submit. This patch fixes the issue by setting the `type` attribute to `button`. Not only for the toggle switch, but also for a few other elements which have been recently converted to buttons. [1] https://www.w3.org/TR/2011/WD-html5-20110525/the-button-element.html#attr-button-type
		
			
				
	
	
		
			49 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Vue
		
	
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Vue
		
	
	
	
	
	
<template>
 | 
						|
  <div>
 | 
						|
    <button :aria-labelledby="labeledBy" role="checkbox" type="button" class="border rounded-full border-black-100 flex items-center cursor-pointer w-10 justify-start" :aria-checked="toggleValue" :class="className" @click="clickToggle">
 | 
						|
      <span class="rounded-full border w-5 h-5 border-black-50 shadow transform transition-transform duration-100" :class="switchClassName"></span>
 | 
						|
    </button>
 | 
						|
  </div>
 | 
						|
</template>
 | 
						|
 | 
						|
<script>
 | 
						|
export default {
 | 
						|
  props: {
 | 
						|
    value: Boolean,
 | 
						|
    onColor: {
 | 
						|
      type: String,
 | 
						|
      default: 'success'
 | 
						|
    },
 | 
						|
    offColor: {
 | 
						|
      type: String,
 | 
						|
      default: 'primary'
 | 
						|
    },
 | 
						|
    disabled: Boolean,
 | 
						|
    labeledBy: String
 | 
						|
  },
 | 
						|
  computed: {
 | 
						|
    toggleValue: {
 | 
						|
      get() {
 | 
						|
        return this.value
 | 
						|
      },
 | 
						|
      set(val) {
 | 
						|
        this.$emit('input', val)
 | 
						|
      }
 | 
						|
    },
 | 
						|
    className() {
 | 
						|
      if (this.disabled) return this.toggleValue ? `bg-${this.onColor} cursor-not-allowed` : `bg-${this.offColor} cursor-not-allowed`
 | 
						|
      return this.toggleValue ? `bg-${this.onColor}` : `bg-${this.offColor}`
 | 
						|
    },
 | 
						|
    switchClassName() {
 | 
						|
      var bgColor = this.disabled ? 'bg-gray-300' : 'bg-white'
 | 
						|
      return this.toggleValue ? 'translate-x-5 ' + bgColor : bgColor
 | 
						|
    }
 | 
						|
  },
 | 
						|
  methods: {
 | 
						|
    clickToggle() {
 | 
						|
      if (this.disabled) return
 | 
						|
      this.toggleValue = !this.toggleValue
 | 
						|
    }
 | 
						|
  }
 | 
						|
}
 | 
						|
</script> |