Cutlery/beestat
1
0
Fork 0
mirror of https://github.com/beestat/app.git synced 2025-11-04 02:47:01 -05:00
Code Actions Packages Releases Activity

Fixed primary memory leak for #277

Browse Source 
Cleaned up old Highcharts data
This commit is contained in:
Jon Ziebell 2023-12-16 09:57:06 -05:00
parent 2dc95b92fa
commit 6d802f2210
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
js/component/chart.js
View File

@ -13,13 +13,17 @@ beestat.component.chart = function() {
}; };
beestat.extend(beestat.component.chart, beestat.component); beestat.extend(beestat.component.chart, beestat.component);
beestat.component.chart.charts_ = [];
/** /**
* Decorate. Calls all the option getters and renders the chart. * Decorate. Calls all the option getters and renders the chart.
* *
* @param {rocket.Elements} parent * @param {rocket.Elements} parent
*/ */
beestat.component.chart.prototype.decorate_ = function(parent) { beestat.component.chart.prototype.decorate_ = function(parent) {
var options = {}; const self = this;
const options = {};
options.credits = this.get_options_credits_(); options.credits = this.get_options_credits_();
options.exporting = this.get_options_exporting_(); options.exporting = this.get_options_exporting_();
@ -37,6 +41,23 @@ beestat.component.chart.prototype.decorate_ = function(parent) {
this.chart_ = Highcharts.chart(options); this.chart_ = Highcharts.chart(options);
this.addEventListener('render', function() {
/**
* Clean up old charts. Charts only get added to this array once they
* actually get rendered to the page, so it's safe to assume that if they
* no longer exist in the DOM they can be destroyed.
*/
for (let i = beestat.component.chart.charts_.length - 1; i >= 0; i--) {
if (document.body.contains(beestat.component.chart.charts_[i].chart_.container) === false) {
beestat.component.chart.charts_[i].chart_.destroy();
beestat.component.chart.charts_.splice(i, 1);
}
}
// Add this chart to the charts list.
beestat.component.chart.charts_.push(self);
});
this.docked_tooltip_container_ = $.createElement('div'); this.docked_tooltip_container_ = $.createElement('div');
this.docked_tooltip_container_.style({ this.docked_tooltip_container_.style({
'margin-top': (beestat.style.size.gutter / 2) + 'px' 'margin-top': (beestat.style.size.gutter / 2) + 'px'