Cutlery/beestat
1
0
Fork 0
mirror of https://github.com/beestat/app.git synced 2025-05-24 02:14:03 -04:00
Code Actions Packages Releases Activity

Fixed #160 - Syncing fails if either heat or cool temps are null

Browse Source 
No longer requiring indoor heat/cool temps non-null as a requirement for syncing a row.
This commit is contained in:
Jon Ziebell 2019-10-20 21:46:10 -04:00
parent f141234b24
commit d60c5236fe
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/runtime_thermostat.php
View File

@ -363,6 +363,9 @@ class runtime_thermostat extends cora\crud {
* Also threw in null checks on a bunch of other fields just to simplify
* the code later on. This happens so rarely that throwing away a whole
* row for a null value shouldn't have any noticeable negative effect.
*
* Note: Don't ignore zoneHeatTemp or zoneCoolTemp. Sometimes those are
* legit null as the thermostat may be for heat/cool only (see #160).
*/
if(
$columns['hvacMode'] === null ||
@ -370,8 +373,6 @@ class runtime_thermostat extends cora\crud {
$columns['zoneHumidity'] === null ||
$columns['outdoorTemp'] === null ||
$columns['outdoorHumidity'] === null ||
$columns['zoneCoolTemp'] === null ||
$columns['zoneHeatTemp'] === null ||
$columns['compHeat1'] === null ||
$columns['compHeat2'] === null ||
$columns['compCool1'] === null ||