mirror of
				https://github.com/caddyserver/caddy.git
				synced 2025-11-03 19:17:29 -05:00 
			
		
		
		
	Use the built-in max/min to simplify the code (#7081)
	
		
			
	
		
	
	
		
	
		
			Some checks failed
		
		
	
	
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.24.1, ubuntu-latest, 0, 1.24, linux) (push) Failing after 1m53s
				
			
		
			
				
	
				Tests / test (s390x on IBM Z) (push) Has been skipped
				
			
		
			
				
	
				Tests / goreleaser-check (push) Has been skipped
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, aix) (push) Successful in 1m35s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, darwin) (push) Successful in 1m29s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, dragonfly) (push) Successful in 1m28s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, freebsd) (push) Successful in 1m28s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, illumos) (push) Successful in 1m23s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, linux) (push) Successful in 1m23s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, netbsd) (push) Successful in 1m21s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, openbsd) (push) Successful in 1m20s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, solaris) (push) Successful in 1m21s
				
			
		
			
				
	
				Cross-Build / build (~1.24.1, 1.24, windows) (push) Successful in 1m21s
				
			
		
			
				
	
				Lint / lint (ubuntu-latest, linux) (push) Successful in 1m57s
				
			
		
			
				
	
				Lint / govulncheck (push) Successful in 1m31s
				
			
		
			
				
	
				Lint / dependency-review (push) Failing after 41s
				
			
		
			
				
	
				OpenSSF Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.24.1, macos-14, 0, 1.24, mac) (push) Has been cancelled
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy.exe, ~1.24.1, windows-latest, True, 1.24, windows) (push) Has been cancelled
				
			
		
			
				
	
				Lint / lint (macos-14, mac) (push) Has been cancelled
				
			
		
			
				
	
				Lint / lint (windows-latest, windows) (push) Has been cancelled
				
			
		
		
	
	
				
					
				
			
		
			Some checks failed
		
		
	
	Tests / test (./cmd/caddy/caddy, ~1.24.1, ubuntu-latest, 0, 1.24, linux) (push) Failing after 1m53s
				
			Tests / test (s390x on IBM Z) (push) Has been skipped
				
			Tests / goreleaser-check (push) Has been skipped
				
			Cross-Build / build (~1.24.1, 1.24, aix) (push) Successful in 1m35s
				
			Cross-Build / build (~1.24.1, 1.24, darwin) (push) Successful in 1m29s
				
			Cross-Build / build (~1.24.1, 1.24, dragonfly) (push) Successful in 1m28s
				
			Cross-Build / build (~1.24.1, 1.24, freebsd) (push) Successful in 1m28s
				
			Cross-Build / build (~1.24.1, 1.24, illumos) (push) Successful in 1m23s
				
			Cross-Build / build (~1.24.1, 1.24, linux) (push) Successful in 1m23s
				
			Cross-Build / build (~1.24.1, 1.24, netbsd) (push) Successful in 1m21s
				
			Cross-Build / build (~1.24.1, 1.24, openbsd) (push) Successful in 1m20s
				
			Cross-Build / build (~1.24.1, 1.24, solaris) (push) Successful in 1m21s
				
			Cross-Build / build (~1.24.1, 1.24, windows) (push) Successful in 1m21s
				
			Lint / lint (ubuntu-latest, linux) (push) Successful in 1m57s
				
			Lint / govulncheck (push) Successful in 1m31s
				
			Lint / dependency-review (push) Failing after 41s
				
			OpenSSF Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
				
			Tests / test (./cmd/caddy/caddy, ~1.24.1, macos-14, 0, 1.24, mac) (push) Has been cancelled
				
			Tests / test (./cmd/caddy/caddy.exe, ~1.24.1, windows-latest, True, 1.24, windows) (push) Has been cancelled
				
			Lint / lint (macos-14, mac) (push) Has been cancelled
				
			Lint / lint (windows-latest, windows) (push) Has been cancelled
				
			Signed-off-by: xiaoxiangirl <caojiaqiao@outlook.com>
This commit is contained in:
		
							parent
							
								
									2f0fc62b34
								
							
						
					
					
						commit
						070d454c0d
					
				@ -236,10 +236,7 @@ func (c *Cache) makeRoom() {
 | 
			
		||||
	// the cache is on a long tail, we can save a lot of CPU
 | 
			
		||||
	// time by doing a whole bunch of deletions now and then
 | 
			
		||||
	// we won't have to do them again for a while
 | 
			
		||||
	numToDelete := len(c.cache) / 10
 | 
			
		||||
	if numToDelete < 1 {
 | 
			
		||||
		numToDelete = 1
 | 
			
		||||
	}
 | 
			
		||||
	numToDelete := max(len(c.cache)/10, 1)
 | 
			
		||||
	for deleted := 0; deleted <= numToDelete; deleted++ {
 | 
			
		||||
		// Go maps are "nondeterministic" not actually random,
 | 
			
		||||
		// so although we could just chop off the "front" of the
 | 
			
		||||
 | 
			
		||||
@ -219,10 +219,7 @@ func (r RandomChoiceSelection) Validate() error {
 | 
			
		||||
 | 
			
		||||
// Select returns an available host, if any.
 | 
			
		||||
func (r RandomChoiceSelection) Select(pool UpstreamPool, _ *http.Request, _ http.ResponseWriter) *Upstream {
 | 
			
		||||
	k := r.Choose
 | 
			
		||||
	if k > len(pool) {
 | 
			
		||||
		k = len(pool)
 | 
			
		||||
	}
 | 
			
		||||
	k := min(r.Choose, len(pool))
 | 
			
		||||
	choices := make([]*Upstream, k)
 | 
			
		||||
	for i, upstream := range pool {
 | 
			
		||||
		if !upstream.Available() {
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user