mirror of
				https://github.com/caddyserver/caddy.git
				synced 2025-11-01 19:17:25 -04:00 
			
		
		
		
	chore: make FastAbs comment more easy to understand (#6692)
	
		
			
	
		
	
	
		
	
		
			Some checks failed
		
		
	
	
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.22.3, ubuntu-latest, 0, 1.22, linux) (push) Failing after 2m18s
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.23.0, ubuntu-latest, 0, 1.23, linux) (push) Failing after 1m46s
				
			
		
			
				
	
				Tests / test (s390x on IBM Z) (push) Has been skipped
				
			
		
			
				
	
				Tests / goreleaser-check (push) Has been skipped
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, aix) (push) Successful in 1m26s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, darwin) (push) Successful in 1m25s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, dragonfly) (push) Successful in 1m25s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, freebsd) (push) Successful in 2m4s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, illumos) (push) Successful in 1m43s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, linux) (push) Successful in 1m28s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, netbsd) (push) Successful in 1m24s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, openbsd) (push) Successful in 1m26s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, solaris) (push) Successful in 1m32s
				
			
		
			
				
	
				Cross-Build / build (~1.22.3, 1.22, windows) (push) Successful in 2m40s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, aix) (push) Successful in 5m38s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, darwin) (push) Successful in 1m16s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, dragonfly) (push) Successful in 1m16s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, freebsd) (push) Successful in 1m15s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, illumos) (push) Successful in 1m15s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, linux) (push) Successful in 1m15s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, netbsd) (push) Successful in 1m16s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, openbsd) (push) Successful in 1m17s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, solaris) (push) Successful in 1m14s
				
			
		
			
				
	
				Cross-Build / build (~1.23.0, 1.23, windows) (push) Successful in 1m16s
				
			
		
			
				
	
				Lint / lint (ubuntu-latest, linux) (push) Successful in 1m56s
				
			
		
			
				
	
				Lint / govulncheck (push) Successful in 1m13s
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.22.3, macos-14, 0, 1.22, mac) (push) Has been cancelled
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy, ~1.23.0, macos-14, 0, 1.23, mac) (push) Has been cancelled
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy.exe, ~1.22.3, windows-latest, True, 1.22, windows) (push) Has been cancelled
				
			
		
			
				
	
				Tests / test (./cmd/caddy/caddy.exe, ~1.23.0, windows-latest, True, 1.23, windows) (push) Has been cancelled
				
			
		
			
				
	
				Lint / lint (macos-14, mac) (push) Has been cancelled
				
			
		
			
				
	
				Lint / lint (windows-latest, windows) (push) Has been cancelled
				
			
		
		
	
	
				
					
				
			
		
			Some checks failed
		
		
	
	Tests / test (./cmd/caddy/caddy, ~1.22.3, ubuntu-latest, 0, 1.22, linux) (push) Failing after 2m18s
				
			Tests / test (./cmd/caddy/caddy, ~1.23.0, ubuntu-latest, 0, 1.23, linux) (push) Failing after 1m46s
				
			Tests / test (s390x on IBM Z) (push) Has been skipped
				
			Tests / goreleaser-check (push) Has been skipped
				
			Cross-Build / build (~1.22.3, 1.22, aix) (push) Successful in 1m26s
				
			Cross-Build / build (~1.22.3, 1.22, darwin) (push) Successful in 1m25s
				
			Cross-Build / build (~1.22.3, 1.22, dragonfly) (push) Successful in 1m25s
				
			Cross-Build / build (~1.22.3, 1.22, freebsd) (push) Successful in 2m4s
				
			Cross-Build / build (~1.22.3, 1.22, illumos) (push) Successful in 1m43s
				
			Cross-Build / build (~1.22.3, 1.22, linux) (push) Successful in 1m28s
				
			Cross-Build / build (~1.22.3, 1.22, netbsd) (push) Successful in 1m24s
				
			Cross-Build / build (~1.22.3, 1.22, openbsd) (push) Successful in 1m26s
				
			Cross-Build / build (~1.22.3, 1.22, solaris) (push) Successful in 1m32s
				
			Cross-Build / build (~1.22.3, 1.22, windows) (push) Successful in 2m40s
				
			Cross-Build / build (~1.23.0, 1.23, aix) (push) Successful in 5m38s
				
			Cross-Build / build (~1.23.0, 1.23, darwin) (push) Successful in 1m16s
				
			Cross-Build / build (~1.23.0, 1.23, dragonfly) (push) Successful in 1m16s
				
			Cross-Build / build (~1.23.0, 1.23, freebsd) (push) Successful in 1m15s
				
			Cross-Build / build (~1.23.0, 1.23, illumos) (push) Successful in 1m15s
				
			Cross-Build / build (~1.23.0, 1.23, linux) (push) Successful in 1m15s
				
			Cross-Build / build (~1.23.0, 1.23, netbsd) (push) Successful in 1m16s
				
			Cross-Build / build (~1.23.0, 1.23, openbsd) (push) Successful in 1m17s
				
			Cross-Build / build (~1.23.0, 1.23, solaris) (push) Successful in 1m14s
				
			Cross-Build / build (~1.23.0, 1.23, windows) (push) Successful in 1m16s
				
			Lint / lint (ubuntu-latest, linux) (push) Successful in 1m56s
				
			Lint / govulncheck (push) Successful in 1m13s
				
			Tests / test (./cmd/caddy/caddy, ~1.22.3, macos-14, 0, 1.22, mac) (push) Has been cancelled
				
			Tests / test (./cmd/caddy/caddy, ~1.23.0, macos-14, 0, 1.23, mac) (push) Has been cancelled
				
			Tests / test (./cmd/caddy/caddy.exe, ~1.22.3, windows-latest, True, 1.22, windows) (push) Has been cancelled
				
			Tests / test (./cmd/caddy/caddy.exe, ~1.23.0, windows-latest, True, 1.23, windows) (push) Has been cancelled
				
			Lint / lint (macos-14, mac) (push) Has been cancelled
				
			Lint / lint (windows-latest, windows) (push) Has been cancelled
				
			This commit is contained in:
		
							parent
							
								
									37f0c4bfae
								
							
						
					
					
						commit
						6028ff27fa
					
				| @ -24,6 +24,8 @@ import ( | ||||
| // FastAbs is an optimized version of filepath.Abs for Unix systems, | ||||
| // since we don't expect the working directory to ever change once | ||||
| // Caddy is running. Avoid the os.Getwd() syscall overhead. | ||||
| // It's overall the same as stdlib's implementation, the difference | ||||
| // being cached working directory. | ||||
| func FastAbs(path string) (string, error) { | ||||
| 	if filepath.IsAbs(path) { | ||||
| 		return filepath.Clean(path), nil | ||||
|  | ||||
| @ -18,8 +18,10 @@ import ( | ||||
| 	"path/filepath" | ||||
| ) | ||||
| 
 | ||||
| // FastAbs can't be optimized on Windows because the | ||||
| // syscall.FullPath function takes an input. | ||||
| // FastAbs can't be optimized on Windows because there | ||||
| // are special file paths that require the use of syscall.FullPath | ||||
| // to handle correctly. | ||||
| // Just call stdlib's implementation which uses that function. | ||||
| func FastAbs(path string) (string, error) { | ||||
| 	return filepath.Abs(path) | ||||
| } | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user