Cutlery/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-07-08 02:34:49 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

ci: update the linter action version (#6575)
Some checks failed
Tests / test (./cmd/caddy/caddy, ~1.22.3, ubuntu-latest, 0, 1.22, linux) (push) Failing after 3m22s
Details
Tests / test (./cmd/caddy/caddy, ~1.23.0, ubuntu-latest, 0, 1.23, linux) (push) Failing after 2m39s
Details
Tests / test (s390x on IBM Z) (push) Has been skipped
Details
Tests / goreleaser-check (push) Successful in 32s
Details
Cross-Build / build (~1.22.3, 1.22, aix) (push) Successful in 2m52s
Details
Cross-Build / build (~1.22.3, 1.22, dragonfly) (push) Successful in 2m52s
Details
Cross-Build / build (~1.22.3, 1.22, illumos) (push) Successful in 2m54s
Details
Cross-Build / build (~1.22.3, 1.22, linux) (push) Successful in 2m50s
Details
Cross-Build / build (~1.22.3, 1.22, netbsd) (push) Successful in 2m51s
Details
Cross-Build / build (~1.22.3, 1.22, darwin) (push) Failing after 13m24s
Details
Cross-Build / build (~1.22.3, 1.22, freebsd) (push) Failing after 10m16s
Details
Cross-Build / build (~1.22.3, 1.22, openbsd) (push) Successful in 2m50s
Details
Cross-Build / build (~1.22.3, 1.22, solaris) (push) Successful in 2m54s
Details
Cross-Build / build (~1.22.3, 1.22, windows) (push) Successful in 3m5s
Details
Cross-Build / build (~1.23.0, 1.23, aix) (push) Successful in 2m42s
Details
Cross-Build / build (~1.23.0, 1.23, dragonfly) (push) Successful in 2m39s
Details
Cross-Build / build (~1.23.0, 1.23, freebsd) (push) Successful in 2m40s
Details
Cross-Build / build (~1.23.0, 1.23, illumos) (push) Successful in 2m49s
Details
Cross-Build / build (~1.23.0, 1.23, linux) (push) Successful in 2m45s
Details
Cross-Build / build (~1.23.0, 1.23, darwin) (push) Failing after 13m28s
Details
Cross-Build / build (~1.23.0, 1.23, netbsd) (push) Successful in 2m39s
Details
Cross-Build / build (~1.23.0, 1.23, openbsd) (push) Successful in 2m46s
Details
Cross-Build / build (~1.23.0, 1.23, solaris) (push) Successful in 2m39s
Details
Cross-Build / build (~1.23.0, 1.23, windows) (push) Successful in 2m49s
Details
Lint / govulncheck (push) Successful in 2m17s
Details
Lint / lint (ubuntu-latest, linux) (push) Failing after 10m22s
Details
Tests / test (./cmd/caddy/caddy, ~1.22.3, macos-14, 0, 1.22, mac) (push) Has been cancelled
Details
Tests / test (./cmd/caddy/caddy, ~1.23.0, macos-14, 0, 1.23, mac) (push) Has been cancelled
Details
Tests / test (./cmd/caddy/caddy.exe, ~1.22.3, windows-latest, True, 1.22, windows) (push) Has been cancelled
Details
Tests / test (./cmd/caddy/caddy.exe, ~1.23.0, windows-latest, True, 1.23, windows) (push) Has been cancelled
Details
Lint / lint (macos-14, mac) (push) Has been cancelled
Details
Lint / lint (windows-latest, windows) (push) Has been cancelled
Details

Browse Source 
* ci: update the linter action version

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>

* exclude rule `G115`; disable deprecated linter

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>

---------

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
This commit is contained in:
Mohammed Al Sahaf 2024-09-16 16:50:26 +03:00 committed by GitHub
parent f4bf4e0097
commit 6ab9fb6f74
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/lint.yml vendored
View File

@ -49,7 +49,7 @@ jobs:
- name: golangci-lint - name: golangci-lint
uses: golangci/golangci-lint-action@v6 uses: golangci/golangci-lint-action@v6
with: with:
version: v1.60 version: latest
# Windows times out frequently after about 5m50s if we don't set a longer timeout. # Windows times out frequently after about 5m50s if we don't set a longer timeout.
args: --timeout 10m args: --timeout 10m

4
.golangci.yml
View File

@ -35,7 +35,6 @@ linters:
- errcheck - errcheck
- errname - errname
- exhaustive - exhaustive
- exportloopref
- gci - gci
- gofmt - gofmt
- goimports - goimports
@ -145,6 +144,9 @@ output:
issues: issues:
exclude-rules: exclude-rules:
- text: 'G115' # TODO: Either we should fix the issues or nuke the linter if it's bad
linters:
- gosec
# we aren't calling unknown URL # we aren't calling unknown URL
- text: 'G107' # G107: Url provided to HTTP request as taint input - text: 'G107' # G107: Url provided to HTTP request as taint input
linters: linters:

1
modules/caddyhttp/server.go
View File

@ -817,7 +817,6 @@ func (s *Server) logRequest(
} }
if fields == nil { if fields == nil {
userID, _ := repl.GetString("http.auth.user.id") userID, _ := repl.GetString("http.auth.user.id")
reqBodyLength := 0 reqBodyLength := 0