22 Commits

Author	SHA1	Message	Date
Br1an	d80774cb3f	metrics: Add nil check for metricsHandler in AdminMetrics.serveHTTP (#7553) ... * metrics: Add nil check for metricsHandler in AdminMetrics.serveHTTP Prevents panic when the admin metrics endpoint is accessed before the module is fully provisioned. Returns a proper API error instead of crashing. * admin: provision router modules before registering routes Instead of adding a nil check for metricsHandler, address the root cause by provisioning admin router modules before calling Routes(). This ensures all handler state is initialized before routes are registered on the mux. Merge newAdminHandler and provisionAdminRouters into a single step, removing the two-phase setup where routes were registered first and modules provisioned later. The AdminConfig.routers field is no longer needed since provisioning happens inline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: go fmt admin.go --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>	2026-05-11 17:27:03 -06:00
Amemoyoi	18ab0f955f	admin: reject non-canonical config array indices (#7592) ... * admin: reject non-canonical config array indices * admin: expand canonical array index test coverage * Update admin.go Co-authored-by: Matt Holt <mholt@users.noreply.github.com> * Update admin.go Co-authored-by: Matt Holt <mholt@users.noreply.github.com> * admin: improve canonical array index test diagnostics --------- Co-authored-by: Matt Holt <mholt@users.noreply.github.com>	2026-04-30 09:39:57 -06:00
Amemoyoi	2d33271482	admin: require path segment boundary in remote access control (#7673)	2026-04-27 08:43:39 -06:00
Zen Dodd	4430756d5c	admin: Redact sensitive request headers in API logs (#7578) ... * admin: Redact sensitive request headers in API logs * Fix govulncheck and typed atomic lint failures * Sync Go module metadata after dependency downgrade	2026-04-17 14:56:42 -06:00
Francis Lavoie	3adcafd4c1	admin: Fix tests locally, properly isolate storage (#7486) ... * admin: Fix tests locally, properly isolate storage * Fix flaky pki_test * Drop testdata dir logic * Safer temp dir * Test handlers without a full server	2026-02-17 13:14:06 -07:00
mickychang9	bcd4055e89	Use WaitGroup.Go to simplify code (#7253) ... Signed-off-by: mickychang9 <mickychang9@outlook.com>	2025-09-11 10:15:09 -06:00
joemicky	5125fbed41	use a more modern writing style to simplify code (#7182) ... Signed-off-by: joemicky <joemickychang@outlook.com> Co-authored-by: Matt Holt <mholt@users.noreply.github.com>	2025-08-20 11:41:21 -06:00
eveneast	a76d005a94	Use maps.Copy for simpler map handling (#7009) ... Signed-off-by: eveneast <qcqs@foxmail.com>	2025-05-13 15:16:47 -06:00
Matthew Holt	f297bc0a04	admin: Remove host checking for UDS (close #6832) ... The consensus is that host enforcement on unix sockets is ineffective, frustrating, and confusing. (Unix sockets have their own OS-level permissions system.)	2025-04-15 14:20:22 -06:00
Gaurav Dhameeja	d7621fdbe6	tests: tests for error handling & metrics in admin endpoints (#6805) ... * feat/tests: tests for error handling & metrics in admin endpoints - TestAdminHandlerErrorHandling - Tests the handler.handleError() functionality by directly verifying error response formatting - TestAdminHandlerBuiltinRouteErrors - Tests the error handling pathway by using real admin server routes and verifying both error responses and prometheus metrics increments - provisionAdminRouters: add unit tests for admin handler registration and routing for admin.api - TestAllowedOriginsUnixSocket: checks unix socket with default origins are added - TestReplaceRemoteAdminServer: test for replaceRemoteAdminServer with certificate validation, custom origins and cleanup * test: added test for manage manageIdentity --------- Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>	2025-02-12 11:39:47 +00:00
Norman Soetbeer	0e204b730a	admin: Respond with 4xx on non-existing config path (#5870) ... Co-authored-by: Matt Holt <mholt@users.noreply.github.com>	2023-10-11 20:24:29 +00:00
Francis Lavoie	821a08a6e3	httpcaddyfile: Fix protocols global option parsing (#5054) ... * httpcaddyfile: Fix `protocols` global option parsing When checking for a block, the current nesting must be used, otherwise it returns the wrong thing. * Adjust adapt test to cover the broken behaviour that is now fixed * Fix some admin tests which suddenly run even with -short	2022-09-20 08:09:04 -06:00
Francis Lavoie	141872ed80	chore: Bump up to Go 1.19, minimum 1.18 (#4925)	2022-08-02 16:39:09 -04:00
jhwz	ad3a83fb91	admin: expect quoted ETags (#4879) ... * expect quoted etags * admin: Minor refactor of etag facilities Co-authored-by: Matthew Holt <mholt@users.noreply.github.com>	2022-07-12 12:23:55 -06:00
jhwz	f259ed52bb	admin: support ETag on config endpoints (#4579) ... * admin: support ETags * support etags Co-authored-by: Matt Holt <mholt@users.noreply.github.com>	2022-07-06 13:50:07 -06:00
Steven Angles	a10910f398	admin: Sync server variables (fix #4260) (#4274) ... * Synchronize server assignment/references to avoid data race * only hold lock during var reassignment	2021-08-16 15:04:47 -06:00
Matthew Holt	6455efa5d3	admin: POST /... expands and appends all array elements ... Makes it easy to append many items to an array in one command	2019-12-17 10:11:45 -07:00
Matthew Holt	35f70c98fa	core: Major refactor of admin endpoint and config handling ... Fixed several bugs and made other improvements. All config changes are now mediated by the global config state manager. It used to be that initial configs given at startup weren't tracked, so you could start caddy with --config caddy.json and then do a GET /config/ and it would return null. That is fixed, along with several other general flow/API enhancements, with more to come.	2019-11-04 12:05:20 -07:00
Matthew Holt	3177ee8010	Add license	2019-06-30 16:07:58 -06:00
Matthew Holt	5137859e47	Rename caddy2 -> caddy ... Removes the version from the package name	2019-06-14 11:58:28 -06:00
Matthew Holt	2eb3593327	Begin implementing HTTP replacer and static responder	2019-05-04 13:21:20 -06:00
Matthew Holt	a8dc73b4d9	Performance testing Load function	2019-03-26 19:42:52 -06:00