mirror of
				https://github.com/caddyserver/caddy.git
				synced 2025-11-04 03:27:23 -05:00 
			
		
		
		
	- The mime middleware used filepath where it should arguably use path. - Changed the configuration to use a map instead of scanning an array during every request. The map is static (after configuration), so should be fine for concurrent access. - Catch duplicate extensions within a configuration and error out. - Add tests for new error case.
		
			
				
	
	
		
			71 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			71 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package mime
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"net/http"
 | 
						|
	"net/http/httptest"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/mholt/caddy/middleware"
 | 
						|
)
 | 
						|
 | 
						|
func TestMimeHandler(t *testing.T) {
 | 
						|
 | 
						|
	mimes := Config{
 | 
						|
		".html": "text/html",
 | 
						|
		".txt":  "text/plain",
 | 
						|
		".swf":  "application/x-shockwave-flash",
 | 
						|
	}
 | 
						|
 | 
						|
	m := Mime{Configs: mimes}
 | 
						|
 | 
						|
	w := httptest.NewRecorder()
 | 
						|
	exts := []string{
 | 
						|
		".html", ".txt", ".swf",
 | 
						|
	}
 | 
						|
	for _, e := range exts {
 | 
						|
		url := "/file" + e
 | 
						|
		r, err := http.NewRequest("GET", url, nil)
 | 
						|
		if err != nil {
 | 
						|
			t.Error(err)
 | 
						|
		}
 | 
						|
		m.Next = nextFunc(true, mimes[e])
 | 
						|
		_, err = m.ServeHTTP(w, r)
 | 
						|
		if err != nil {
 | 
						|
			t.Error(err)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	w = httptest.NewRecorder()
 | 
						|
	exts = []string{
 | 
						|
		".htm1", ".abc", ".mdx",
 | 
						|
	}
 | 
						|
	for _, e := range exts {
 | 
						|
		url := "/file" + e
 | 
						|
		r, err := http.NewRequest("GET", url, nil)
 | 
						|
		if err != nil {
 | 
						|
			t.Error(err)
 | 
						|
		}
 | 
						|
		m.Next = nextFunc(false, "")
 | 
						|
		_, err = m.ServeHTTP(w, r)
 | 
						|
		if err != nil {
 | 
						|
			t.Error(err)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func nextFunc(shouldMime bool, contentType string) middleware.Handler {
 | 
						|
	return middleware.HandlerFunc(func(w http.ResponseWriter, r *http.Request) (int, error) {
 | 
						|
		if shouldMime {
 | 
						|
			if w.Header().Get("Content-Type") != contentType {
 | 
						|
				return 0, fmt.Errorf("expected Content-Type: %v, found %v", contentType, r.Header.Get("Content-Type"))
 | 
						|
			}
 | 
						|
			return 0, nil
 | 
						|
		}
 | 
						|
		if w.Header().Get("Content-Type") != "" {
 | 
						|
			return 0, fmt.Errorf("Content-Type header not expected")
 | 
						|
		}
 | 
						|
		return 0, nil
 | 
						|
	})
 | 
						|
}
 |