mirror of
https://github.com/caddyserver/caddy.git
synced 2025-12-06 21:25:31 -05:00
* caddypki: Add support for multiple intermediates in signing chain * Move intermediate lifetime configuration check In #7272 a check was changed to ensure that generated intermediate certificates would always use a lifetime that falls within the lifetime of the root. However, when a root and intermediate(s) are supplied, the configuration value was being used instead of the actual lifetimes of the certificates. The check was moved to only be performed when an intermediate is generated; not when loaded from disk. * Add tests for `pemDecodeCertificateChain` and `pemDecodeCertificate` * Use `crypto.Signer` instead of `any` in appropriate places * Use latest Smallstep packages --------- Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
315 lines
8.8 KiB
Go
315 lines
8.8 KiB
Go
// Copyright 2015 Matthew Holt and The Caddy Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package caddypki
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"crypto/x509"
|
|
"crypto/x509/pkix"
|
|
"encoding/pem"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.step.sm/crypto/keyutil"
|
|
"go.step.sm/crypto/pemutil"
|
|
)
|
|
|
|
func TestKeyPair_Load(t *testing.T) {
|
|
rootSigner, err := keyutil.GenerateDefaultSigner()
|
|
if err != nil {
|
|
t.Fatalf("Failed creating signer: %v", err)
|
|
}
|
|
|
|
tmpl := &x509.Certificate{
|
|
Subject: pkix.Name{CommonName: "test-root"},
|
|
IsCA: true,
|
|
MaxPathLen: 3,
|
|
}
|
|
rootBytes, err := x509.CreateCertificate(rand.Reader, tmpl, tmpl, rootSigner.Public(), rootSigner)
|
|
if err != nil {
|
|
t.Fatalf("Creating root certificate failed: %v", err)
|
|
}
|
|
|
|
root, err := x509.ParseCertificate(rootBytes)
|
|
if err != nil {
|
|
t.Fatalf("Parsing root certificate failed: %v", err)
|
|
}
|
|
|
|
intermediateSigner, err := keyutil.GenerateDefaultSigner()
|
|
if err != nil {
|
|
t.Fatalf("Creating intermedaite signer failed: %v", err)
|
|
}
|
|
|
|
intermediateBytes, err := x509.CreateCertificate(rand.Reader, &x509.Certificate{
|
|
Subject: pkix.Name{CommonName: "test-first-intermediate"},
|
|
IsCA: true,
|
|
MaxPathLen: 2,
|
|
NotAfter: time.Now().Add(time.Hour),
|
|
}, root, intermediateSigner.Public(), rootSigner)
|
|
if err != nil {
|
|
t.Fatalf("Creating intermediate certificate failed: %v", err)
|
|
}
|
|
|
|
intermediate, err := x509.ParseCertificate(intermediateBytes)
|
|
if err != nil {
|
|
t.Fatalf("Parsing intermediate certificate failed: %v", err)
|
|
}
|
|
|
|
var chainContents []byte
|
|
chain := []*x509.Certificate{intermediate, root}
|
|
for _, cert := range chain {
|
|
b, err := pemutil.Serialize(cert)
|
|
if err != nil {
|
|
t.Fatalf("Failed serializing intermediate certificate: %v", err)
|
|
}
|
|
chainContents = append(chainContents, pem.EncodeToMemory(b)...)
|
|
}
|
|
|
|
dir := t.TempDir()
|
|
rootCertFile := filepath.Join(dir, "root.pem")
|
|
if _, err = pemutil.Serialize(root, pemutil.WithFilename(rootCertFile)); err != nil {
|
|
t.Fatalf("Failed serializing root certificate: %v", err)
|
|
}
|
|
rootKeyFile := filepath.Join(dir, "root.key")
|
|
if _, err = pemutil.Serialize(rootSigner, pemutil.WithFilename(rootKeyFile)); err != nil {
|
|
t.Fatalf("Failed serializing root key: %v", err)
|
|
}
|
|
intermediateCertFile := filepath.Join(dir, "intermediate.pem")
|
|
if _, err = pemutil.Serialize(intermediate, pemutil.WithFilename(intermediateCertFile)); err != nil {
|
|
t.Fatalf("Failed serializing intermediate certificate: %v", err)
|
|
}
|
|
intermediateKeyFile := filepath.Join(dir, "intermediate.key")
|
|
if _, err = pemutil.Serialize(intermediateSigner, pemutil.WithFilename(intermediateKeyFile)); err != nil {
|
|
t.Fatalf("Failed serializing intermediate key: %v", err)
|
|
}
|
|
chainFile := filepath.Join(dir, "chain.pem")
|
|
if err := os.WriteFile(chainFile, chainContents, 0644); err != nil {
|
|
t.Fatalf("Failed writing intermediate chain: %v", err)
|
|
}
|
|
|
|
t.Run("ok/single-certificate-without-signer", func(t *testing.T) {
|
|
kp := KeyPair{
|
|
Certificate: rootCertFile,
|
|
}
|
|
chain, signer, err := kp.Load()
|
|
if err != nil {
|
|
t.Fatalf("Failed loading KeyPair: %v", err)
|
|
}
|
|
if len(chain) != 1 {
|
|
t.Errorf("Expected 1 certificate in chain; got %d", len(chain))
|
|
}
|
|
if signer != nil {
|
|
t.Error("Expected no signer to be returned")
|
|
}
|
|
})
|
|
|
|
t.Run("ok/single-certificate-with-signer", func(t *testing.T) {
|
|
kp := KeyPair{
|
|
Certificate: rootCertFile,
|
|
PrivateKey: rootKeyFile,
|
|
}
|
|
chain, signer, err := kp.Load()
|
|
if err != nil {
|
|
t.Fatalf("Failed loading KeyPair: %v", err)
|
|
}
|
|
if len(chain) != 1 {
|
|
t.Errorf("Expected 1 certificate in chain; got %d", len(chain))
|
|
}
|
|
if signer == nil {
|
|
t.Error("Expected signer to be returned")
|
|
}
|
|
})
|
|
|
|
t.Run("ok/multiple-certificates-with-signer", func(t *testing.T) {
|
|
kp := KeyPair{
|
|
Certificate: chainFile,
|
|
PrivateKey: intermediateKeyFile,
|
|
}
|
|
chain, signer, err := kp.Load()
|
|
if err != nil {
|
|
t.Fatalf("Failed loading KeyPair: %v", err)
|
|
}
|
|
if len(chain) != 2 {
|
|
t.Errorf("Expected 2 certificates in chain; got %d", len(chain))
|
|
}
|
|
if signer == nil {
|
|
t.Error("Expected signer to be returned")
|
|
}
|
|
})
|
|
|
|
t.Run("fail/non-matching-public-key", func(t *testing.T) {
|
|
kp := KeyPair{
|
|
Certificate: intermediateCertFile,
|
|
PrivateKey: rootKeyFile,
|
|
}
|
|
chain, signer, err := kp.Load()
|
|
if err == nil {
|
|
t.Error("Expected loading KeyPair to return an error")
|
|
}
|
|
if chain != nil {
|
|
t.Error("Expected no chain to be returned")
|
|
}
|
|
if signer != nil {
|
|
t.Error("Expected no signer to be returned")
|
|
}
|
|
})
|
|
}
|
|
|
|
func Test_pemDecodeCertificate(t *testing.T) {
|
|
signer, err := keyutil.GenerateDefaultSigner()
|
|
if err != nil {
|
|
t.Fatalf("Failed creating signer: %v", err)
|
|
}
|
|
|
|
tmpl := &x509.Certificate{
|
|
Subject: pkix.Name{CommonName: "test-cert"},
|
|
IsCA: true,
|
|
MaxPathLen: 3,
|
|
}
|
|
derBytes, err := x509.CreateCertificate(rand.Reader, tmpl, tmpl, signer.Public(), signer)
|
|
if err != nil {
|
|
t.Fatalf("Creating root certificate failed: %v", err)
|
|
}
|
|
cert, err := x509.ParseCertificate(derBytes)
|
|
if err != nil {
|
|
t.Fatalf("Parsing root certificate failed: %v", err)
|
|
}
|
|
|
|
pemBlock, err := pemutil.Serialize(cert)
|
|
if err != nil {
|
|
t.Fatalf("Failed serializing certificate: %v", err)
|
|
}
|
|
pemData := pem.EncodeToMemory(pemBlock)
|
|
|
|
t.Run("ok", func(t *testing.T) {
|
|
cert, err := pemDecodeCertificate(pemData)
|
|
if err != nil {
|
|
t.Fatalf("Failed decoding PEM data: %v", err)
|
|
}
|
|
if cert == nil {
|
|
t.Errorf("Expected a certificate in PEM data")
|
|
}
|
|
})
|
|
|
|
t.Run("fail/no-pem-data", func(t *testing.T) {
|
|
cert, err := pemDecodeCertificate(nil)
|
|
if err == nil {
|
|
t.Fatalf("Expected pemDecodeCertificate to return an error")
|
|
}
|
|
if cert != nil {
|
|
t.Errorf("Expected pemDecodeCertificate to return nil")
|
|
}
|
|
})
|
|
|
|
t.Run("fail/multiple", func(t *testing.T) {
|
|
multiplePEMData := append(pemData, pemData...)
|
|
cert, err := pemDecodeCertificate(multiplePEMData)
|
|
if err == nil {
|
|
t.Fatalf("Expected pemDecodeCertificate to return an error")
|
|
}
|
|
if cert != nil {
|
|
t.Errorf("Expected pemDecodeCertificate to return nil")
|
|
}
|
|
})
|
|
|
|
t.Run("fail/no-pem-certificate", func(t *testing.T) {
|
|
pkData := pem.EncodeToMemory(&pem.Block{
|
|
Type: "PRIVATE KEY",
|
|
Bytes: []byte("some-bogus-private-key"),
|
|
})
|
|
cert, err := pemDecodeCertificate(pkData)
|
|
if err == nil {
|
|
t.Fatalf("Expected pemDecodeCertificate to return an error")
|
|
}
|
|
if cert != nil {
|
|
t.Errorf("Expected pemDecodeCertificate to return nil")
|
|
}
|
|
})
|
|
}
|
|
|
|
func Test_pemDecodeCertificateChain(t *testing.T) {
|
|
signer, err := keyutil.GenerateDefaultSigner()
|
|
if err != nil {
|
|
t.Fatalf("Failed creating signer: %v", err)
|
|
}
|
|
|
|
tmpl := &x509.Certificate{
|
|
Subject: pkix.Name{CommonName: "test-cert"},
|
|
IsCA: true,
|
|
MaxPathLen: 3,
|
|
}
|
|
derBytes, err := x509.CreateCertificate(rand.Reader, tmpl, tmpl, signer.Public(), signer)
|
|
if err != nil {
|
|
t.Fatalf("Creating root certificate failed: %v", err)
|
|
}
|
|
cert, err := x509.ParseCertificate(derBytes)
|
|
if err != nil {
|
|
t.Fatalf("Parsing root certificate failed: %v", err)
|
|
}
|
|
|
|
pemBlock, err := pemutil.Serialize(cert)
|
|
if err != nil {
|
|
t.Fatalf("Failed serializing certificate: %v", err)
|
|
}
|
|
pemData := pem.EncodeToMemory(pemBlock)
|
|
|
|
t.Run("ok/single", func(t *testing.T) {
|
|
certs, err := pemDecodeCertificateChain(pemData)
|
|
if err != nil {
|
|
t.Fatalf("Failed decoding PEM data: %v", err)
|
|
}
|
|
if len(certs) != 1 {
|
|
t.Errorf("Expected 1 certificate in PEM data; got %d", len(certs))
|
|
}
|
|
})
|
|
|
|
t.Run("ok/multiple", func(t *testing.T) {
|
|
multiplePEMData := append(pemData, pemData...)
|
|
certs, err := pemDecodeCertificateChain(multiplePEMData)
|
|
if err != nil {
|
|
t.Fatalf("Failed decoding PEM data: %v", err)
|
|
}
|
|
if len(certs) != 2 {
|
|
t.Errorf("Expected 2 certificates in PEM data; got %d", len(certs))
|
|
}
|
|
})
|
|
|
|
t.Run("fail/no-pem-certificate", func(t *testing.T) {
|
|
pkData := pem.EncodeToMemory(&pem.Block{
|
|
Type: "PRIVATE KEY",
|
|
Bytes: []byte("some-bogus-private-key"),
|
|
})
|
|
certs, err := pemDecodeCertificateChain(pkData)
|
|
if err == nil {
|
|
t.Fatalf("Expected pemDecodeCertificateChain to return an error")
|
|
}
|
|
if len(certs) != 0 {
|
|
t.Errorf("Expected 0 certificates in PEM data; got %d", len(certs))
|
|
}
|
|
})
|
|
|
|
t.Run("fail/no-der-certificate", func(t *testing.T) {
|
|
certs, err := pemDecodeCertificateChain([]byte("invalid-der-data"))
|
|
if err == nil {
|
|
t.Fatalf("Expected pemDecodeCertificateChain to return an error")
|
|
}
|
|
if len(certs) != 0 {
|
|
t.Errorf("Expected 0 certificates in PEM data; got %d", len(certs))
|
|
}
|
|
})
|
|
}
|