Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Delete temp file used for atomic writes even if renaming fails

Browse Source
This commit is contained in:
Kovid Goyal 2022-03-09 07:54:44 +05:30
parent 007099dd60
commit 0012b7cd64
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/calibre/utils/config_base.py
View File

@ -367,9 +367,13 @@ def commit_data(file_path, data):
from calibre.utils.filenames import atomic_rename from calibre.utils.filenames import atomic_rename
bdir = os.path.dirname(file_path) bdir = os.path.dirname(file_path)
os.makedirs(bdir, exist_ok=True, mode=CONFIG_DIR_MODE) os.makedirs(bdir, exist_ok=True, mode=CONFIG_DIR_MODE)
try:
with tempfile.NamedTemporaryFile(dir=bdir, delete=False) as f: with tempfile.NamedTemporaryFile(dir=bdir, delete=False) as f:
f.write(data) f.write(data)
atomic_rename(f.name, file_path) atomic_rename(f.name, file_path)
finally:
with suppress(FileNotFoundError, NameError):
os.remove(f.name)
class Config(ConfigInterface): class Config(ConfigInterface):