Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add a check for ASCII control codes in translation files

Browse Source
This commit is contained in:
Kovid Goyal 2018-01-05 12:31:57 +05:30
parent e0c1de3ef4
commit 0053ee6456
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
setup/translations.py
View File

@ -651,6 +651,15 @@ class GetTranslations(Translations): # {{{
p.wait() p.wait()
return errs return errs
def check_for_control_chars(f):
raw = open(f, 'rb').read().decode('utf-8')
pat = re.compile(ur'[\0-\x08\x0b\x0c\x0e-\x1f\x7f]')
errs = []
for i, line in enumerate(raw.splitlines()):
if pat.search(line) is not None:
errs.append('There are ASCII control codes on line number: {}'.format(i + 1))
return '\n'.join(errs)
for f in files: for f in files:
errs = check(f) errs = check(f)
if errs: if errs:
@ -659,6 +668,11 @@ class GetTranslations(Translations): # {{{
edit_file(f) edit_file(f)
if check(f): if check(f):
raise SystemExit('Aborting as not all errors were fixed') raise SystemExit('Aborting as not all errors were fixed')
errs = check_for_control_chars(f)
if errs:
print(f, 'has ASCII control codes in it')
print(errs)
raise SystemExit(1)
def check_website(self): def check_website(self):
errors = os.path.join(tempfile.gettempdir(), 'calibre-translation-errors') errors = os.path.join(tempfile.gettempdir(), 'calibre-translation-errors')