diff --git a/src/calibre/ebooks/fb2/fb2ml.py b/src/calibre/ebooks/fb2/fb2ml.py index 3bc3424c39..36e65f6f0e 100644 --- a/src/calibre/ebooks/fb2/fb2ml.py +++ b/src/calibre/ebooks/fb2/fb2ml.py @@ -67,14 +67,14 @@ class FB2MLizer(object): def fb2mlize_spine(self): self.image_hrefs = {} self.link_hrefs = {} - output = self.fb2_header() - output += self.get_cover_page() - output += u'ghji87yhjko0Caliblre-toc-placeholder-for-insertion-later8ujko0987yjk' - output += self.get_text() - output += self.fb2_body_footer() - output += self.fb2mlize_images() - output += self.fb2_footer() - output = output.replace(u'ghji87yhjko0Caliblre-toc-placeholder-for-insertion-later8ujko0987yjk', self.get_toc()) + output = [self.fb2_header()] + output.append(self.get_cover_page()) + output.append(u'ghji87yhjko0Caliblre-toc-placeholder-for-insertion-later8ujko0987yjk') + output.append(self.get_text()) + output.append(self.fb2_body_footer()) + output.append(self.fb2mlize_images()) + output.append(self.fb2_footer()) + output = ''.join(output).replace(u'ghji87yhjko0Caliblre-toc-placeholder-for-insertion-later8ujko0987yjk', self.get_toc()) return u'\n%s' % etree.tostring(etree.fromstring(output), encoding=unicode, pretty_print=True) def fb2_header(self): @@ -117,25 +117,25 @@ class FB2MLizer(object): return output def get_toc(self): - toc = u'' + toc = [u''] if self.opts.inline_toc: self.log.debug('Generating table of contents...') - toc += u'

%s

' % _('Table of Contents:') + toc.append(u'

%s

' % _('Table of Contents:')) for item in self.oeb_book.toc: if item.href in self.link_hrefs.keys(): - toc += '

%s

\n' % (self.link_hrefs[item.href], item.title) + toc.append('

%s

\n' % (self.link_hrefs[item.href], item.title)) else: self.oeb.warn('Ignoring toc item: %s not found in document.' % item) - return toc + return ''.join(toc) def get_text(self): - text = u'' + text = [u''] for item in self.oeb_book.spine: self.log.debug('Converting %s to FictionBook2 XML' % item.href) stylizer = Stylizer(item.data, item.href, self.oeb_book, self.opts.output_profile) - text += self.add_page_anchor(item) + text.append(self.add_page_anchor(item)) text += self.dump_text(item.data.find(XHTML('body')), stylizer, item) - return text + return ''.join(text) def fb2_body_footer(self): return u'\n\n' @@ -155,7 +155,7 @@ class FB2MLizer(object): return '' % aid def fb2mlize_images(self): - images = u'' + images = [u''] for item in self.oeb_book.manifest: if item.media_type in OEB_RASTER_IMAGES: try: @@ -174,23 +174,23 @@ class FB2MLizer(object): col = 1 col += 1 data += char - images += '%s\n' % (self.image_hrefs.get(item.href, '0000.JPEG'), item.media_type, data) + images.append('%s\n' % (self.image_hrefs.get(item.href, '0000.JPEG'), item.media_type, data)) except Exception as e: self.log.error('Error: Could not include file %s becuase ' \ '%s.' % (item.href, e)) - return images + return ''.join(images) def dump_text(self, elem, stylizer, page, tag_stack=[]): if not isinstance(elem.tag, basestring) \ or namespace(elem.tag) != XHTML_NS: - return u'' + return [u''] - fb2_text = u'' + fb2_text = [u''] style = stylizer.style(elem) if style['display'] in ('none', 'oeb-page-head', 'oeb-page-foot') \ or style['visibility'] == 'hidden': - return u'' + return [u''] tag = barename(elem.tag) tag_count = 0 @@ -199,33 +199,33 @@ class FB2MLizer(object): if elem.attrib.get('src', None): if page.abshref(elem.attrib['src']) not in self.image_hrefs.keys(): self.image_hrefs[page.abshref(elem.attrib['src'])] = '%s.jpg' % len(self.image_hrefs.keys()) - fb2_text += '' % self.image_hrefs[page.abshref(elem.attrib['src'])] + fb2_text.append('' % self.image_hrefs[page.abshref(elem.attrib['src'])]) if tag in TAG_LINKS: href = elem.get('href') if href: href = prepare_string_for_xml(page.abshref(href)) if '://' in href: - fb2_text += '' % href + fb2_text.append('' % href) else: if '#' not in href: href += '#' if href not in self.link_hrefs.keys(): self.link_hrefs[href] = 'calibre_link-%s' % len(self.link_hrefs.keys()) href = self.link_hrefs[href] - fb2_text += '' % href + fb2_text.append('' % href) tag_count += 1 tag_stack.append('a') # Anchor ids id_name = elem.get('id') if id_name: - fb2_text += self.get_anchor(page, id_name) + fb2_text.append(self.get_anchor(page, id_name)) fb2_tag = TAG_MAP.get(tag, None) if fb2_tag and fb2_tag not in tag_stack: tag_count += 1 - fb2_text += '<%s>' % fb2_tag + fb2_text.append('<%s>' % fb2_tag) tag_stack.append(fb2_tag) # Processes style information @@ -233,15 +233,15 @@ class FB2MLizer(object): style_tag = s[1].get(style[s[0]], None) if style_tag: tag_count += 1 - fb2_text += '<%s>' % style_tag + fb2_text.append('<%s>' % style_tag) tag_stack.append(style_tag) if tag in TAG_SPACE: if not fb2_text or fb2_text[-1] != ' ': - fb2_text += ' ' + fb2_text.append(' ') if hasattr(elem, 'text') and elem.text != None: - fb2_text += prepare_string_for_xml(elem.text) + fb2_text.append(prepare_string_for_xml(elem.text)) for item in elem: fb2_text += self.dump_text(item, stylizer, page, tag_stack) @@ -253,16 +253,16 @@ class FB2MLizer(object): if hasattr(elem, 'tail') and elem.tail != None: if 'p' not in tag_stack: - fb2_text += '

%s

' % prepare_string_for_xml(elem.tail) + fb2_text.append('

%s

' % prepare_string_for_xml(elem.tail)) else: - fb2_text += prepare_string_for_xml(elem.tail) + fb2_text.append(prepare_string_for_xml(elem.tail)) return fb2_text def close_tags(self, tags): - fb2_text = u'' + fb2_text = [u''] for i in range(0, len(tags)): fb2_tag = tags.pop() - fb2_text += '' % fb2_tag + fb2_text.append('' % fb2_tag) return fb2_text diff --git a/src/calibre/ebooks/txt/txtml.py b/src/calibre/ebooks/txt/txtml.py index eff239668d..c705bcf221 100644 --- a/src/calibre/ebooks/txt/txtml.py +++ b/src/calibre/ebooks/txt/txtml.py @@ -52,7 +52,7 @@ class TXTMLizer(object): stylizer = Stylizer(item.data, item.href, self.oeb_book, self.opts.output_profile) content = unicode(etree.tostring(item.data.find(XHTML('body')), encoding=unicode)) content = self.remove_newlines(content) - output += self.dump_text(etree.fromstring(content), stylizer)) + output += self.dump_text(etree.fromstring(content), stylizer) output = self.cleanup_text(u''.join(output)) return output