Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix exception when rendering empty fields

Browse Source
This commit is contained in:
Kovid Goyal 2017-05-19 10:57:09 +05:30
parent 2d403e9d64
commit 039f585533
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/pyj/book_list/book_details.pyj
View File

@ -138,6 +138,8 @@ def render_metadata(mi, table, book_id): # {{{
comments = {}
def add_row(name, val, is_searchable=False, is_html=False, join=None):
if val is undefined or val is None:
return
def add_val(v):
if not v.appendChild:
v += ''
@ -297,17 +299,19 @@ def render_metadata(mi, table, book_id): # {{{
func(field, fm, name, val)
else:
if datatype is 'text' or datatype is 'enumeration':
join = fm.is_multiple.list_to_ui if fm.is_multiple else None
add_row(name, val, join=join, is_searchable=field)
if val is not undefined and val is not None:
join = fm.is_multiple.list_to_ui if fm.is_multiple else None
add_row(name, val, join=join, is_searchable=field)
elif datatype is 'bool':
add_row(name, _('Yes') if val else _('No'))
elif datatype is 'int' or datatype is 'float':
fmt = (fm.display or {}).number_format
if fmt:
val = fmt.format(val)
else:
val += ''
add_row(name, val)
if val is not undefined and val is not None:
fmt = (fm.display or {}).number_format
if fmt:
val = fmt.format(val)
else:
val += ''
add_row(name, val)
for field in fields:
fm = field_metadata[field]