From 059f3f70c0a1a1f6f703c2c159144fdf9c7477c8 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 22 Mar 2016 20:45:10 +0530 Subject: [PATCH] More useful error message when fetching plugins list fails --- src/calibre/gui2/dialogs/plugin_updater.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/calibre/gui2/dialogs/plugin_updater.py b/src/calibre/gui2/dialogs/plugin_updater.py index b2529a689e..7b545e9f92 100644 --- a/src/calibre/gui2/dialogs/plugin_updater.py +++ b/src/calibre/gui2/dialogs/plugin_updater.py @@ -430,7 +430,14 @@ class PluginUpdaterDialog(SizePersistedDialog): self._initialize_controls() self._create_context_menu() - display_plugins = read_available_plugins() + try: + display_plugins = read_available_plugins(raise_error=True) + except Exception: + display_plugins = [] + import traceback + error_dialog(self.gui, _('Update Check Failed'), + _('Unable to reach the plugin index page.'), + det_msg=traceback.format_exc(), show=True) if display_plugins: self.model = DisplayPluginModel(display_plugins) @@ -443,9 +450,6 @@ class PluginUpdaterDialog(SizePersistedDialog): self.filter_combo.setCurrentIndex(initial_filter) self._select_and_focus_view() else: - error_dialog(self.gui, _('Update Check Failed'), - _('Unable to reach the plugin index page.'), - det_msg=INDEX_URL, show=True) self.filter_combo.setEnabled(False) # Cause our dialog size to be restored from prefs or created on first usage self.resize_dialog()