From 069761e03e4f0e1bb963bfdde5aff029c0111f3b Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Mon, 1 Apr 2013 09:55:07 +0530 Subject: [PATCH] PDF Output: Fix generating page numbers causing links to not work. Fixes #1162573 (Hyperlinks disappear on mobi/epub to pdf conversion) --- src/calibre/ebooks/pdf/render/from_html.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/calibre/ebooks/pdf/render/from_html.py b/src/calibre/ebooks/pdf/render/from_html.py index 2f08e843b0..525bed16a3 100644 --- a/src/calibre/ebooks/pdf/render/from_html.py +++ b/src/calibre/ebooks/pdf/render/from_html.py @@ -302,6 +302,10 @@ class PDFWriter(QObject): py_bridge.value = book_indexing.all_links_and_anchors(); '''%(self.margin_top, 0, self.margin_bottom)) + amap = self.bridge_value + if not isinstance(amap, dict): + amap = {'links':[], 'anchors':{}} # Some javascript error occurred + if self.header: self.bridge_value = self.header evaljs('paged_display.header_template = py_bridge.value') @@ -311,9 +315,6 @@ class PDFWriter(QObject): if self.header or self.footer: evaljs('paged_display.create_header_footer();') - amap = self.bridge_value - if not isinstance(amap, dict): - amap = {'links':[], 'anchors':{}} # Some javascript error occurred start_page = self.current_page_num mf = self.view.page().mainFrame()