Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bulk metadata edit dialog: Allow search & replace to work for ratings columns as well.

Browse Source 
Merge branch 'master' of https://github.com/cbhaley/calibre
This commit is contained in:
Kovid Goyal 2016-09-19 19:56:22 +05:30
commit 09421c66ee
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/calibre/gui2/dialogs/metadata_bulk.py
View File

@ -451,7 +451,7 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog):
fm = self.db.field_metadata fm = self.db.field_metadata
for f in fm: for f in fm:
if (f in ['author_sort'] or if (f in ['author_sort'] or
(fm[f]['datatype'] in ['text', 'series', 'enumeration', 'comments'] and (fm[f]['datatype'] in ['text', 'series', 'enumeration', 'comments', 'rating'] and
fm[f].get('search_terms', None) and fm[f].get('search_terms', None) and
f not in ['formats', 'ondevice', 'series_sort']) or f not in ['formats', 'ondevice', 'series_sort']) or
(fm[f]['datatype'] in ['int', 'float', 'bool', 'datetime'] and (fm[f]['datatype'] in ['int', 'float', 'bool', 'datetime'] and
@ -751,6 +751,18 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog):
raise Exception(_('You must specify a destination when source is ' raise Exception(_('You must specify a destination when source is '
'a composite field or a template')) 'a composite field or a template'))
dest = src dest = src
if self.destination_field_fm['datatype'] == 'rating' and val[0]:
ok = True
try:
v = int(val[0])
if v < 0 or v > 10:
ok = False;
except:
ok = False
if not ok:
raise Exception(_('The replacement value for a rating column must '
'be empty or an integer between 0 and 10'))
dest_mode = self.replace_mode.currentIndex() dest_mode = self.replace_mode.currentIndex()
if self.destination_field_fm['is_csp']: if self.destination_field_fm['is_csp']:
@ -881,6 +893,11 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog):
if not val and dfm['datatype'] == 'datetime': if not val and dfm['datatype'] == 'datetime':
val = None val = None
if dfm['datatype'] == 'rating':
if (not val or int(val) == 0):
val = None
if dest == 'rating' and val:
val = (int(val) // 2) * 2
self.set_field_calls[dest][book_id] = val self.set_field_calls[dest][book_id] = val
# }}} # }}}
@ -967,7 +984,7 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog):
if self.s_r_error is not None and do_sr: if self.s_r_error is not None and do_sr:
error_dialog(self, _('Search/replace invalid'), error_dialog(self, _('Search/replace invalid'),
_('Search pattern is invalid: %s')%self.s_r_error.message, _('Search/replace is invalid: %s')%self.s_r_error.message,
show=True) show=True)
return False return False
self.changed = bool(self.ids) self.changed = bool(self.ids)